From patchwork Thu Sep 10 15:06:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249639 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp825943ilk; Thu, 10 Sep 2020 08:05:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBcbjJmo/Uu6qhWqo/CIsjtaV33CIampnhQD4LvaEPIjHANHFT/k1SMtyKto4ycpz+NIHL X-Received: by 2002:a92:7305:: with SMTP id o5mr8523144ilc.146.1599750351478; Thu, 10 Sep 2020 08:05:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599750351; cv=none; d=google.com; s=arc-20160816; b=FwyZAg6czHU/NQRVV5ClfHAMIJzZ9XjgQ3iYV1RhcZaQLRjVNbQX280IgqdNKfemWl gapxhnx+CCC0iem08hyFntounUG4XjqiTeGHoWbcZ+YxHwOoLIWwOpCw844VM51BZ9M4 rW0ottZHisIp4gYYTnBPdkAIchSeJyNwdg0mw899FNiO2yb0woWsEKIHHfK0AgFFMKzJ pwwJAfvySEDW722JxmhTyUFyMABa8vYD2v1sJH0Eq6eJjne1V5Rv/7iN3IJmuezU1ajC S8I9pRJU+k7Dz7N90fcZFaQZZ4thBKokj8CBechyPaPBbL4tX/ndIRxfTe0z+xbjyLgC m4fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:dkim-signature; bh=63pHhzPfaee1ytdnWtn5CADr9WXAT2OTo2t4coSSJJ4=; b=c3ldmbW+oAsePDrIaQ65QhhHb3X4Ra1JKCTL4ZB0TNM1BShWTNb6swAyQ0ED3O/Q2G t3Fc39I0l1BaufktRyfLvEYliwC2kRESQ87oEZFNjHeFf930kIr890AaSOf0H9aQfnvD NVD01ELUHOvqXt2CBVStPgw2qvHBqF7uS0MwzVASof+KslL5QQYCXqYmnRWPL/xhmf7c l+CF34QQZS6B8vXKLKS3ETyzuZ7hGRBBQ7sZy/uKVRiQ6xyGu3SbBmdiIOj078tvPIJH g9B8HfC1+b1gfZJmkTzwy9vJRyK1fivcGicLUhH9hX0ipXZTA2JT2Pf9ksh54i8fux2H 9hWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=qsyD+zi1; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=D1kkdqvX; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id x5si4826505ila.127.2020.09.10.08.05.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 08:05:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=qsyD+zi1; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=D1kkdqvX; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=63pHhzPfaee1ytdnWtn5CADr9WXAT2OTo2t4coSSJJ4=; b=qsyD+zi1DOxkW6qBrUPHAicJrG 6p2KYIF8aEEdx2RB47TZiXbePRKDx7hVYnLI8EHOxmwI5Diivo1TuiJXD2fPqaBBMJeh7itoIPTy0 wcoLuH1KYe5pzmIBL2QZRxQWVCBj2rgZGsmj5N4XLOxEdnLgL50XNivnt+GJPi5LP3zng8UAZ3r1N 6H6QG7uoqy3jBGZuB3lVJyqMOBUhjMHlnIJbzmZsNBA/HmtvRd0jdsEDnmTrQRFcfWK6ND218WmS/ K6/n64ykWCOoh8Ovb/4B66sjMyY6ipcegwkbUPa8s093GrgRxdLLaonTDKH25qNE0ZeAGKcsL7cty 0BFxSDug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGO8x-0007fc-TB; Thu, 10 Sep 2020 15:05:47 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGO8u-0007e5-Ng for wcn36xx@lists.infradead.org; Thu, 10 Sep 2020 15:05:46 +0000 Received: by mail-wm1-x344.google.com with SMTP id s13so366006wmh.4 for ; Thu, 10 Sep 2020 08:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KMf9EB5Mu6K6rHazidoIudnwtwroJlrj/VId80zyrmk=; b=D1kkdqvXNUWmZQoz/Tv5BUmeYeMtRaIo+M938Ay8vpnfIJgq2K/RqlgLAyzLVqYClL +gqXzScSK5mWPX/2kbQzHvmpz9dnn/Skee4yjF3pAUVp9KwOY8Nv/fBHrHr26+JLoJrq zd8XT0qKI6k/Xtwsn6rlJwwrXCMfLGM+AlM7pQebQhMOTRreztNFxZNHsIg1wHN8WrPY sSU4W5uXYvsJkj12VG09weGiit+fmzVZIl04uyKSDsbeyoqIpEXvCMD3q5CS0uOux4R9 liqaefSo/puMDjcDWYIatXlne0c2EUcI/+myo6Iqay6O+EXe+PnVcu9eBPUsOG0pm5NZ ACwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KMf9EB5Mu6K6rHazidoIudnwtwroJlrj/VId80zyrmk=; b=eHVrCGA/kMQUB7nSUD6QUh8TihYoZ71B+mktYk4n/fmt7mndV2VkcEQ2y+KslCGYzX PdJtWsWh5LeWZjV4km3XAxXQxd5X+Yt2Tk0dFuzju/cVMw8N5ItslHmWuh3sAA4K8tVP Gr3oDePYpWN8IUkkmusnghwAp2H/p4XFSGac/+OzRh3PrU+hUpCAbS5oI/zZeFK1Fc3p SBdS+omGr9Rxbkq29Oy9f90KvgwLplBSMpte8YOyvgF/SzUlPlD03ysM5Y4YLV8jB4Yg Rly5yz9/Ek64n7SomdHLl7vMMSs6F3WU6XqKg/xtnyyLAwpbfOUbaIIjYE3mNNo5mYwX FeQg== X-Gm-Message-State: AOAM532ZviVQrXyy2zjNANizqSyMYYIqK2Cj2fOXEWaisq3CjigMSCqa VzWn8hUt0EZYLyoxLfFRrx6r2A== X-Received: by 2002:a7b:cc8f:: with SMTP id p15mr477428wma.18.1599750343684; Thu, 10 Sep 2020 08:05:43 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id k24sm3857005wmj.19.2020.09.10.08.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 08:05:43 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v5 0/7] wcn36xx: Tidy up BSS/STA config Date: Thu, 10 Sep 2020 16:06:24 +0100 Message-Id: <20200910150631.2178970-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_110544_802029_512CF10D X-CRM114-Status: GOOD ( 10.92 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This series is three in a set of seven to add support for wcn3680 at 802.11ac data-rates. Both the BSS and STA config paths have redundant/duplicate code. Before adding more code to either it makes sense to reduce/reuse and functionally decompose as much as possible. While not strictly necessary to get the wcn3680/80211.ac functioning in this driver, it seems like a missed opportunity to leave the code as is. Lets reduce down before adding more. V5: - Fixes -W=1 warning caught in this set by kernel build robot I'm still declaring some functions standalone for the purposes of granularity and bisectability, a later patch makes relevant functions static. V4: - No functional change. Sending out full set again using --base=ath-202009090652 to aid kernel test robot - https://lore.kernel.org/linux-wireless/20200908182455.2870345-1-bryan.odonoghue@linaro.org/T/#t V3: - No functional difference to V2 https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#t - Adds Loic's Reviewed-by as indicated https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#m2256137b97859c8eac26a2836f96db5e82475d3f V2: - Adds a memset to wcn36xx_smd_config_bss_v1() Since we are doing one less kzalloc() we need to make sure we clear out the bss config. V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t Bryan O'Donoghue (7): wcn36xx: Functionally decompose wcn36xx_smd_config_sta() wcn36xx: Move wcn36xx_smd_set_sta_params() inside wcn36xx_smd_config_bss() wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params() wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally wcn36xx: Add wcn36xx_smd_config_bss_v0 wcn36xx: Convert to using wcn36xx_smd_config_bss_v0() wcn36xx: Remove dead code in wcn36xx_smd_config_bss() drivers/net/wireless/ath/wcn36xx/smd.c | 422 ++++++++++++++----------- 1 file changed, 234 insertions(+), 188 deletions(-) base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69 prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938 prerequisite-patch-id: af468d413daaf8d2aad195fcb43c6e66390d8468 prerequisite-patch-id: 08122a9557904ce5358f52dd08cc33270fa202c1 prerequisite-patch-id: 82e0b7c5b2e9fa80baca001cce12577d98e306a9 prerequisite-patch-id: 8ee7f5bd6cb5b7b7d713947b554ad93bb90d8230 prerequisite-patch-id: d05c2253e4523b05b2e43491aa13ceeef68fd2f0 prerequisite-patch-id: 8be29513d3efa64df15297bcf81ec3db55088ee1 prerequisite-patch-id: d267dcd834afad75a69bcd2adcccfdad6566a7ba -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx