mbox series

[0/8] wireless: remove WDS mode

Message ID 20201109095747.113720-1-johannes@sipsolutions.net
Headers show
Series wireless: remove WDS mode | expand

Message

Johannes Berg Nov. 9, 2020, 9:57 a.m. UTC 
We use 4-addr AP/client instead. Remove WDS code that was
basically not possible to enable anyway.

johannes

Comments

Johannes Berg Nov. 9, 2020, 11:12 a.m. UTC | #1 
On Mon, 2020-11-09 at 13:11 +0200, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > From: Johannes Berg <johannes.berg@intel.com>
> > 
> > Remove all the code that was there to configure WDS interfaces,
> > now that there's no way to reach it anymore.
> > 
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
> [...]
> 
> > @@ -675,10 +673,8 @@ int wiphy_register(struct wiphy *wiphy)
> >  		     !(wiphy->nan_supported_bands & BIT(NL80211_BAND_2GHZ)))))
> >  		return -EINVAL;
> >  
> > -#ifndef CONFIG_WIRELESS_WDS
> >  	if (WARN_ON(wiphy->interface_modes & BIT(NL80211_IFTYPE_WDS)))
> >  		return -EINVAL;
> > -#endif
> 
> What about out-of-tree drivers? Should we have (or do we already have?)
> a some kind safe guard if an out of tree driver tries to use WDS?

That's what happens here, no? We warn and return invalid - now
unconditionally, before we allowed it if CONFIG_WIRELESS_WDS was
enabled.

johannes