mbox series

[v3,0/9] misc brcmfmac fixes (M1/T2 series spin-off)

Message ID 20220117142919.207370-1-marcan@marcan.st
Headers show
Series misc brcmfmac fixes (M1/T2 series spin-off) | expand

Message

Hector Martin Jan. 17, 2022, 2:29 p.m. UTC
Hi everyone,

This series contains just the fixes / misc improvements from the
previously submitted series:

brcmfmac: Support Apple T2 and M1 platforms

Patches 8-9 aren't strictly bugfixes but rather just general
improvements; they can be safely skipped, although patch 8 will be a
dependency of the subsequent series to avoid a compile warning.

Hector Martin (9):
  brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path
  brcmfmac: firmware: Allocate space for default boardrev in nvram
  brcmfmac: firmware: Do not crash on a NULL board_type
  brcmfmac: pcie: Declare missing firmware files in pcie.c
  brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio
  brcmfmac: pcie: Fix crashes due to early IRQs
  brcmfmac: of: Use devm_kstrdup for board_type & check for errors
  brcmfmac: fwil: Constify iovar name arguments
  brcmfmac: pcie: Read the console on init and shutdown

 .../broadcom/brcm80211/brcmfmac/firmware.c    |  5 ++
 .../broadcom/brcm80211/brcmfmac/fwil.c        | 34 ++++----
 .../broadcom/brcm80211/brcmfmac/fwil.h        | 28 +++----
 .../wireless/broadcom/brcm80211/brcmfmac/of.c |  8 +-
 .../broadcom/brcm80211/brcmfmac/pcie.c        | 77 ++++++++-----------
 .../broadcom/brcm80211/brcmfmac/sdio.c        |  1 -
 6 files changed, 72 insertions(+), 81 deletions(-)

Comments

Andy Shevchenko Jan. 18, 2022, 10:43 a.m. UTC | #1
On Mon, Jan 17, 2022 at 4:30 PM Hector Martin <marcan@marcan.st> wrote:
>
> Hi everyone,
>
> This series contains just the fixes / misc improvements from the
> previously submitted series:
>
> brcmfmac: Support Apple T2 and M1 platforms
>
> Patches 8-9 aren't strictly bugfixes but rather just general
> improvements; they can be safely skipped, although patch 8 will be a
> dependency of the subsequent series to avoid a compile warning.

Have I given you a tag? If so, I do not see it applied in the patches...

> Hector Martin (9):
>   brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path
>   brcmfmac: firmware: Allocate space for default boardrev in nvram
>   brcmfmac: firmware: Do not crash on a NULL board_type
>   brcmfmac: pcie: Declare missing firmware files in pcie.c
>   brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio
>   brcmfmac: pcie: Fix crashes due to early IRQs
>   brcmfmac: of: Use devm_kstrdup for board_type & check for errors
>   brcmfmac: fwil: Constify iovar name arguments
>   brcmfmac: pcie: Read the console on init and shutdown
>
>  .../broadcom/brcm80211/brcmfmac/firmware.c    |  5 ++
>  .../broadcom/brcm80211/brcmfmac/fwil.c        | 34 ++++----
>  .../broadcom/brcm80211/brcmfmac/fwil.h        | 28 +++----
>  .../wireless/broadcom/brcm80211/brcmfmac/of.c |  8 +-
>  .../broadcom/brcm80211/brcmfmac/pcie.c        | 77 ++++++++-----------
>  .../broadcom/brcm80211/brcmfmac/sdio.c        |  1 -
>  6 files changed, 72 insertions(+), 81 deletions(-)
>
> --
> 2.33.0
>


--
With Best Regards,
Andy Shevchenko
Hector Martin Jan. 18, 2022, 3:32 p.m. UTC | #2
On 18/01/2022 19.43, Andy Shevchenko wrote:
> On Mon, Jan 17, 2022 at 4:30 PM Hector Martin <marcan@marcan.st> wrote:
>>
>> Hi everyone,
>>
>> This series contains just the fixes / misc improvements from the
>> previously submitted series:
>>
>> brcmfmac: Support Apple T2 and M1 platforms
>>
>> Patches 8-9 aren't strictly bugfixes but rather just general
>> improvements; they can be safely skipped, although patch 8 will be a
>> dependency of the subsequent series to avoid a compile warning.
> 
> Have I given you a tag? If so, I do not see it applied in the patches...

I didn't see any review tags from you in the previous thread. Did I miss
any?
Andy Shevchenko Jan. 18, 2022, 5:01 p.m. UTC | #3
On Tue, Jan 18, 2022 at 5:32 PM Hector Martin <marcan@marcan.st> wrote:
> On 18/01/2022 19.43, Andy Shevchenko wrote:
> > On Mon, Jan 17, 2022 at 4:30 PM Hector Martin <marcan@marcan.st> wrote:
> >>
> >> Hi everyone,
> >>
> >> This series contains just the fixes / misc improvements from the
> >> previously submitted series:
> >>
> >> brcmfmac: Support Apple T2 and M1 platforms
> >>
> >> Patches 8-9 aren't strictly bugfixes but rather just general
> >> improvements; they can be safely skipped, although patch 8 will be a
> >> dependency of the subsequent series to avoid a compile warning.
> >
> > Have I given you a tag? If so, I do not see it applied in the patches...
>
> I didn't see any review tags from you in the previous thread. Did I miss
> any?

I checked myself and indeed it seems my memory is about something
else, I'll check v3, last time I remember I found no (big) issues with
the fixes patches, I believe they are in shape.