mbox series

[0/4] ath12k: Factory test mode support

Message ID 20231030082749.17855-1-quic_aarasahu@quicinc.com
Headers show
Series ath12k: Factory test mode support | expand

Message

Aaradhana Sahu Oct. 30, 2023, 8:27 a.m. UTC
Device is booted in factory test mode for calibration.
The commands are sent from userspace application, which
is sent to firmware using wmi commands. Firmware sends
the response to driver as wmi events and driver sends
these events to the application via netlink message.

Also added changes related to correct pdev id access for
fw test cmd.

Aaradhana Sahu (3):
  wifi: ath: create common testmode_i.h file for ath drivers
  wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
  wifi: ath12k: add factory test mode support

Rajat Soni (1):
  wifi: ath12k: Fill pdev id for fw test cmd

 drivers/net/wireless/ath/ath11k/testmode.c    |  78 ++--
 drivers/net/wireless/ath/ath12k/Makefile      |   1 +
 drivers/net/wireless/ath/ath12k/core.c        |  19 +-
 drivers/net/wireless/ath/ath12k/core.h        |  13 +
 drivers/net/wireless/ath/ath12k/debug.h       |   1 +
 drivers/net/wireless/ath/ath12k/dp.c          |   3 +
 drivers/net/wireless/ath/ath12k/mac.c         |  13 +-
 drivers/net/wireless/ath/ath12k/pci.c         |   1 +
 drivers/net/wireless/ath/ath12k/testmode.c    | 413 ++++++++++++++++++
 drivers/net/wireless/ath/ath12k/testmode.h    |  42 ++
 drivers/net/wireless/ath/ath12k/wmi.c         |  38 +-
 drivers/net/wireless/ath/ath12k/wmi.h         |  22 +-
 .../wireless/ath/{ath11k => }/testmode_i.h    |  52 +--
 13 files changed, 624 insertions(+), 72 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c
 create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h
 rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (53%)


base-commit: 0263687f4441d5a5eab8074d56b4693c8f0acf85

Comments

Kalle Valo Oct. 30, 2023, 5:01 p.m. UTC | #1
Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 10/30/2023 1:27 AM, Aaradhana Sahu wrote:
>
>> Device is booted in factory test mode for calibration.
>> The commands are sent from userspace application, which
>> is sent to firmware using wmi commands. Firmware sends
>> the response to driver as wmi events and driver sends
>> these events to the application via netlink message.
>> Also added changes related to correct pdev id access for
>> fw test cmd.
>> Aaradhana Sahu (3):
>>    wifi: ath: create common testmode_i.h file for ath drivers
>>    wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
>>    wifi: ath12k: add factory test mode support
>> Rajat Soni (1):
>>    wifi: ath12k: Fill pdev id for fw test cmd
>>   drivers/net/wireless/ath/ath11k/testmode.c    |  78 ++--
>>   drivers/net/wireless/ath/ath12k/Makefile      |   1 +
>>   drivers/net/wireless/ath/ath12k/core.c        |  19 +-
>>   drivers/net/wireless/ath/ath12k/core.h        |  13 +
>>   drivers/net/wireless/ath/ath12k/debug.h       |   1 +
>>   drivers/net/wireless/ath/ath12k/dp.c          |   3 +
>>   drivers/net/wireless/ath/ath12k/mac.c         |  13 +-
>>   drivers/net/wireless/ath/ath12k/pci.c         |   1 +
>>   drivers/net/wireless/ath/ath12k/testmode.c    | 413 ++++++++++++++++++
>>   drivers/net/wireless/ath/ath12k/testmode.h    |  42 ++
>>   drivers/net/wireless/ath/ath12k/wmi.c         |  38 +-
>>   drivers/net/wireless/ath/ath12k/wmi.h         |  22 +-
>>   .../wireless/ath/{ath11k => }/testmode_i.h    |  52 +--
>>   13 files changed, 624 insertions(+), 72 deletions(-)
>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c
>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h
>>   rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (53%)
>> base-commit: 0263687f4441d5a5eab8074d56b4693c8f0acf85
>
> That base-commit is pretty old (tag: ath-202309051328) and your series
> fails to apply to current ath-next, please rebase:

That tag is almost two months old! Aaradhana, what an earth are you
testing with?

> Applying: wifi: ath: create common testmode_i.h file for ath drivers
> Applying: wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
> Applying: wifi: ath12k: add factory test mode support
> Patch failed at 0003 wifi: ath12k: add factory test mode support
>
> In addition, please use

Jeff, did you sent your mail too early? Something seems to be missing in
your mail.