| Message ID | 20231206034920.1037449-1-quic_periyasa@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Refactor MAC alloc/destroy/un/register helper functions | expand |
On 12/5/2023 7:49 PM, Karthikeyan Periyasamy wrote: > Currently, the data path pdev pre alloc and mac allocate are called > separately from the core start procedure. The data path pdev pre alloc > can be called from the mac allocate procedure itself since initialization > related to pdev happens in the mac allocate procedure. So move the caller > of DP pdev pre alloc from the core start procedure to the mac allocate > procedure. This change helps in the future to easily decouple the mac > allocate procedure from core start handling in order to support MLO in > multi chip. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
On 12/5/2023 7:49 PM, Karthikeyan Periyasamy wrote: > Currently, the MAC setup helper function is accessing the mac80211 hw > data. In the future, to support single/multi link operation, need to > decouple the mac80211 hw data from this helper function so that it can be > easy to scale these functions to support single/multi link operations. So > remove the mac80211 hw access from the ath12k_mac_setup_channels_rates() > helper function. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
On 12/5/2023 7:49 PM, Karthikeyan Periyasamy wrote: > Currently, the mac80211 hw registration procedure is tightly coupled with > the handling of link/radio (ar). Define a new helper function to separate > the link/radio handling from the mac80211 hw registration procedure for > improved code readability. Also, it can be easy to scale these > functionality to support single/multi link operation in the future. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Currently, the driver does not support single/multi link operation in 11be mode. Also, each link/radio gets registered as a separate wiphy through mac80211. In order to support multi link operation (MLO), the current separate wiphy registration approach brings a lot of complexity in cfg80211 and mac80211, such as synchronization across the multiple wiphy/hw. Determining the compatibility of the hw across multiple wiphy/hw is another challenge for userspace. To reduce these complexities in userspace/cfg80211/mac80211, need to move from the multi wiphy model to a single wiphy model. To support the single wiphy registration, we have to decouple the wiphy/mac80211 hw data from the link/radio (ar) structure. So refactor the MAC helper functions. Current Multi wiphy Model +---------------+ +---------------+ +-------------+ | Mac80211 hw | | Mac80211 hw | |Mac80211 hw | | private data | | private data | |private data | | | | | | | | | | | | | | | | | | | | ar (2GHz) | | ar (5GHz) | | ar (6GHz) | | | | | | | | | | | | | | | | | | | +---------------+ +---------------+ +-------------+ Single wiphy Model +--------------+ | Mac80211 hw | | private data | | | |ath12k hw (ah)| | +----------+ | | |ar (2GHz) | | | +----------+ | | | | | | |ar (5GHz) | | | +----------+ | | | | | | |ar (6GHz) | | | | | | | +----------+ | +--------------+ Karthikeyan Periyasamy (4): wifi: ath12k: Refactor the DP pdev pre alloc call sequence wifi: ath12k: Refactor the MAC allocation and destroy wifi: ath12k: Refactor MAC setup channel helper function wifi: ath12k: Refactor MAC un/register helper function drivers/net/wireless/ath/ath12k/core.c | 96 +++++++++-- drivers/net/wireless/ath/ath12k/mac.c | 216 +++++++++++-------------- drivers/net/wireless/ath/ath12k/mac.h | 8 +- 3 files changed, 184 insertions(+), 136 deletions(-) base-commit: 22d737065b8c4fbb29a3a818adcf88004ea7d5bb