From patchwork Wed Jan 15 13:54:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216627 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE31C33CB1 for ; Wed, 15 Jan 2020 13:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16FAA222C3 for ; Wed, 15 Jan 2020 13:59:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="DExnBvlj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729855AbgAONz0 (ORCPT ); Wed, 15 Jan 2020 08:55:26 -0500 Received: from mail-eopbgr770084.outbound.protection.outlook.com ([40.107.77.84]:58049 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729813AbgAONzX (ORCPT ); Wed, 15 Jan 2020 08:55:23 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVo1oVyWM9IF4fqn5vtIvcqIaICzUSPhCgLlkSauIAFJKPuTbUnh1bK4RuIcmsQNjtyHWe/7V8SMreQEbxlyz8kt9gR/ePopdtfj/Mw4As+cZEc6M9kUOMeCyOlJ8WFlP9mcdYjgvXXLkU7ka0TQqefZib+B0n9yyfKBRq/stib9AL5dyTZ3OxABOXi1oyFDwBbECRYt53/zfQo6t9QMUT27kCUVel+xBD/l7dOlq9693gMBLDUW9fsdqO6L3C5Xxr0KQtI0bq3QPh/aNnvlnjF5I9FHxDdmQ3Z7zHTj7XKXHXztSfzK+NTZtpqytC5PmtIW0rQ5TNySDnCUMROQ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2/Jm6w1JZAbFd2GIhM4GZMXqZt/BV+Jj6ZkQwLi2xk=; b=LbnlVUMoqLqLbDHhCC0CkBGrb/nhSgDPGYe6WS/LGeKEu8DYBhY9+EZuHDICwsC4CDexkvP5mfEIBfwpeALX5EVAP/I3A+dKIK4xUxp1/RywrOXr3f3tUk5TwwjWBDt301b3cOungfglwzaGBOt4ITSpyukDfRN0tApTXGoG22L0dyJzaNggDuB75UFDgFjW6hPXsBOJoY71D4a/pDPrzUmC4JgssbmisfBbGJKRtAtwYlrlNbzrJJK8Z1jmR2Fj7aYim9B5tC8Oy1DhRm6Tk2WeX9uf74AMMOKwr4RAN80mB7N1W+MV+X5ubtLQ0+EirmeFLQ/ovs/COjIztltfTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2/Jm6w1JZAbFd2GIhM4GZMXqZt/BV+Jj6ZkQwLi2xk=; b=DExnBvljHNaKwAAJL+qPVRD1fiQOZWj4GOFWCSj9TIDTbg9yzjzOd/9Yk8pfxgFg3RDUoLfh7vdP3Fkjv0V6KE9JEclh6zCwwjpdeK9u/m0eTrdOK1bn13xmHmx7/kDUcJcUPrxef66i/Ive40wZoYQilXUZcukYjyVErRc0Clc= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB3661.namprd11.prod.outlook.com (20.178.252.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18; Wed, 15 Jan 2020 13:55:18 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2623.018; Wed, 15 Jan 2020 13:55:18 +0000 Received: from pc-42.home (2a01:e35:8bf5:66a0:3dbe:4cb5:6059:a948) by PR2P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18 via Frontend Transport; Wed, 15 Jan 2020 13:54:50 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?q?iller?= Subject: [PATCH v2 33/65] staging: wfx: simplify hif_mib_set_data_filtering Thread-Topic: [PATCH v2 33/65] staging: wfx: simplify hif_mib_set_data_filtering Thread-Index: AQHVy6tbuB7e0lz3BkWa3Nsca80jng== Date: Wed, 15 Jan 2020 13:54:51 +0000 Message-ID: <20200115135338.14374-34-Jerome.Pouiller@silabs.com> References: <20200115135338.14374-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20200115135338.14374-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: PR2P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::20) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.25.0 x-originating-ip: [2a01:e35:8bf5:66a0:3dbe:4cb5:6059:a948] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 360623ee-eb74-4eb3-74a9-08d799c27df8 x-ms-traffictypediagnostic: MN2PR11MB3661: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1091; x-forefront-prvs: 02830F0362 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(136003)(346002)(366004)(199004)(189003)(8886007)(6486002)(316002)(54906003)(71200400001)(36756003)(6506007)(66476007)(66446008)(66946007)(110136005)(8676002)(81166006)(81156014)(478600001)(86362001)(2616005)(4326008)(2906002)(107886003)(1076003)(16526019)(186003)(85202003)(5660300002)(6512007)(52116002)(64756008)(66556008)(85182001)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3661; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8T5jRbU115IgsB8U5jreb5sAEuritn5gAhMbWZK4LQ/3ekr9Pc84Tga7fpR4NmMA1vxLUWURUix33fuyXDiqWaZYybLPZvqf0fIytpHRYFoobQWJVYLseKjWbu6e+8xisNh4lzYLByfYl1xZBhxSkwvtxTSSAxJu/xbhGMcLlbdUkxJ0c3bvrxDe09gJ/RsMTm8esjvFP+3cJDiPu5uEcRQBcTCPVwk3DRG6w8r6ST7e7T1DerNbNXl1hOH3K4QobSY2GuPWTS2Ep2a87S8qx78SludgCE1lwh1mmB2Ks4T8rJAmP0oAZx3kl6ZPis4hKNuv3kz1+Li3i14fWjOBLdsfjLZeMkjlzHLBVQ7a4T/RWMPv++T9QqSwL1G5SPx82cMSJfTadFno/W+It19JcRTP3gDRtfrkPYZAL6TRrw5FrM0nL9pIH5/2DQmquKBt Content-ID: <2BC2593D25EE0640A3B26980B322F012@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 360623ee-eb74-4eb3-74a9-08d799c27df8 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2020 13:54:51.4153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V+3Eb27hUyNJXaw4Qfq1FveKhse1JlUSIp4ELQd8CPdkSo2wl8Ew3H4yMYEqEHSNl5LpG3s2KS9wfRxwtjxzww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3661 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The field "default_filter" was not obvious. In add, explicitly declare that fields default_filter and enable are booleans. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_api_mib.h | 8 +++++--- drivers/staging/wfx/sta.c | 3 +-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wfx/hif_api_mib.h b/drivers/staging/wfx/hif_api_mib.h index e0ef0337e01c..0c67cd4c1593 100644 --- a/drivers/staging/wfx/hif_api_mib.h +++ b/drivers/staging/wfx/hif_api_mib.h @@ -206,9 +206,11 @@ struct hif_mib_config_data_filter { } __packed; struct hif_mib_set_data_filtering { - u8 default_filter; - u8 enable; - u8 reserved[2]; + u8 invert_matching:1; + u8 reserved1:7; + u8 enable:1; + u8 reserved2:7; + u8 reserved3[2]; } __packed; enum hif_arp_ns_frame_treatment { diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 1c1b5a6c2474..27248ea62aea 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -154,9 +154,8 @@ static int wfx_set_mcast_filter(struct wfx_vif *wvif, if (ret) return ret; - // discard all data frames except match filter filter_data.enable = 1; - filter_data.default_filter = 1; // discard all + filter_data.invert_matching = 1; // discard all but matching frames ret = hif_set_data_filtering(wvif, &filter_data); return ret;