From patchwork Mon Dec 28 16:28:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 352755 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp10027810ejs; Mon, 28 Dec 2020 08:27:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxyhxOGT6sCbtRPJfpsA31O9V7lW3pjF0yoltXRbjeqZczz5P4gqg/N0zqHMyooeTwk6UWe X-Received: by 2002:a6b:b2c3:: with SMTP id b186mr36211792iof.126.1609172863367; Mon, 28 Dec 2020 08:27:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609172863; cv=none; d=google.com; s=arc-20160816; b=sgDaTPFwEg7YRAljNHnTGqZeB8AOSl1n7t98oUDXVu1I35CDHtsrbzYCPhWQq/u8Tb emu6dox6QE/w8CkPiMK2xa+tBhqzVsmPX6r+UCg0pjkWXyrbpeBhdF3/VrAWhBG80XW6 LRarMiqXsnxF0vffdJTEt3geVMgcLbdPQjkeuU6d/FaFkrM22ZdFsEqz9AO7uCa0ZcVw QVjCCefM8ZmanDRZcH22BAXN3DjH6bkh1SiLs3J0wUUYcd1epzchg/o1t/4sha9uj7Go YQ1/lgBT/qIBqSDTR/U3UcBT08oohMlLszeBry86UvggrImStTyrqBZtsSKtO8tBZDHs QkBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=AGXfM5wi7v0b+MjLBorXl2LTIf243mAcDzS8Al6ARJw=; b=ZWnh0/dFgV0gK6ro59FUWxebKfEbgNRBoiCAx8S/Bpok3akDAIG2GfREFFDqnchF9J hiw5GZzYAO3NaN9w5SpBfPP9BiASYpQNNep6a1/F6i5gD8n2MZ4DurC/03kcj39HJoCZ S2CNXre2uAfy3c8QoqjNy5sNMm8VpOLKxL538HMydsbhR9ZPxwlVD07cfAcqJ2tPm0PP Zjf780SkO0cbD9MsmmEvNWo/QjsIWUo36iLBkLRbtH+QSgIzgEKBW58YN59sXrsXsZRR u+vfUuMJMSEXRsEMXcHQwKEwIFqZff5AqgHgfldNoMRm3kVjnv0Po2hDZ1GAweNx68N3 QJsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=pH33kQZz; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HlLRqSVj; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id u17si42539849iog.74.2020.12.28.08.27.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 08:27:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=pH33kQZz; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HlLRqSVj; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AGXfM5wi7v0b+MjLBorXl2LTIf243mAcDzS8Al6ARJw=; b=pH33kQZz5njjEksS6KDvxKuBY JFs6m4MZ+P3gYB/Xdv00tBcv/xbqavQvflyK8q9A156Ivy2wP8XC/0Eh9ZvVuDuY7uNgjSEwhrXw6 lyquy3n1QXJ56kcgoL5WU8MTgql0xEsdSdcm/U2UeIXuDMX8P310JgJfT55zYtlIw7xU4s7Bh0kNu Rp7mBf94bfPQCFbaaS2Hagvto9W9aBGsOeHY0lrZ45LUA1gjwCkdCSqWVv0Dd9PQx65CPrGLNLiDW ooeedTHE8VhzkP1Ju2La6XSN19smljX5ZsOfCm15iNOYNgeVIgPB9iNlauywi2wu35W1uf3qG04up NvR7nV20w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktvMw-0004XQ-89; Mon, 28 Dec 2020 16:27:38 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktvMt-0004V6-QR for wcn36xx@lists.infradead.org; Mon, 28 Dec 2020 16:27:36 +0000 Received: by mail-wr1-x429.google.com with SMTP id d13so11723478wrc.13 for ; Mon, 28 Dec 2020 08:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T3vbkvpnDfJt+kYGiWTgD3Sze4DdRUv6z46Vf171QE0=; b=HlLRqSVjKEqFUmImV6+YMe8wWB5FdGEKQ5bUlfpiH2xr/VO29pKZhEsb9GumPp18SQ vii9CEasaZOZxGUBMl5M2WnAuw5rIdIuAbiZvAv5ELfnqmLUqx/VSCTINRmdlmBTVVdU Qie9VcxQtU9Tsh+fr6Nljsef9QususTRx8qvdH04KuYbbu9KA+6ElJaP3WA0y3Owxa0s GBMCHIN5EbIxlP9eFgL5B2ilzCvVBIiovlS/Cl7f1ZUKDtarjXAaoRFtUau/3GkSFf08 TE664YOJoYis+6Robyvm2l+n9TB8VCMuXP4tFnDLeK53yvxqYPImxhcMzgZitf4WXHqd Yw6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T3vbkvpnDfJt+kYGiWTgD3Sze4DdRUv6z46Vf171QE0=; b=qpTFWlWN545+mNzVMieoArUEvL6xCUv6/61YCy6r2X7dRFn+SPGaFzR8iBiKUiVzPq njRNt4vBQe5g2/pI0P3k7fQqny3kAQ7w3JDU0pQ3h8yWin2jQ0ui51AgMzoupQvjjacE E1apqPUsftb4uDYNwljWov+UoOGDubOHhbXBHWtp4Ndus0O1aRmFD6o535t6VvXYbiBL pX8wEWmeb4q4/IYt+VsIDVFxGbiixy1OK6njBCXDYdh2P9l7rnE9Db/KTk00gcVMa2ac jgpi0PqCYd9DrQ3AWskDx/zzUCobLko0EI5q/P+OcAgMAAyvhD79MMdCSAzWaOB+BFme Y4CQ== X-Gm-Message-State: AOAM533fmjyRjk8jYBC6Q8Rr09aTDC2hJ8cuq0HuwudFinRqdDZYhw8X ItJqnd++HVvsWo2RBW5y9Wmz5A== X-Received: by 2002:adf:fd05:: with SMTP id e5mr52106185wrr.225.1609172854451; Mon, 28 Dec 2020 08:27:34 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id w21sm19523379wmi.45.2020.12.28.08.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 08:27:33 -0800 (PST) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH 04/13] wcn36xx: Do not flush indication queue on suspend/resume Date: Mon, 28 Dec 2020 16:28:30 +0000 Message-Id: <20201228162839.369156-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228162839.369156-1-bryan.odonoghue@linaro.org> References: <20201228162839.369156-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201228_112735_897310_20DBB876 X-CRM114-Status: GOOD ( 10.77 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:429 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org, benl@squareup.com Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org Testing on Android reveals that the flush on both suspend and resume of the firmware indication work-queue can stall indefinitely. Given this code path doesn't appear to have been exercised up until now, removing this flush to unblock this situation. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/main.c | 2 -- 1 file changed, 2 deletions(-) -- 2.29.2 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index c463ec7c1568..745512a6ad83 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1110,7 +1110,6 @@ static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow) wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n"); - flush_workqueue(wcn->hal_ind_wq); mutex_lock(&wcn->conf_mutex); vif = wcn36xx_get_first_vif(wcn); if (vif) { @@ -1135,7 +1134,6 @@ static int wcn36xx_resume(struct ieee80211_hw *hw) wcn36xx_dbg(WCN36XX_DBG_MAC, "mac resume\n"); - flush_workqueue(wcn->hal_ind_wq); mutex_lock(&wcn->conf_mutex); vif = wcn36xx_get_first_vif(wcn); if (vif) {