From patchwork Fri Mar 19 16:15:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 404811 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1511109jai; Fri, 19 Mar 2021 09:14:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+0/5lvzfnq2tdOXKuZQafMmXTlOW4dv5dDP88Sw+E0z6PKVWIKNLyXO4iLy1h8yz4cfcP X-Received: by 2002:a5d:4312:: with SMTP id h18mr5284780wrq.193.1616170444172; Fri, 19 Mar 2021 09:14:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616170444; cv=none; d=google.com; s=arc-20160816; b=usjEToyrCKvGwJ9ypsf2rq7TY8phOu5ng7DWbIkjxWimOaL4svIgMXHoru4gcuKK6z YLLQOBeHp1CNqsBQaqBWTjCQ7nEPEZxhn9p693nBq1ZhQL4rt8O2jODdR5hZVkmNNYgG ul/k809XRAFyDmpH2bKNxcLuWwDSwORHYdZX3JUuT5vTJYAmA+xor9Y+0UFzVBUOyWfA yBiMpOBNIVZ/ermT5qGlmzuhUB5nkVfAMiC6Fltm57TOSbsLBJpXG/Pp2BGbd9qLf0t4 pI0Q8D0+ftWdJmuLyippYbhxrmy9MEXDI5bqA/s3t9hiCWSNGoj+b5v02IIBBY9lSkXS Smmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=ONM5GkB5kPcy3a4NGrSsd/sk7+A5jPjRWQtEmYfbyNA=; b=wv2G1xuHoo9hFHc+1RzUjkBMZZhuAFkq3xSukriWyEb2E+/FJsrfBlUFT06Zq7JeCK KDiJT5f2Id7im8Ig/avLc87DyM6aTwL9yVgiVy1PBhBSjxnJCONR1D0/Q3UxloHxK+68 SPOyp9nEEytwBSKUZYr+SS3APG6C0WHOfBV+2exJbtZ6aZbgQBLxQ3FCpp7l0N7jRA8b rlSIhKCO0x+kmC17jmC4SFH1X7qcp+SCG+dWX5RC290Z3aoZBW9VpQK9M47miVijoO8d 26yyXNL1EHA2MWC0kFcQb/LY4lItlt41Oa7qoVrHWeAjC7zKA6ml01SMRJYHW96Niscz voxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=desiato.20200630 header.b="i/6UyIwF"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LSnkFoSV; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from desiato.infradead.org (desiato.infradead.org. [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by mx.google.com with ESMTPS id o34si5275886wmp.201.2021.03.19.09.14.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 09:14:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=desiato.20200630 header.b="i/6UyIwF"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LSnkFoSV; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ONM5GkB5kPcy3a4NGrSsd/sk7+A5jPjRWQtEmYfbyNA=; b=i/6UyIwFcKfyUJsRgmBY6O+1T 4JU+H95DOIZc/kUWq9fKKdwxLuLsbVgFTXKHFuPI4/q/LtXrPztvMaEffVxugsvO5Ff33sSkhJy+G VXTAuj2yjGCD5u/e4MSFcg6kJ3O2r4Wxhk1w2Pf28fJImjo0QEvE/qCaBKSUAFQdjYX0RvgokdZGM Qqt14StQTma7ufzQdja2ytlf1qJrC9nnZtzl5UTSm81X0OqEczfWjFr1eJEBqut0lXP7o39o9v0QT Nc8LW0T/ul+MRWY3gD8XbFge/zUr9ZMcqzF3K/YU3WCx0bbAbdR1Ov15IH5IuW1we7MQBY60fcemj Q/pWGHRgw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lNHlC-007fqt-IU; Fri, 19 Mar 2021 16:14:02 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lNHl6-007fnm-7y for wcn36xx@lists.infradead.org; Fri, 19 Mar 2021 16:13:58 +0000 Received: by mail-wr1-x434.google.com with SMTP id o16so9685572wrn.0 for ; Fri, 19 Mar 2021 09:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PK1ysPzp6vM3CYkwLCzyPDUUfmW5NdD9G7dghbyOwwQ=; b=LSnkFoSVtANfomNnx6mRhQic961DuP46T62YwfvYO0LHO6hp+6mOmR6MwM+7ZIxaO3 xRqB63p2KLjViOS2v4dl4ixH6pNsxKHk4QNvzpYuu7a5UNBwdYmWEe7YngT2v2GyG/56 9CG17xbss42HWIbzm8/DCUqT05sVSB98L4vrBzXR5Myl7JLECgfdeUhxNk0A35JVcb5c VPr8pMcpvoF9QKECpd0JtDmp+A0xKNI0cKp/HTeRWT1KyFqxZKLki6JA6khNBF0erC3R pqQT3yarx3eTiPARa8m70DL9Q1QEcLrm+jVstH7PEt6SoQL8yhDwaqrzpVtmc3/rWqIG plRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PK1ysPzp6vM3CYkwLCzyPDUUfmW5NdD9G7dghbyOwwQ=; b=kFMtbNod/ASi+qraSKwKKDV/zPy5m3lZ7Ycas6/9fqCvto7uotxPHIx7SSyRFmJ7v1 42yBRTnAoU9cNy7Il+STboef5X4HUAIP8EcRF1UUN+MKe330tWtpipomOSOPE7gXdMRb 7xNRyi9j7cDT/Cg8YGopJbSJHaZGTvr5oRrTxkae0zCIJVLF1x6dnWUhEsPa+u2A0UzQ E/0PGcNJN8dg89ncJWuABch55pf/tUK42cs2Kk0oAtMi1OcaWEu6AKpV62eqBURXTsd/ kjSBwHU77Vps9TrlhA7Md8Vug1GfFDiszKXmupaFdjv9o5J0qVja6WFML9M6xJKXJkEe xtfw== X-Gm-Message-State: AOAM533znNkMvFoK4WSJNfyDG/EKeNOe8QsBz3tu5TnZW3RWfKv39QS8 cQP+HI5MJhxcuGDj9oGeDmhbbg== X-Received: by 2002:a5d:4203:: with SMTP id n3mr5266334wrq.116.1616170435727; Fri, 19 Mar 2021 09:13:55 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id h8sm8432495wrt.94.2021.03.19.09.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 09:13:55 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org, bjorn.andersson@linaro.org Subject: [PATCH v3 04/12] wcn36xx: Do not flush indication queue on suspend/resume Date: Fri, 19 Mar 2021 16:15:12 +0000 Message-Id: <20210319161520.3590510-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210319161520.3590510-1-bryan.odonoghue@linaro.org> References: <20210319161520.3590510-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210319_161356_445320_4B8794A2 X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Testing on Android reveals that the flush on both suspend and resume of the firmware indication work-queue can stall indefinitely. Given this code path doesn't appear to have been exercised up until now, removing this flush to unblock this situation. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:434 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org Testing on Android reveals that the flush on both suspend and resume of the firmware indication work-queue can stall indefinitely. Given this code path doesn't appear to have been exercised up until now, removing this flush to unblock this situation. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/main.c | 2 -- 1 file changed, 2 deletions(-) -- 2.30.1 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index f95103706100..029c9952b4fb 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1110,7 +1110,6 @@ static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow) wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n"); - flush_workqueue(wcn->hal_ind_wq); mutex_lock(&wcn->conf_mutex); vif = wcn36xx_get_first_vif(wcn); if (vif) { @@ -1135,7 +1134,6 @@ static int wcn36xx_resume(struct ieee80211_hw *hw) wcn36xx_dbg(WCN36XX_DBG_MAC, "mac resume\n"); - flush_workqueue(wcn->hal_ind_wq); mutex_lock(&wcn->conf_mutex); vif = wcn36xx_get_first_vif(wcn); if (vif) {