From patchwork Tue Jun 1 02:49:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 451344 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp1331361jao; Mon, 31 May 2021 19:47:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+Joq04cMBx4lcwG8vEY1fNrSta96bBRcEJlGFwx5zN9BC55R4zC0neDUstoPWJXojYA82 X-Received: by 2002:a63:7e0a:: with SMTP id z10mr24971269pgc.12.1622515665044; Mon, 31 May 2021 19:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622515665; cv=none; d=google.com; s=arc-20160816; b=h3okyUf9/2CDXFWLE1m316uLXYSI1t26Y/KJ02Tm1QbGGnMhWSOCQ23eGGjusUpJ0n 5DtsYEf2SZ//Moj+PUbpD3EKCN2GZguMzb9sL1cA9m8iyfde1hi+4esVT1kCb9D7vEL/ ElELKOcwuquaBvk8S2LPohIec/wKCGoIW5LCjr6Mnp9ZvY/53PnFGKd98Xd4kafYkKxn 3a3dJ/fksB5gHyUFiG4IBNu6x82va3g5HZHD7jGSWSIh2yBMoyVgQbkfJSA/WhbZKkv1 6dOfMQSD/QJzh7H2IPOn5M1wJ6IMh/IwI1tP/u7gFYrIpuQi8kXZ5xOaB8XAE6s3CZ/B mROA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=0Gdkz/KEJhTM811+R87TrXaVHrhiO9JtPO+d5cM13yM=; b=G9e25hFR2VJ6YzlHZZBWgFx438ba+/iHtlGOfTbmYIQ7oBho+fSS+N+1vUF5z63JDr +3kfWgwGtg8ADWD2iNicdxGccCYS+1n2DE8LtGESUtJ1/65rTC4mg3UKfwUxT/Sop7E2 lHgVhOg5N5UWOdQ+UDHvYTlDtDIsASzoT97XXM+kNEIH1vgWQfe2TkRaXO+6N2UUaEpf oWjkygIOEnZhXQHa+K29s9rKf+vot22/ehSoBRgGeGS6RBpv/drlBS6ZecoMC6lTApf6 u+CpNr5xG+i1mkwRVnFWPzcDjS1ofTJnZezq2//3M4lgvamdBVyxhAZY5sy7ufKOZgwu +h5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=KrnqyBrf; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Lo4bik+T; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id j125si18104580pgc.368.2021.05.31.19.47.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 19:47:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=KrnqyBrf; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Lo4bik+T; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Gdkz/KEJhTM811+R87TrXaVHrhiO9JtPO+d5cM13yM=; b=KrnqyBrfRU1z+X fyIhibpYESkfRIsyjq7zujTdjInLMnJATXvQs6xj47cgMtC3KNTTLyRETwgEdBxaM5VGGdOmKn9j6 6gcYbp+IoZK5l09M96KQR3Bw9Yggv+bXSsb6d/iG+3YXX2tAK1lZcv9tB7L1FjRWNCTQwAHWbP+jz 6+03Y+DoNOzOsxhV8sbE2NkMjV0z5L/f5cQBUCDDSuc23gEuna4VNUcu+8w7ahaiGrwVMD4SDxMHh Ec7sAvEczQFFQzSVlrdxkErE3ohXVE4Oi/PTRoP89GWngLACakkDa+jTViPaIsQtZkz+4s7j7224Q 57C+rCdoyysmE/AlTIYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnuRS-00EJFj-If; Tue, 01 Jun 2021 02:47:42 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnuRP-00EJE0-KA for wcn36xx@lists.infradead.org; Tue, 01 Jun 2021 02:47:40 +0000 Received: by mail-wm1-x32f.google.com with SMTP id z137-20020a1c7e8f0000b02901774f2a7dc4so612608wmc.0 for ; Mon, 31 May 2021 19:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/kuNaO+3BN/9XKW0uTC+mnQ6gznoI5jFyk7Mscc9K1Y=; b=Lo4bik+TZIU7M/QWJWM5fLz+7AXZQdnBL5yFb4HyrbKXHXnK1j8SQPO6Ww6AFOyK5M SQz9EzE2DK0StDXBpy8EjrT+KR/WHy4LxvTkD+HTUP4NcltISAbw6mn/jRBjDyVkrf5U D5AqLZRtV+sPhTEi5FhYQTij1fnwsVagHf6d0yQd9dXzjrpWjuyG+POHeFAiiFerR4oG 7+KMYjjpmLOnMCztYQYN0m4VOnRN53WdQ03I1KnrEKKIl04ck+uBIm6uxVepm81dlP5K 5XleGfmZUBNMPPjoEGHI0SmUefj4k4h/tfLqI0cK0FGi2WqSNFtFsFreRgnIrGqyHH4u VjdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/kuNaO+3BN/9XKW0uTC+mnQ6gznoI5jFyk7Mscc9K1Y=; b=raNEZC4XMjbmscL9bUqPaKuSdGM23HChm2P1haibmSxicp5HyEu1cuJhljHZZfDqQG /afSuvhecD/Z2C6QcMzGWuRFnW1TJoY5jea0Fb4mDVaOJqVgP5WA1XXeOU69jysUImYj 7hjfPZg2dOc25W41rxRFbzYM0OeJ3WowPNVxRom1/H3QU+XMdzqLdEdhn2dga0o4oDic tyx0mEeKCROXLzA5ShJUaoI0RQV78ky8HOXF9vHT0I3TLdM9BFBb6bknh5UDC6iQxdd1 cG2WVYuvfZr2ZuGUuQIP9Sdstp9mSLshFqIY1L6S0MEiSWJi3jhrUsDzXNeqAj0V1EFR cOeQ== X-Gm-Message-State: AOAM53077Yh/BeQIxIOEmIEOqiSQ5RzRnE8q0IWzvtvuWVnw7HhXYvpJ Ytx1EcpkdY8JEsvDkZAkLoRK3A== X-Received: by 2002:a05:600c:2301:: with SMTP id 1mr1823494wmo.180.1622515658225; Mon, 31 May 2021 19:47:38 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id e22sm16774014wme.48.2021.05.31.19.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 19:47:37 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org, bjorn.andersson@linaro.org Subject: [PATCH v4 01/12] wcn36xx: Return result of set_power_params in suspend Date: Tue, 1 Jun 2021 03:49:09 +0100 Message-Id: <20210601024920.1424144-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210601024920.1424144-1-bryan.odonoghue@linaro.org> References: <20210601024920.1424144-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210531_194739_698976_13573694 X-CRM114-Status: GOOD ( 12.18 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: wcn36xx_smd_set_power_params() can return an error. For the purposes of entering into suspend we need the suspend() function to trap and report errors up the stack. First step in this process is reporting the existing result code for wcn36xx_smd_set_power_params(). Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:32f listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org wcn36xx_smd_set_power_params() can return an error. For the purposes of entering into suspend we need the suspend() function to trap and report errors up the stack. First step in this process is reporting the existing result code for wcn36xx_smd_set_power_params(). Signed-off-by: Bryan O'Donoghue Tested-by: Benjamin Li --- drivers/net/wireless/ath/wcn36xx/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.30.1 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index afb4877eaad8..b361e40697a6 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1091,12 +1091,14 @@ static int wcn36xx_sta_remove(struct ieee80211_hw *hw, static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow) { struct wcn36xx *wcn = hw->priv; + int ret; wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n"); flush_workqueue(wcn->hal_ind_wq); - wcn36xx_smd_set_power_params(wcn, true); - return 0; + ret = wcn36xx_smd_set_power_params(wcn, true); + + return ret; } static int wcn36xx_resume(struct ieee80211_hw *hw)