| Message ID | 20231002151023.4054-2-ansuelsmth@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net-next,1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule | expand |
On 10/2/2023 8:10 AM, Christian Marangi wrote: > Change napi_schedule to return a bool on NAPI successful schedule. This > might be useful for some driver to do additional step after a NAPI ahs nit:s/ahs/has/ > been scheduled. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > include/linux/netdevice.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 7e520c14eb8c..2bead8e2a14d 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -490,11 +490,18 @@ bool napi_schedule_prep(struct napi_struct *n); > * > * Schedule NAPI poll routine to be called if it is not already > * running. > + * Return true if we schedule a NAPI or false if not. > + * Refer to napi_schedule_prep() for additional reason on why > + * a NAPI might not be scheduled. > */ > -static inline void napi_schedule(struct napi_struct *n) > +static inline bool napi_schedule(struct napi_struct *n) > { > - if (napi_schedule_prep(n)) > + if (napi_schedule_prep(n)) { > __napi_schedule(n); > + return true; > + } > + > + return false; > } > > /**
On Mon, Oct 2, 2023 at 5:10 PM Christian Marangi <ansuelsmth@gmail.com> wrote: > > Change napi_schedule to return a bool on NAPI successful schedule. This > might be useful for some driver to do additional step after a NAPI ahs This might be useful for some drivers to do additional steps after a NAPI has been scheduled. > been scheduled. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Yeah, I guess you forgot to mention I suggested this patch ... Reviewed-by: Eric Dumazet <edumazet@google.com>
On Tue, Oct 03, 2023 at 07:21:46AM +0200, Eric Dumazet wrote: > On Mon, Oct 2, 2023 at 5:10 PM Christian Marangi <ansuelsmth@gmail.com> wrote: > > > > Change napi_schedule to return a bool on NAPI successful schedule. This > > might be useful for some driver to do additional step after a NAPI ahs > > This might be useful for some drivers to do additional steps after a > NAPI has been scheduled. > > > been scheduled. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > Yeah, I guess you forgot to mention I suggested this patch ... > > Reviewed-by: Eric Dumazet <edumazet@google.com> Yes sorry, totally forgot to add this here. I already have the patch for the other driver (but it's dependant on this so I'm waiting) and I forgot to add the tag also for this piece.
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 7e520c14eb8c..2bead8e2a14d 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -490,11 +490,18 @@ bool napi_schedule_prep(struct napi_struct *n); * * Schedule NAPI poll routine to be called if it is not already * running. + * Return true if we schedule a NAPI or false if not. + * Refer to napi_schedule_prep() for additional reason on why + * a NAPI might not be scheduled. */ -static inline void napi_schedule(struct napi_struct *n) +static inline bool napi_schedule(struct napi_struct *n) { - if (napi_schedule_prep(n)) + if (napi_schedule_prep(n)) { __napi_schedule(n); + return true; + } + + return false; } /**
Change napi_schedule to return a bool on NAPI successful schedule. This might be useful for some driver to do additional step after a NAPI ahs been scheduled. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- include/linux/netdevice.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)