From patchwork Sat Dec 30 04:51:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Rameshbabu X-Patchwork-Id: 759209 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E918417FD for ; Sat, 30 Dec 2023 04:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="HWYX2cNv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1703911897; x=1704171097; bh=xoCJFTO9+CWfEwOaRvKJoarW9UkFuNSaR1ANZeDoB50=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=HWYX2cNva/4uVA/Sq3t67Mr+1ucZcbP1jyUFutujNFLmLDrIwJT2Eva2facQaKkO8 Zt/wwOIBDBRl2YnGlzxsVw5doNVsiVtze8UMLovD9CmuWpZaOdma+rlOIj1sRsJAew IA3pppPW+KkFKr8KWpRVozgPABgmA3dvFurr0j0k5yo71MRSwyDkMKmxBzyYw/q1MX 6CJj7A7GwXKZQRYLOt2m2PcMclY3/2pXtWoSwUe39qvqjakGpzoV59D+NBTAg1EVRY OaoSD0BjGhPEvy/ksAa/blRxfUD/8qkgKmtH7t6sHNy4V8wyDEEo46rG+1XGr7zxkZ UH9QT5TREXPkg== Date: Sat, 30 Dec 2023 04:51:29 +0000 To: Kalle Valo From: Rahul Rameshbabu Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org, Rahul Rameshbabu Subject: [PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional Message-ID: <20231230045105.91351-2-sergeantsagara@protonmail.com> In-Reply-To: <20231230045105.91351-1-sergeantsagara@protonmail.com> References: <20231230045105.91351-1-sergeantsagara@protonmail.com> Feedback-ID: 26003777:user:proton Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Trigger the warning message should be when the OpenFW capability for QoS does not advertise QoS support. Previously, the warning would be incorrectly triggered when OpenFW reported QoS capability is present. Fixes: 097b0e1bf18a ("b43: fix crash with OpenFWWF") Signed-off-by: Rahul Rameshbabu --- drivers/net/wireless/broadcom/b43/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c index 92ca0b2ca286..c81117a22ebf 100644 --- a/drivers/net/wireless/broadcom/b43/main.c +++ b/drivers/net/wireless/broadcom/b43/main.c @@ -2713,7 +2713,7 @@ static int b43_upload_microcode(struct b43_wldev *dev) dev->hwcrypto_enabled = false; } /* adding QoS support should use an offline discovery mechanism */ - WARN(fwcapa & B43_FWCAPA_QOS, "QoS in OpenFW not supported\n"); + WARN(!(fwcapa & B43_FWCAPA_QOS), "QoS in OpenFW not supported\n"); } else { b43info(dev->wl, "Loading firmware version %u.%u " "(20%.2i-%.2i-%.2i %.2i:%.2i:%.2i)\n",