[4/8] wifi: rtw89: disable RTS when broadcast/multicast

Message ID	20240119081501.25223-5-pkshih@realtek.com
State	New
Headers	show Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB63028E10 for <linux-wireless@vger.kernel.org>; Fri, 19 Jan 2024 08:15:47 +0000 (UTC) code: ctloc85258 From: Ping-Ke Shih <pkshih@realtek.com> To: <kvalo@kernel.org> CC: <gary.chang@realtek.com>, <phhuang@realtek.com>, <linux-wireless@vger.kernel.org> Subject: [PATCH 4/8] wifi: rtw89: disable RTS when broadcast/multicast Date: Fri, 19 Jan 2024 16:14:57 +0800 Message-ID: <20240119081501.25223-5-pkshih@realtek.com> In-Reply-To: <20240119081501.25223-1-pkshih@realtek.com> References: <20240119081501.25223-1-pkshih@realtek.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain
Series	wifi: rtw89: refine hardware scan and concurrent \| expand [0/8] wifi: rtw89: refine hardware scan and concurrent [1/8] wifi: rtw89: refine add_chan H2C command to encode_bits [2/8] wifi: rtw89: refine hardware scan C2H events [3/8] wifi: rtw89: Set default CQM config if not present [4/8] wifi: rtw89: disable RTS when broadcast/multicast [5/8] wifi: rtw89: fix null pointer access when abort scan [6/8] wifi: rtw89: add wait/completion for abort scan [7/8] wifi: rtw89: fix HW scan timeout due to TSF sync issue [8/8] wifi: rtw89: fix disabling concurrent mode TX hang issue

Message ID

20240119081501.25223-5-pkshih@realtek.com

State

New

Headers

From: Ping-Ke Shih <pkshih@realtek.com>
To: <kvalo@kernel.org>
CC: <gary.chang@realtek.com>, <phhuang@realtek.com>,
        <linux-wireless@vger.kernel.org>
Subject: [PATCH 4/8] wifi: rtw89: disable RTS when broadcast/multicast
Date: Fri, 19 Jan 2024 16:14:57 +0800
Message-ID: <20240119081501.25223-5-pkshih@realtek.com>
In-Reply-To: <20240119081501.25223-1-pkshih@realtek.com>
References: <20240119081501.25223-1-pkshih@realtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Series

wifi: rtw89: refine hardware scan and concurrent | expand

Commit Message

Ping-Ke Shih Jan. 19, 2024, 8:14 a.m. UTC

From: Po-Hao Huang <phhuang@realtek.com>

RTS switch should not be enabled for broadcast and multicast. This
could cause incorrect behavior during AP mode, so we fix it.

Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index dfca642a7570..6e52c4f82011 100644
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -1176,7 +1176,8 @@  static __le32 rtw89_build_txwd_info2_v1(struct rtw89_tx_desc_info *desc_info)
 
 static __le32 rtw89_build_txwd_info4(struct rtw89_tx_desc_info *desc_info)
 {
-	u32 dword = FIELD_PREP(RTW89_TXWD_INFO4_RTS_EN, 1) |
+	bool rts_en = !desc_info->is_bmc;
+	u32 dword = FIELD_PREP(RTW89_TXWD_INFO4_RTS_EN, rts_en) |
 		    FIELD_PREP(RTW89_TXWD_INFO4_HW_RTS_EN, 1);
 
 	return cpu_to_le32(dword);
@@ -1329,7 +1330,8 @@  static __le32 rtw89_build_txwd_info2_v2(struct rtw89_tx_desc_info *desc_info)
 
 static __le32 rtw89_build_txwd_info4_v2(struct rtw89_tx_desc_info *desc_info)
 {
-	u32 dword = FIELD_PREP(BE_TXD_INFO4_RTS_EN, 1) |
+	bool rts_en = !desc_info->is_bmc;
+	u32 dword = FIELD_PREP(BE_TXD_INFO4_RTS_EN, rts_en) |
 		    FIELD_PREP(BE_TXD_INFO4_HW_RTS_EN, 1);
 
 	return cpu_to_le32(dword);

[4/8] wifi: rtw89: disable RTS when broadcast/multicast

Commit Message

Patch