mbox series

[0/7] USB changes for rare warnings

Message ID 1453997722-3489596-1-git-send-email-arnd@arndb.de
Headers show
Series USB changes for rare warnings | expand

Message

Arnd Bergmann Jan. 28, 2016, 4:15 p.m. UTC 
Hi Felipe,

This set of patches addresses warnings I got in randconfig builds,
in the USB drivers. The first three patches are for the pxa25x
UDC driver and are a larger scale cleanup triggered by finding
the initial bug. The other four are relatively simple but still
need to be reviewed properly, as I have done only compile-time
testing. After these patches, I get no other warnings for USB
drivers at the moment.

Arnd Bergmann (7):
  usb: gadget: pxa25x_udc: move register definitions from arch
  usb: gadget: pxa25x_udc cleanup
  usb: gadget: pxa25x_udc: use readl/writel for mmio
  usb: fsl: drop USB_FSL_MPH_DR_OF Kconfig symbol
  usb: isp1301-omap: mark power_up as __maybe_unused
  usb: musb: use %pad format string from dma_addr_t
  usb: musb/ux500: remove duplicate check for dma_is_compatible

 arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h | 198 ---------
 arch/arm/mach-pxa/include/mach/pxa25x-udc.h     | 163 --------
 drivers/usb/Makefile                            |   2 +-
 drivers/usb/gadget/udc/Kconfig                  |   1 -
 drivers/usb/gadget/udc/pxa25x_udc.c             | 530 +++++++++++++++++-------
 drivers/usb/gadget/udc/pxa25x_udc.h             |  11 +-
 drivers/usb/host/Kconfig                        |   4 -
 drivers/usb/host/Makefile                       |   3 +-
 drivers/usb/musb/musbhsdma.c                    |   8 +-
 drivers/usb/musb/tusb6010_omap.c                |   4 +-
 drivers/usb/musb/ux500_dma.c                    |   3 -
 drivers/usb/phy/phy-isp1301-omap.c              |   2 +-
 12 files changed, 400 insertions(+), 529 deletions(-)

-- 
2.7.0

Comments

Robert Jarzmik Feb. 3, 2016, 7:15 p.m. UTC | #1 
Felipe Balbi <balbi@kernel.org> writes:

> Hi Arnd,

>

>>  arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h | 198 ---------

>>  arch/arm/mach-pxa/include/mach/pxa25x-udc.h     | 163 --------

>

> for arch/arm I need Acked-by from relevant folks.

You already have mine for arch/arm/mach-pxa/include/mach/pxa25x-udc.h I think,
or did my mailer betray me again ...

I cannot speak for ixp4xx though.

Cheers.

-- 
Robert
Arnd Bergmann Feb. 3, 2016, 8:49 p.m. UTC | #2 
On Wednesday 03 February 2016 20:15:47 Robert Jarzmik wrote:
> Felipe Balbi <balbi@kernel.org> writes:

> 

> > Hi Arnd,

> >

> >>  arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h | 198 ---------

> >>  arch/arm/mach-pxa/include/mach/pxa25x-udc.h     | 163 --------

> >

> > for arch/arm I need Acked-by from relevant folks.

> You already have mine for arch/arm/mach-pxa/include/mach/pxa25x-udc.h I think,

> or did my mailer betray me again ...


I saw it.

> I cannot speak for ixp4xx though.


Krzysztof Halasa <khalasa@piap.pl> gave an Ack for the first patch already,
and I think we concluded that the patch was keeping the current behavior
otherwise and is therefore not a regression, though we did not finish
the side-discussion about whether ixp4xx actually works in both BE and LE
mode with both indirect and direct I/O, or which of the four combinations
is broken.

> > Also, do you think we need this during the -rc or can we consider it

> > non-critical fixes for v4.6 merge window ?


I meant it for 4.6, sorry for not being very clear about that.
All the warnings I fixed in this series are harmless as far as I
can tell, and they only show up in rare randconfig builds.

	Arnd