From patchwork Mon Aug 14 15:44:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ding Tianhong X-Patchwork-Id: 110052 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp4505162qge; Mon, 14 Aug 2017 08:47:23 -0700 (PDT) X-Received: by 10.84.195.131 with SMTP id j3mr27627631pld.147.1502725643307; Mon, 14 Aug 2017 08:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502725643; cv=none; d=google.com; s=arc-20160816; b=VQ4ZXJIziF72OsGORhHc/Eda/D95i/Hv7eN2f06jeIwB6p1URpNyiCXLcVwm10lwlm kfK4Md6hZ+KRZv+16atZhdZAEMzqhaUWIWW9G/dtdqxqDHQMz9qD+AZnRQLk60pa1VnK sPN+Kr1C6PILVCdrnnTB6koHWmfWuJf5Ur5ulLHPTWIl1tEoktuyYMHL16gf1bCxJcw0 ViXVZO+ZJ93R1d0VGLiQknxc3x4d6jOTdCIYFQyjHJfiFnEXkF4xnnLTfA2bCxUJnbnQ eUBhIwNb4Jltreh2+uBqpGbqwbmD5My/cnzJLpw5tk5aHMS75WhFU6uU8dRAEYvYushK n3RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=ZwoEYnKoiyGW9YKmSbFxP2X+KANxcs8pmfkoGbb1abE=; b=RN7l3NQ3yP30JmbLSFwrHL0koqeU3TTK/EAxjesHZ40IjvVkWrChFy0fvO5Y7ZjSHz 7pEBUk+foms5PrNQ8Rqzndss2EibFUQqPP10dStf2zVwBTTvDFd/tr2L23jcBQRMEkcd NuDrjw0Z8TeR+fnncVgxxNt+yJCvz4gu6ST0p0BKmi9Lnf+p+9CFetQPQ7B+5ATkRVjU DhtDkQ4gucTdBC7BLhHSks2SqJD4S97BYvHlfyR+kT53ez5Aq0Qu0t0Kz2DarSWrbLBy KBwBn7oxRzmN+d5pdlRSuflxudJnG+H8cO/kk+vVn/6k11/ywJNRNtFqZX6x+xJDg8cp aiuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p30si4874737pli.346.2017.08.14.08.47.22; Mon, 14 Aug 2017 08:47:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753171AbdHNPrU (ORCPT + 25 others); Mon, 14 Aug 2017 11:47:20 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3518 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbdHNPpd (ORCPT ); Mon, 14 Aug 2017 11:45:33 -0400 Received: from 172.30.72.60 (EHLO DGGEMS414-HUB.china.huawei.com) ([172.30.72.60]) by dggrg04-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id DFD56647; Mon, 14 Aug 2017 23:45:14 +0800 (CST) Received: from localhost (10.177.23.32) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.301.0; Mon, 14 Aug 2017 23:45:02 +0800 From: Ding Tianhong To: , , , , , , , , , , , , , , , , , , , , , , , , , CC: Ding Tianhong Subject: [PATCH v10 0/5] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag Date: Mon, 14 Aug 2017 23:44:54 +0800 Message-ID: <1502725499-11276-1-git-send-email-dingtianhong@huawei.com> X-Mailer: git-send-email 1.8.5.2.msysgit.0 MIME-Version: 1.0 X-Originating-IP: [10.177.23.32] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.5991C58B.0067, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b855133c55781e9d492d35a5c29f94a4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some devices have problems with Transaction Layer Packets with the Relaxed Ordering Attribute set. This patch set adds a new PCIe Device Flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch some known devices with Relaxed Ordering issues, and a use of this new flag by the cxgb4 driver to avoid using Relaxed Ordering with problematic Root Complex Ports. It's been years since I've submitted kernel.org patches, I appolgise for the almost certain submission errors. v2: Alexander point out that the v1 was only a part of the whole solution, some platform which has some issues could use the new flag to indicate that it is not safe to enable relaxed ordering attribute, then we need to clear the relaxed ordering enable bits in the PCI configuration when initializing the device. So add a new second patch to modify the PCI initialization code to clear the relaxed ordering enable bit in the event that the root complex doesn't want relaxed ordering enabled. The third patch was base on the v1's second patch and only be changed to query the relaxed ordering enable bit in the PCI configuration space to allow the Chelsio NIC to send TLPs with the relaxed ordering attributes set. This version didn't plan to drop the defines for Intel Drivers to use the new checking way to enable relaxed ordering because it is not the hardest part of the moment, we could fix it in next patchset when this patches reach the goal. v3: Redesigned the logic for pci_configure_relaxed_ordering when configuration, If a PCIe device didn't enable the relaxed ordering attribute default, we should not do anything in the PCIe configuration, otherwise we should check if any of the devices above us do not support relaxed ordering by the PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag, then base on the result if we get a return that indicate that the relaxed ordering is not supported we should update our device to disable relaxed ordering in configuration space. If the device above us doesn't exist or isn't the PCIe device, we shouldn't do anything and skip updating relaxed ordering because we are probably running in a guest. v4: Rename the functions pcie_get_relaxed_ordering and pcie_disable_relaxed_ordering according John's suggestion, and modify the description, use the true/false as the return value. We shouldn't enable relaxed ordering attribute by the setting in the root complex configuration space for PCIe device, so fix it for cxgb4. Fix some format issues. v5: Removed the unnecessary code for some function which only return the bool value, and add the check for VF device. Make this patch set base on 4.12-rc5. v6: Fix the logic error in the need to enable the relaxed ordering attribute for cxgb4. v7: The cxgb4 drivers will enable the PCIe Capability Device Control[Relaxed Ordering Enable] in PCI Probe() routine, this will break our current solution for some platform which has problematic when enable the relaxed ordering attribute. According to the latest recommendations, remove the enable_pcie_relaxed_ordering(), although it could not cover the Peer-to-Peer scene, but we agree to leave this problem until we really trigger it. Make this patch set base on 4.12 release version. v8: Change the second patch title and description to make it more reasonable, add the acked-by from Alex and Ashok. Add a new patch to enable the Relaxed Ordering Attribute for cxgb4vf driver. Make this patch set base on 4.13-rc2. v9: The document (https://software.intel.com/sites/default/files/managed/9e/ bc/64-ia-32-architectures-optimization-manual.pdf) indicate that the Xeon processors based on Broadwell/Haswell microarchitecture has the problem with Relaxed Ordering Attribute enabled, so add the whole list Device ID from Intel to the patch. v10: Significant rework based on Bjorn's feedback, reorganize the first 2 patches, now the Intel and AMD erratum soc has been divided to the different patches, rename the pcie_relaxed_ordering_supported() to pcie_relaxed_ordering_enabled(), and no need to check every intervening switch except the root ports, update some commits. Casey Leedom (2): net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag net/cxgb4vf: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag Ding Tianhong (3): PCI: Disable PCIe Relaxed Ordering if unsupported PCI: Disable Relaxed Ordering for some Intel processors PCI: Disable Relaxed Ordering Attributes for AMD A1100 drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 23 ++++-- drivers/net/ethernet/chelsio/cxgb4/sge.c | 5 +- drivers/net/ethernet/chelsio/cxgb4vf/adapter.h | 1 + .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 18 +++++ drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 3 + drivers/pci/probe.c | 43 +++++++++++ drivers/pci/quirks.c | 89 ++++++++++++++++++++++ include/linux/pci.h | 3 + 9 files changed, 178 insertions(+), 8 deletions(-) -- 1.8.3.1