mbox series

[0/7] MIPS: boot: fix various problems in arch/mips/boot/Makefile

Message ID 1523890067-13641-1-git-send-email-yamada.masahiro@socionext.com
Headers show
Series MIPS: boot: fix various problems in arch/mips/boot/Makefile | expand

Message

Masahiro Yamada April 16, 2018, 2:47 p.m. UTC
When I was trying to fix commit 0f9da844d877 in a more correct way,
I found various problems in arch/mips/boot/Makefile.

ITS is always rebuilt when you rebuild the kernel without touching
anything.  Many build rules are wrong.

If you look at the last patch in this series, you may realize
supporting ITB building in the kernel can cause nasty problems.
Personally, I do not like it, but I tried my best to fix the problems.

With this series, ITB is rebuilt only when necessary.



Masahiro Yamada (7):
  Revert "MIPS: boot: Define __ASSEMBLY__ for its.S build"
  MIPS: boot: do not include $(cpp_flags) for preprocessing ITS
  MIPS: boot: fix build rule of vmlinux.its.S
  MIPS: boot: correct prerequisite image of vmlinux.*.its
  MIPS: boot: add missing targets for vmlinux.*.its
  MIPS: boot: merge build rules of vmlinux.*.itb by using pattern rule
  MIPS: boot: rebuild ITB when contained DTB is updated

 arch/mips/boot/Makefile | 69 ++++++++++++++++++++++++++-----------------------
 1 file changed, 37 insertions(+), 32 deletions(-)

-- 
2.7.4

Comments

Masahiro Yamada June 3, 2018, 2:59 a.m. UTC | #1
Hi MIPS maintainers,

2018-04-16 23:47 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>

> When I was trying to fix commit 0f9da844d877 in a more correct way,

> I found various problems in arch/mips/boot/Makefile.

>

> ITS is always rebuilt when you rebuild the kernel without touching

> anything.  Many build rules are wrong.

>

> If you look at the last patch in this series, you may realize

> supporting ITB building in the kernel can cause nasty problems.

> Personally, I do not like it, but I tried my best to fix the problems.

>

> With this series, ITB is rebuilt only when necessary.

>


Is any part of this series applicable?
At least, patch 1-4 look simple to me.


Patch 5-7 should be applied together.
The last one is a bit tricky, so you can ignore 5-7 if you do not like them.
(Only the problem is, ITB files are always rebuilt even if nothing is changed.)

>

> Masahiro Yamada (7):

>   Revert "MIPS: boot: Define __ASSEMBLY__ for its.S build"

>   MIPS: boot: do not include $(cpp_flags) for preprocessing ITS

>   MIPS: boot: fix build rule of vmlinux.its.S

>   MIPS: boot: correct prerequisite image of vmlinux.*.its

>   MIPS: boot: add missing targets for vmlinux.*.its

>   MIPS: boot: merge build rules of vmlinux.*.itb by using pattern rule

>   MIPS: boot: rebuild ITB when contained DTB is updated

>

>  arch/mips/boot/Makefile | 69 ++++++++++++++++++++++++++-----------------------

>  1 file changed, 37 insertions(+), 32 deletions(-)

>

> --

> 2.7.4

>




-- 
Best Regards
Masahiro Yamada