| Message ID | 1525850632-10921-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| Headers | show |
| Series | kbuild: remove CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX and clean-up code | expand |
Hi Masahiro. On Wed, May 09, 2018 at 04:23:44PM +0900, Masahiro Yamada wrote: > > I got acknowledge to remove CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX entirely. > (https://lkml.org/lkml/2018/5/5/148) > > Several tools can be cleaned-up. > > Removing the CONFIG option makes VMLINUX_SYMBOL() no-op, > so this macro can be removed too. Looks good. You can add my: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> for all patches. One minor comment to one patch that I let you decide what to do about. The code readability increases everywhere. > > VMLINUX_SYMBOL() and VMLINUX_SYMBOL_STR() are widely used, > so it will take some time to kill them entirely. > (I will send other patches later, splitting per-arch) There are a few files outside arch/ like certs/system_certificates.S drivers/mtd/chips/gen_probe.c kernel/module.c They could belong in this none-arch series. Sam
2018-05-09 16:23 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > > I got acknowledge to remove CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX entirely. > (https://lkml.org/lkml/2018/5/5/148) > > Several tools can be cleaned-up. > > Removing the CONFIG option makes VMLINUX_SYMBOL() no-op, > so this macro can be removed too. > > VMLINUX_SYMBOL() and VMLINUX_SYMBOL_STR() are widely used, > so it will take some time to kill them entirely. > (I will send other patches later, splitting per-arch) > > > > Masahiro Yamada (8): > modpost: remove symbol prefix support > genksyms: remove symbol prefix support > kallsyms: remove symbol prefix support > depmod.sh: remove symbol prefix support > export.h: remove code for prefixing symbols with underscore > kbuild: remove CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX > vmlinux.lds.h: remove no-op macro VMLINUX_SYMBOL() > checkpatch: remove VMLINUX_SYMBOL() check Applied to linux-kbuild. > Makefile | 2 +- > arch/Kconfig | 6 - > include/asm-generic/export.h | 34 ++--- > include/asm-generic/vmlinux.lds.h | 289 +++++++++++++++++++------------------- > include/linux/export.h | 16 +-- > scripts/Makefile.build | 9 +- > scripts/adjust_autoksyms.sh | 3 - > scripts/checkpatch.pl | 10 -- > scripts/depmod.sh | 21 +-- > scripts/genksyms/genksyms.c | 11 +- > scripts/kallsyms.c | 47 ++----- > scripts/link-vmlinux.sh | 4 - > scripts/mod/modpost.c | 30 ++-- > 13 files changed, 188 insertions(+), 294 deletions(-) > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada