From patchwork Thu Jun 29 07:24:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fathi Boudra X-Patchwork-Id: 106609 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp780085qge; Thu, 29 Jun 2017 00:25:14 -0700 (PDT) X-Received: by 10.98.66.147 with SMTP id h19mr15194787pfd.178.1498721113955; Thu, 29 Jun 2017 00:25:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498721113; cv=none; d=google.com; s=arc-20160816; b=ZPm7vi72ofdOUGc5VFDkdR0fHpt2/En1qgy9lsrBh26BU+fIEVmuOG3KAMH6VgKw5h jxqRUhwHmpJCrquMqU0dvDyfJjxrKEVdVxyVkv50U5L9Q35DC1me/v1sIIXpnLrsqzwv Mb7ozbWRbnlT6RNuN3Fj3QLJUMgqJmUSnWO0gHh6TKn57I2GX0Do6PfN3JhFSr+c6qbe n4nyPzBBDQNr//g90ovt143CGJhFFkl1yA0NJH2T07gRZH7Dkh2fJVCoIQs8DGeuIkM/ 0Mu1z7uoIn/49rmQXGdJ0x8lX8U1bspmQAGjomv+cqSUE7cWv55dt05OlpgBbjzjYuzZ XuCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=bTx+VBvK2gNN2MuGEE3fsbDqTzWeTztQGFhyY20o+HM=; b=vgcQYlAS3lKG90wdsc6LnasJLA4nGyfAAzBlXHgeaLPZCPpaFjM+n6zJsHwYfuNlwk tvrZB2P9+dqi6Tz9w6tdeAwkaAQvfwBYiQDkr7NyIJE2XzqPm82CTT+iL4RJnxFEQBJD M/fySmXwGJI4kaMhP6AvECXLpzudjfAJBnJso2nwdfWbmx/x2SSmMxqO4TVSkkza/0Rl RWW+sKVqYZ1sV4mV8K0/ENgCqZvaD6mQnNGde5tqtE56t/nHl5QjEHsV5Ck9ReF1MNkh PqZ4ggkwI1CpLQSG8wYXr8KMlal8A/e+j3p4Kp9kh9NQHmoenj8RyfvM13EvhNgBXN4B Cz4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=hHqZBktn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5si3130239pfb.416.2017.06.29.00.25.13; Thu, 29 Jun 2017 00:25:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=hHqZBktn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbdF2HZL (ORCPT + 25 others); Thu, 29 Jun 2017 03:25:11 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33453 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbdF2HZC (ORCPT ); Thu, 29 Jun 2017 03:25:02 -0400 Received: by mail-lf0-f41.google.com with SMTP id z78so5866921lff.0 for ; Thu, 29 Jun 2017 00:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bTx+VBvK2gNN2MuGEE3fsbDqTzWeTztQGFhyY20o+HM=; b=hHqZBktnXliuIGR/Pg2HCRjqHt4/OR7TeJkgfPHG1KE+7zxlnbsURgTGxIbeKlOSyg BcQpHGZW1SAE3hn96Y1u4IScVxIrjyg0TjUDXNaoZDZA6tWWjLxdht+sp6icV1itsEK/ SXfhs0Unvy/uEg7jNT96pvvPhpNfrelQZ9WMI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bTx+VBvK2gNN2MuGEE3fsbDqTzWeTztQGFhyY20o+HM=; b=fhOnkQwTL1dNhWeM35w6yL/BO0pBhpypyrYLhMsE6slCHcHxAxV5BDXLh+CmJITIyk yCD3CepkXA9o1kKoLrKgm0aKbfS6DrXP/i0Ldiez7JM0biLPmc0+Mm3zyZfz2f+SkbIl AnsGXEC6xEUdK33UNB3huKwk8OyTg5HlSmnD2R6qbiRYpy4mfYgXF/z2FaV0gSPNVHNM FjuKXiclfK5BsIfAd7G96Nz+Sg/C3/6iLtIMV7MIScvNjaGLmUC0+kOiriLuAWOFqVY9 aA5sS/abaVAXj8Jq2c/rzgH9tio/Rh2amp/wC+AutjECuRtWFaFubDuPbQYyy0yrD5l5 KTfw== X-Gm-Message-State: AKS2vOzCd9q80cejD0gGX6vuuNggoKvEQLqu1VWTAOzDjSNbEUcXPbaG PlALdSCpyjHtmQQR X-Received: by 10.46.20.16 with SMTP id u16mr2132758ljd.54.1498721100669; Thu, 29 Jun 2017 00:25:00 -0700 (PDT) Received: from localhost.localdomain (a91-156-68-101.elisa-laajakaista.fi. [91.156.68.101]) by smtp.gmail.com with ESMTPSA id m27sm1082006lfi.50.2017.06.29.00.24.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Jun 2017 00:24:59 -0700 (PDT) From: Fathi Boudra To: linux-kselftest@vger.kernel.org, Shuah Khan Cc: linux-kernel@vger.kernel.org, John Stultz , Denys Dmytriyenko , SeongJae Park , Fathi Boudra Subject: [PATCH v2 0/3] selftests: fixes for undefined reference (LDFLAGS -> LDLIBS) Date: Thu, 29 Jun 2017 10:24:56 +0300 Message-Id: <20170629072459.30741-1-fathi.boudra@linaro.org> X-Mailer: git-send-email 2.13.0 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This serie fixes undefined reference errors caused by the usage of LDFLAGS instead of LDLIBS. The issue is GNU Make and linker specific. The default Makefile rule looks like: $(CC) $(CFLAGS) $(LDFLAGS) $@ $^ $(LDLIBS) When linking is done by gcc itself, no issue, but when it needs to be passed to proper ld, only LDLIBS follows and then ld cannot know what libs to link with. More detail: https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html LDFLAGS Extra flags to give to compilers when they are supposed to invoke the linker, ‘ld’, such as -L. Libraries (-lfoo) should be added to the LDLIBS variable instead. LDLIBS Library flags or names given to compilers when they are supposed to invoke the linker, ‘ld’. LOADLIBES is a deprecated (but still supported) alternative to LDLIBS. Non-library linker flags, such as -L, should go in the LDFLAGS variable. https://lkml.org/lkml/2010/2/10/362 tools/perf: libraries must come after objects Link order matters. Changes in v2: * address SeongJae Park comment: instead of replacing LDFLAGS, append LDLIBS in the right order. Fathi Boudra (3): selftests: net: use LDLIBS instead of LDFLAGS selftests: seccomp: use LDLIBS instead of LDFLAGS selftests: timers: use LDLIBS instead of LDFLAGS tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/seccomp/Makefile | 4 ++-- tools/testing/selftests/timers/Makefile | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -- 2.13.0