mbox series

[RFC,v3,0/4] irqchip/gic-v3: Add support to DT based quirk for msm8996

Message ID 20181112103340.24702-1-srinivas.kandagatla@linaro.org
Headers show
Series irqchip/gic-v3: Add support to DT based quirk for msm8996 | expand

Message

Srinivas Kandagatla Nov. 12, 2018, 10:33 a.m. UTC 
Access to GICR_WAKER is restricted on msm8996 SoC in Hypervisor.
There are many devices out there with this restriction in place
and there has been no update to this firmware since last few years,
making those devices totally unusable for upstream development.

My previous attempts to add quick based on IIDR register value seems to be
flawed by the fact that the value conflicted with other SoCs.
Last Suggestion by Marc Z using compatible seems to be the only way to apply
quirks required for msm8996 based SoCs.

Here is the patchset which add new compatible for msm8996 gicv3 and add
support gic_enable_of_quirks() followed by the actual quirk required for msm8996.

Without this quirk many qcom SoCs (atleast 3 that I know) are
unable to boot mainline.

Thanks,
Srini

Srinivas Kandagatla (4):
  dt-bindings/gic-v3: Add msm8996 compatible string
  irqchip/gic: common: add support to device tree based quirks
  irqchip: gic-v3: Add quirk for msm8996 secured registers
  arm64: dts: add msm8996 compatible to gicv3

 .../interrupt-controller/arm,gic-v3.txt       |  4 ++-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |  2 +-
 drivers/irqchip/irq-gic-common.c              | 12 +++++++++
 drivers/irqchip/irq-gic-common.h              |  3 +++
 drivers/irqchip/irq-gic-v3.c                  | 26 +++++++++++++++++++
 5 files changed, 45 insertions(+), 2 deletions(-)

-- 
2.19.1

Comments

Marc Zyngier Dec. 7, 2018, 6:21 p.m. UTC | #1 
On 12/11/2018 10:33, Srinivas Kandagatla wrote:
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


Please write a commit log.

	M.

> ---

>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi

> index 16c3fc0f4e69..e38da221f9a9 100644

> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi

> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi

> @@ -902,7 +902,7 @@

>  		};

>  

>  		intc: interrupt-controller@9bc0000 {

> -			compatible = "arm,gic-v3";

> +			compatible = "qcom,msm8996-gic-v3", "arm,gic-v3";

>  			#interrupt-cells = <3>;

>  			interrupt-controller;

>  			#redistributor-regions = <1>;

> 



-- 
Jazz is not dead. It just smells funny...