mbox series

[0/3] clk: qcom: gcc-msm8998: Fixes and clkref clocks

Message ID 20181130065259.26497-1-bjorn.andersson@linaro.org
Headers show
Series clk: qcom: gcc-msm8998: Fixes and clkref clocks | expand

Message

Bjorn Andersson Nov. 30, 2018, 6:52 a.m. UTC 
Mark critical clocks critical, don't halt-check UFS clocks and add clkref
branches.

Bjorn Andersson (3):
  clk: qcom: gcc-msm8998: Mark hmss_dvm and lpass_at critical
  clk: qcom: gcc-msm8998: Disable halt check of UFS clocks
  clk: qcom: gcc-msm8998: Add clkref clocks

 drivers/clk/qcom/gcc-msm8998.c               | 83 +++++++++++++++++++-
 include/dt-bindings/clock/qcom,gcc-msm8998.h |  5 ++
 2 files changed, 85 insertions(+), 3 deletions(-)

-- 
2.18.0

Comments

Stephen Boyd Nov. 30, 2018, 7:06 a.m. UTC | #1 
Quoting Bjorn Andersson (2018-11-29 22:52:58)
> Drop the halt check of the UFS symbol clocks, in accordance with other

> platforms. This makes clk_disable_unused() happy and makes it possible

> to turn the clocks on again without an error.

> 

> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Someone was supposed to figure out why we needed to SKIP here instead of
doing things in the proper order. Is anyone attempting to figure that
out?
Stephen Boyd Nov. 30, 2018, 8:13 a.m. UTC | #2 
Quoting Bjorn Andersson (2018-11-29 23:27:25)
> On Thu 29 Nov 23:06 PST 2018, Stephen Boyd wrote:

> 

> > Quoting Bjorn Andersson (2018-11-29 22:52:58)

> > > Drop the halt check of the UFS symbol clocks, in accordance with other

> > > platforms. This makes clk_disable_unused() happy and makes it possible

> > > to turn the clocks on again without an error.

> > > 

> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> > 

> > Someone was supposed to figure out why we needed to SKIP here instead of

> > doing things in the proper order. Is anyone attempting to figure that

> > out?

> > 

> 

> I'm not aware of any such efforts, but looping in Vivek here.

> 

> I would be happy to revert this change in 8996, 8998 and 845 once such

> fix arrives. But as this is needed to make progress on getting UFS up on

> 8998 it would be nice to get it merged for now...

> 


That's fine. Just doing my periodic ping on this topic.