From patchwork Mon Jan 14 11:14:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 155440 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3536509jaa; Mon, 14 Jan 2019 03:16:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN7XaSvqdMWLwGP18VXFeBslhq9nPpQFizLJjlhXITcyhWj3JPY6+ELaC+QcXsQLHdqu6cS5 X-Received: by 2002:a63:235f:: with SMTP id u31mr19971345pgm.122.1547464589613; Mon, 14 Jan 2019 03:16:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547464589; cv=none; d=google.com; s=arc-20160816; b=e926ksXh9jZMLwxkX8+o5UN8sgC1Fb9AU7Es1F4AQBK5jor8HhWRPk6+SgXbZu/c0m cKmMIVfwF0HMUxPyQcl+7pZWyWwYiijteTMOd7vjSpXmb9yZ6HhNK28F5HKohmGD1qOF x+AUhpvIc9RkH0xbhRzs/S1HQtmm7g4lAEjRWZyqR+a3ZxsYb3pIARX1W44Eyki3OXKx 36umg2+Vox74qZjxlOD1el+4Up78PLTeknIfMgCnq8bWwoPA2zS2AwaUNyotPYVNbiWn qpIxgc81G9xBiDh/eY8nsmkQV2JHpUUcbkShBkahwPSwj6QgosojYNmDa4+hKyB6T8b+ OVbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=kLFHj4SNhOT+xMkxBI11CYXblcxbKAAnFAdH+K5G6Pc=; b=xK0m+/pq42ef2jq9vdpYdSPPqumhtVOO2A0rvlrhjvdB9eKsv5gdeL53mMijEfb31i AWw1Gm78/Te+RgnHSFMyBMTwkm+IJMLblKbGc26gZVBYQvMOrBUJtL13wBxt9KocJk5L uDicTzUv+oiZQ0Zrk8krZPQOc24VO0HOYUjIqSRHDGTpebtM59DojW36vIX09EkOCSsi Z3vIDMg4Tt1WNNA4D/iFHd9vBJQkuCAbZp+7wRGIka2qBzJQgL/PCktwZdapvOQCo/tR KmBnGl4BF+/jU+cz/lchIzjScXGfLrLro6Ow57zabySSG3eIZBbWFDuHiV/+C9ZR04/W k7Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=EBie1+GM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si136654plo.69.2019.01.14.03.16.29; Mon, 14 Jan 2019 03:16:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=EBie1+GM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbfANLQ2 (ORCPT + 31 others); Mon, 14 Jan 2019 06:16:28 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:45542 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726552AbfANLQI (ORCPT ); Mon, 14 Jan 2019 06:16:08 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x0EBFiPr003493; Mon, 14 Jan 2019 05:15:44 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1547464544; bh=kLFHj4SNhOT+xMkxBI11CYXblcxbKAAnFAdH+K5G6Pc=; h=From:To:CC:Subject:Date; b=EBie1+GMKLiveP2DtVf3fbQrtP/s6BZCzo1XPrGHqraiAEX2ApHGZmlMlzVZzfbJK 40E3oEiB6hgB1D1GG/43bLVtV7ImUQw2p4YkgArQI1e8G3/AQn+S2ePW1r0/tFfSPu s0MQAoQNrbZ8qbjMouAAcsmS3rssI//AHPoQJEq8= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x0EBFivY023472 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Jan 2019 05:15:44 -0600 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 14 Jan 2019 05:15:43 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 14 Jan 2019 05:15:43 -0600 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x0EBFd1S011560; Mon, 14 Jan 2019 05:15:40 -0600 From: Kishon Vijay Abraham I To: Kishon Vijay Abraham I , Lorenzo Pieralisi , Gustavo Pimentel , Alan Douglas , Shawn Lin , Heiko Stuebner CC: Bjorn Helgaas , Jingoo Han , , , , , Subject: [PATCH v2 00/15] PCI: endpoint: Cleanup EPC features Date: Mon, 14 Jan 2019 16:44:58 +0530 Message-ID: <20190114111513.21618-1-kishon@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lorenzo, The Endpoint controller driver uses features member in 'struct pci_epc' to advertise the list of supported features to the endpoint function driver. There are a few shortcomings with this approach. *) Certain endpoint controllers support fixed size BAR (e.g. TI's AM654 uses Designware configuration with fixed size BAR). The size of each BARs cannot be passed to the endpoint function driver. *) Too many macros for handling EPC features. (EPC_FEATURE_NO_LINKUP_NOTIFIER, EPC_FEATURE_BAR_MASK, EPC_FEATURE_MSIX_AVAILABLE, EPC_FEATURE_SET_BAR, EPC_FEATURE_GET_BAR) *) Endpoint controllers are directly modifying struct pci_epc members. (I have plans to move struct pci_epc to drivers/pci/endpoint so that pci_epc members are referenced only by endpoint core). To overcome the above shortcomings, introduced pci_epc_get_features() API, pci_epc_features structure and a ->get_features() callback. Also added a patch to set BAR flags in pci_epf_alloc_space and remove it from pci-epf-test function driver. Changes from v1: *) Fixed helper function to return '0' (or BAR_0) for any incorrect values in reserved BAR. *) Do not set_bar or alloc space for BARs if the BARs are reserved *) Fix incorrect check of epc_features in pci_epf_test_bind Tested on TI's DRA7xx platform and AM654 platform. Support for PCIe in AM654 platform will be posted shortly. Kishon Vijay Abraham I (15): PCI: endpoint: Add new pci_epc_ops to get EPC features PCI: dwc: Add ->get_features() callback function in dw_pcie_ep_ops PCI: designware-plat: Populate ->get_features() dw_pcie_ep_ops PCI: pci-dra7xx: Populate ->get_features() dw_pcie_ep_ops PCI: rockchip: Populate ->get_features() dw_pcie_ep_ops PCI: cadence: Populate ->get_features() cdns_pcie_epc_ops PCI: endpoint: Add helper to get first unreserved BAR PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags PCI: pci-epf-test: Remove setting epf_bar flags in function driver PCI: pci-epf-test: Do not allocate next BARs memory if current BAR is 64Bit PCI: pci-epf-test: Use pci_epc_get_features to get EPC features PCI: cadence: Remove pci_epf_linkup from Cadence EP driver PCI: rockchip: Remove pci_epf_linkup from Rockchip EP driver PCI: designware-plat: Remove setting epc->features in Designware plat EP driver PCI: endpoint: Remove features member in struct pci_epc drivers/pci/controller/dwc/pci-dra7xx.c | 13 +++ .../pci/controller/dwc/pcie-designware-ep.c | 12 +++ .../pci/controller/dwc/pcie-designware-plat.c | 17 +++- drivers/pci/controller/dwc/pcie-designware.h | 1 + drivers/pci/controller/pcie-cadence-ep.c | 25 ++--- drivers/pci/controller/pcie-rockchip-ep.c | 16 +++- drivers/pci/endpoint/functions/pci-epf-test.c | 93 ++++++++++++------- drivers/pci/endpoint/pci-epc-core.c | 53 +++++++++++ drivers/pci/endpoint/pci-epf-core.c | 4 +- include/linux/pci-epc.h | 31 +++++-- 10 files changed, 201 insertions(+), 64 deletions(-) -- 2.17.1 Tested-by: Gustavo Pimentel