From patchwork Sat Mar 5 10:46:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 386 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:42:06 -0000 Delivered-To: patches@linaro.org Received: by 10.224.60.68 with SMTP id o4cs43951qah; Sat, 5 Mar 2011 02:49:01 -0800 (PST) Received: by 10.213.30.13 with SMTP id s13mr272245ebc.81.1299322140433; Sat, 05 Mar 2011 02:49:00 -0800 (PST) Received: from eu1sys200aog106.obsmtp.com (eu1sys200aog106.obsmtp.com [207.126.144.121]) by mx.google.com with SMTP id z46si749020eeh.90.2011.03.05.02.48.54 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 05 Mar 2011 02:48:59 -0800 (PST) Received-SPF: neutral (google.com: 207.126.144.121 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) client-ip=207.126.144.121; Authentication-Results: mx.google.com; spf=neutral (google.com: 207.126.144.121 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) smtp.mail=linus.walleij@stericsson.com Received: from source ([164.129.1.35]) (using TLSv1) by eu1sys200aob106.postini.com ([207.126.147.11]) with SMTP ID DSNKTXIVFnsjnE6GmQSV8EhwYFyPnCVUITAV@postini.com; Sat, 05 Mar 2011 10:48:59 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 602405A3; Sat, 5 Mar 2011 10:47:02 +0000 (GMT) Received: from relay1.stm.gmessaging.net (unknown [10.230.100.17]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F19061CC2; Sat, 5 Mar 2011 10:47:01 +0000 (GMT) Received: from exdcvycastm004.EQ1STM.local (alteon-source-exch [10.230.100.61]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "exdcvycastm004", Issuer "exdcvycastm004" (not verified)) by relay1.stm.gmessaging.net (Postfix) with ESMTPS id 0867E24C2F0; Sat, 5 Mar 2011 11:46:26 +0100 (CET) Received: from localhost.localdomain (10.230.100.153) by smtp.stericsson.com (10.230.100.2) with Microsoft SMTP Server (TLS) id 8.2.254.0; Sat, 5 Mar 2011 11:46:31 +0100 From: Linus Walleij To: Samuel Ortiz , Cc: Lee Jones , Daniel Willerud , Linus Walleij Subject: [PATCH 3/5] mfd: free dangling irq in ab8500 gpadc probe error path Date: Sat, 5 Mar 2011 11:46:27 +0100 Message-ID: <1299321987-6832-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.3.2 MIME-Version: 1.0 From: Daniel Willerud Signed-off-by: Daniel Willerud Signed-off-by: Linus Walleij --- drivers/mfd/ab8500-gpadc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c index 178cbc5..b5b75b7 100644 --- a/drivers/mfd/ab8500-gpadc.c +++ b/drivers/mfd/ab8500-gpadc.c @@ -267,11 +267,13 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev) if (IS_ERR(gpadc->regu)) { ret = PTR_ERR(gpadc->regu); dev_err(gpadc->dev, "failed to get vtvout LDO\n"); - goto fail; + goto fail_irq; } list_add_tail(&gpadc->node, &ab8500_gpadc_list); dev_dbg(gpadc->dev, "probe success\n"); return 0; +fail_irq: + free_irq(gpadc->irq, gpadc); fail: kfree(gpadc); gpadc = NULL;