From patchwork Mon Jun 4 11:09:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 9098 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5A0A223F0A for ; Mon, 4 Jun 2012 11:20:08 +0000 (UTC) Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id 2446EA185DF for ; Mon, 4 Jun 2012 11:20:08 +0000 (UTC) Received: by ggnf1 with SMTP id f1so3241225ggn.11 for ; Mon, 04 Jun 2012 04:20:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=NdZ3jvTgs10zbFMcBs3l3l2DizylssKinAZ5i6pZts8=; b=DBcFMkoRwD4KbiRNIZAgRD2084UbkAft9hkvft4+1afE3x3x6gJwDjkB4yB0pt91jP q5uvqSfm4vcdux08pBwLbV986/fT12fiwHzKIEJAvv8CHsfbGQJx69Rfvt2vS9x3rn7Y 9HNuP2e5kNzPehe597Z49tBEapqfCxbFrJFSO+ro8I9oRqIDgFN0yAqVj6LueuMwvMAZ aTGq+tKoS74wFCrVNpyEbOJJPv7JjYFT5erm2Ciskr7u9aST2FFTtJbVNBU3U9Sc3Jr2 GoJPqzke2sfpwEcTkB3IUb8OeKvujBJCpajxIc9l0hRP+f1HVb+PCfPz+9nqiDVWPedO MkVQ== Received: by 10.42.210.193 with SMTP id gl1mr6761709icb.57.1338808807419; Mon, 04 Jun 2012 04:20:07 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.24.148 with SMTP id v20csp100414ibb; Mon, 4 Jun 2012 04:20:06 -0700 (PDT) Received: by 10.68.219.199 with SMTP id pq7mr38774286pbc.93.1338808806366; Mon, 04 Jun 2012 04:20:06 -0700 (PDT) Received: from mail-pz0-f50.google.com (mail-pz0-f50.google.com [209.85.210.50]) by mx.google.com with ESMTPS id pk6si15953982pbc.0.2012.06.04.04.20.06 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Jun 2012 04:20:06 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.210.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by danh15 with SMTP id h15so6663222dan.37 for ; Mon, 04 Jun 2012 04:20:06 -0700 (PDT) Received: by 10.68.242.99 with SMTP id wp3mr38580212pbc.21.1338808805964; Mon, 04 Jun 2012 04:20:05 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id iu6sm669799pbc.35.2012.06.04.04.20.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Jun 2012 04:20:05 -0700 (PDT) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: sameo@linux.intel.com, myungjoo.ham@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] mfd: max8997: Add missing static storage class specifier Date: Mon, 4 Jun 2012 16:39:07 +0530 Message-Id: <1338808147-1862-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQniQYXsE6P1ekjWkofBYoFQ0w+nxat+KoblXbaHTVCjSIwQEXkSCG1id5ApJ5wQnN+GCThl Fixes the following sparse warnings: drivers/mfd/max8997.c:209:4: warning: symbol 'max8997_dumpaddr_pmic' was not declared. Should it be static? drivers/mfd/max8997.c:334:4: warning: symbol 'max8997_dumpaddr_muic' was not declared. Should it be static? drivers/mfd/max8997.c:344:4: warning: symbol 'max8997_dumpaddr_haptic' was not declared. Should it be static? drivers/mfd/max8997.c:426:25: warning: symbol 'max8997_pm' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/mfd/max8997.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c index cb83a7a..454f499 100644 --- a/drivers/mfd/max8997.c +++ b/drivers/mfd/max8997.c @@ -206,7 +206,7 @@ static const struct i2c_device_id max8997_i2c_id[] = { }; MODULE_DEVICE_TABLE(i2c, max8998_i2c_id); -u8 max8997_dumpaddr_pmic[] = { +static u8 max8997_dumpaddr_pmic[] = { MAX8997_REG_INT1MSK, MAX8997_REG_INT2MSK, MAX8997_REG_INT3MSK, @@ -331,7 +331,7 @@ u8 max8997_dumpaddr_pmic[] = { MAX8997_REG_DVSOKTIMER5, }; -u8 max8997_dumpaddr_muic[] = { +static u8 max8997_dumpaddr_muic[] = { MAX8997_MUIC_REG_INTMASK1, MAX8997_MUIC_REG_INTMASK2, MAX8997_MUIC_REG_INTMASK3, @@ -341,7 +341,7 @@ u8 max8997_dumpaddr_muic[] = { MAX8997_MUIC_REG_CONTROL3, }; -u8 max8997_dumpaddr_haptic[] = { +static u8 max8997_dumpaddr_haptic[] = { MAX8997_HAPTIC_REG_CONF1, MAX8997_HAPTIC_REG_CONF2, MAX8997_HAPTIC_REG_DRVCONF, @@ -423,7 +423,7 @@ static int max8997_resume(struct device *dev) return max8997_irq_resume(max8997); } -const struct dev_pm_ops max8997_pm = { +static const struct dev_pm_ops max8997_pm = { .suspend = max8997_suspend, .resume = max8997_resume, .freeze = max8997_freeze,