From patchwork Thu Aug 30 18:18:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11058 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id C91E623F70 for ; Thu, 30 Aug 2012 18:20:01 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 7931FA1833A for ; Thu, 30 Aug 2012 18:19:25 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id k11so996735iea.11 for ; Thu, 30 Aug 2012 11:20:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=DqFQbz9UaANEg3HbH8za5yifpRjwb5ihPRO62ornTuE=; b=mTzWzIhFKy+CEYPRbX9o2/4sHRrfotR0CYyd2+CH0aVsCL5Vsh04H68DCatY63Gsom Xf5zC5zSBWMU1XKDbfogHmX1W5mU3F6HTyulULmOd+v5tbmuFTZgU3vpyRay3e9hO9lz FsM1qMx+dsex/yhxtOtaEFV5Fg80qfUKEgLsxBEAw4pa9PWWv98pxk5PNKJtKQZB5pq9 cDScFCqR6//Z4r15UiorOvd/D+W1kdPFrfUui1kvg92rzq1kYym/EsDlpZbTf1JjcFQc Y89BAGHi1FU9oP+3Uiyyk7/LM58iGlzqXyu1IkIT1UyJyV1SYSIu+K+mZGmnyrsdzS2Q FUBg== Received: by 10.50.207.106 with SMTP id lv10mr1906758igc.0.1346350801181; Thu, 30 Aug 2012 11:20:01 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp24759igc; Thu, 30 Aug 2012 11:20:00 -0700 (PDT) Received: by 10.60.31.165 with SMTP id b5mr5556637oei.58.1346350800804; Thu, 30 Aug 2012 11:20:00 -0700 (PDT) Received: from e37.co.us.ibm.com (e37.co.us.ibm.com. [32.97.110.158]) by mx.google.com with ESMTPS id im8si3091038obb.94.2012.08.30.11.20.00 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 11:20:00 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) client-ip=32.97.110.158; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 12:20:00 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 12:19:15 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id C6B481FF0040 for ; Thu, 30 Aug 2012 12:19:07 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7UIJ3nK064618 for ; Thu, 30 Aug 2012 12:19:04 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7UIIhWQ018826 for ; Thu, 30 Aug 2012 12:18:50 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-77-132-62.mts.ibm.com [9.77.132.62]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7UIIgJE018694; Thu, 30 Aug 2012 12:18:42 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id 65E4AEA830; Thu, 30 Aug 2012 11:18:40 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "Paul E. McKenney" Subject: [PATCH tip/core/rcu 10/23] rcu: Allow RCU quiescent-state forcing to be preempted Date: Thu, 30 Aug 2012 11:18:25 -0700 Message-Id: <1346350718-30937-10-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346350718-30937-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830181811.GA29154@linux.vnet.ibm.com> <1346350718-30937-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083018-7408-0000-0000-0000080A1C39 X-Gm-Message-State: ALoCoQl9R+EeTXfBS+UMAqLxsNAH4CciTKiHIWM91Ykpuk0sSecEnUQBkwQhGJMY40JBi5BpV0QZ From: "Paul E. McKenney" RCU quiescent-state forcing is currently carried out without preemption points, which can result in excessive latency spikes on large systems (many hundreds or thousands of CPUs). This patch therefore inserts a voluntary preemption point into force_qs_rnp(), which should greatly reduce the magnitude of these spikes. Reported-by: Mike Galbraith Reported-by: Dimitri Sivanich Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- kernel/rcutree.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/rcutree.c b/kernel/rcutree.c index 79c2c28..cce73ff 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c @@ -1784,6 +1784,7 @@ static void force_qs_rnp(struct rcu_state *rsp, int (*f)(struct rcu_data *)) struct rcu_node *rnp; rcu_for_each_leaf_node(rsp, rnp) { + cond_resched(); mask = 0; raw_spin_lock_irqsave(&rnp->lock, flags); if (!rcu_gp_in_progress(rsp)) {