From patchwork Thu Aug 30 18:18:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11057 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 6578F23EFE for ; Thu, 30 Aug 2012 18:20:01 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 2F340A1818E for ; Thu, 30 Aug 2012 18:19:25 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so3403526iaf.11 for ; Thu, 30 Aug 2012 11:20:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=t9hlXgHUd6mmJzYM54+lKYye7rcWldElQ1Rs6QdhfqQ=; b=VzCH/Il/NgFzFUMz0UkSZZZ1BXd6ZtU5QJYMmIXWiULkT7e7dSOLNlVLIcuYpY1HNO DCLAMjVyVLJ4A29P5VfcWINfDbjXDwbMilLz6AsqZ3jTLrwDueVkfBKiToZDpd9gYIOA k06SFcO+0XuV2TXsNTO402JnXa0W+PCkKIj9CyFgnva2qCz3jtlOugk+7aSgeaFaX3Kc jnBnNF+uPVwMD4hxxVJEYt7sKryZMFrv4XdTJ5qFD8YGcE+S13M8+W/dS31YDVBFJBPR 8VNHgdDxPBunWohvPXZLt9Sc9nHIaFke7/hE4uRV8dntJ5OlWdxq6khFEU9OsHTdw5VM Td5Q== Received: by 10.50.159.196 with SMTP id xe4mr1715661igb.43.1346350800721; Thu, 30 Aug 2012 11:20:00 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp24757igc; Thu, 30 Aug 2012 11:20:00 -0700 (PDT) Received: by 10.60.12.234 with SMTP id b10mr5780409oec.72.1346350800176; Thu, 30 Aug 2012 11:20:00 -0700 (PDT) Received: from e37.co.us.ibm.com (e37.co.us.ibm.com. [32.97.110.158]) by mx.google.com with ESMTPS id tg7si3102073obb.42.2012.08.30.11.19.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 11:20:00 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) client-ip=32.97.110.158; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 12:19:59 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 12:19:13 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 593FE1FF0042; Thu, 30 Aug 2012 12:19:07 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7UIImX2087310; Thu, 30 Aug 2012 12:18:54 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7UIIfkW018678; Thu, 30 Aug 2012 12:18:45 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-77-132-62.mts.ibm.com [9.77.132.62]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7UIIe4u018628; Thu, 30 Aug 2012 12:18:40 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id EA30AEA82A; Thu, 30 Aug 2012 11:18:39 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "Paul E. McKenney" , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 05/23] rcu: Prevent offline CPUs from executing RCU core code Date: Thu, 30 Aug 2012 11:18:20 -0700 Message-Id: <1346350718-30937-5-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346350718-30937-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830181811.GA29154@linux.vnet.ibm.com> <1346350718-30937-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083018-7408-0000-0000-0000080A1C27 X-Gm-Message-State: ALoCoQn26z/2d2YN+5Ean8oOqLQkCqVvWM7QC/5Pka6lXxNlyfrTEb0n0z9OPu8Ls/04e4W23QeG From: "Paul E. McKenney" Earlier versions of RCU invoked the RCU core from the CPU_DYING notifier in order to note a quiescent state for the outgoing CPU. Because the CPU is marked "offline" during the execution of the CPU_DYING notifiers, the RCU core had to tolerate being invoked from an offline CPU. However, commit b1420f1c (Make rcu_barrier() less disruptive) left only tracing code in the CPU_DYING notifier, so the RCU core need no longer execute on offline CPUs. This commit therefore enforces this restriction. Signed-off-by: Paul E. McKenney Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- kernel/rcutree.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/rcutree.c b/kernel/rcutree.c index 300aba6..84a6f55 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c @@ -1892,6 +1892,8 @@ static void rcu_process_callbacks(struct softirq_action *unused) { struct rcu_state *rsp; + if (cpu_is_offline(smp_processor_id())) + return; trace_rcu_utilization("Start RCU core"); for_each_rcu_flavor(rsp) __rcu_process_callbacks(rsp);