From patchwork Thu Aug 30 21:05:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11091 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id CA51423F70 for ; Thu, 30 Aug 2012 21:14:23 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 3C6FAA181FC for ; Thu, 30 Aug 2012 21:13:47 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so3686184iaf.11 for ; Thu, 30 Aug 2012 14:14:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=zwHI+ME8fa8tf3W1+S9AaSiOhDmbUgWEgqPTJ4kHtW8=; b=fcQKniYksdZSFCOK0MFUtZ+iYQNpALny5Qphp682R0v7xZfEvARI9GbLxVxLHiKRzV RCa4JFNqpwM1NhP+eW+nAszN9HxmhvZcJhQ52My/oLtD+Xgl1d0i+MrprlUvR9av7Gqg xbqOWaUvjPxnZ91hQQXgDjrENZjIK3HQV+QX3Arm0sRPckvardwpxb67axUwjL9aodcm huCBQ+08ZEqsVRwARKsXGM2m0zfuVTZIfrFre2I3vUfxllTso1cQ3CD2RAp8Oi0CPExP ybe50fmP0veZR+/A0snF3qR6lSN+jr4p2oyc4NgzNE5WCQ0jsquMB1viSILucmsJumEl DqzA== Received: by 10.42.60.139 with SMTP id q11mr6293975ich.53.1346361263264; Thu, 30 Aug 2012 14:14:23 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp31668igc; Thu, 30 Aug 2012 14:14:22 -0700 (PDT) Received: by 10.42.123.130 with SMTP id s2mr6356776icr.50.1346361260997; Thu, 30 Aug 2012 14:14:20 -0700 (PDT) Received: from e1.ny.us.ibm.com (e1.ny.us.ibm.com. [32.97.182.141]) by mx.google.com with ESMTPS id qa7si4575653icb.91.2012.08.30.14.14.19 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 14:14:20 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.141 as permitted sender) client-ip=32.97.182.141; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.141 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e1.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 17:14:16 -0400 Received: from d01dlp03.pok.ibm.com (9.56.250.168) by e1.ny.us.ibm.com (192.168.1.101) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 17:13:45 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 73383C9003E for ; Thu, 30 Aug 2012 17:13:44 -0400 (EDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ULDhQD158242 for ; Thu, 30 Aug 2012 17:13:44 -0400 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ULDY8w009263 for ; Thu, 30 Aug 2012 15:13:40 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-153-225.mts.ibm.com [9.65.153.225]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7ULDYvZ009182; Thu, 30 Aug 2012 15:13:34 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id 1CD74EA84B; Thu, 30 Aug 2012 14:05:47 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "3.2.x.." , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 18/26] frv: Add missing RCU idle APIs on idle loop Date: Thu, 30 Aug 2012 14:05:35 -0700 Message-Id: <1346360743-3628-18-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830210520.GA2824@linux.vnet.ibm.com> <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083021-6078-0000-0000-00000ED8C55D X-Gm-Message-State: ALoCoQkr9PgzAcHhKoNwhKVipK4oyfEaH2lovvu96LaxrhTl3eXdn+S0/FMl7iKuHhRFz0VtvY6k From: Frederic Weisbecker In the old times, the whole idle task was considered as an RCU quiescent state. But as RCU became more and more successful overtime, some RCU read side critical section have been added even in the code of some architectures idle tasks, for tracing for example. So nowadays, rcu_idle_enter() and rcu_idle_exit() must be called by the architecture to tell RCU about the part in the idle loop that doesn't make use of rcu read side critical sections, typically the part that puts the CPU in low power mode. This is necessary for RCU to find the quiescent states in idle in order to complete grace periods. Add this missing pair of calls in the Frv's idle loop. Reported-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker Cc: David Howells Cc: 3.2.x.. Cc: Paul E. McKenney Reviewed-by: Josh Triplett --- arch/frv/kernel/process.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/frv/kernel/process.c b/arch/frv/kernel/process.c index ff95f50..2eb7fa5 100644 --- a/arch/frv/kernel/process.c +++ b/arch/frv/kernel/process.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include @@ -69,12 +70,14 @@ void cpu_idle(void) { /* endless idle loop with no priority at all */ while (1) { + rcu_idle_enter(); while (!need_resched()) { check_pgt_cache(); if (!frv_dma_inprogress && idle) idle(); } + rcu_idle_exit(); schedule_preempt_disabled(); }