From patchwork Thu Aug 30 21:05:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11084 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 798D923E52 for ; Thu, 30 Aug 2012 21:14:18 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id F07A3A181FC for ; Thu, 30 Aug 2012 21:13:41 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so3686184iaf.11 for ; Thu, 30 Aug 2012 14:14:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=bkZmPL4KGC0DXQCqPJmyNyyK5GnUv9Ay0M/vBxXyoY4=; b=k2OQoBloui8aVUG0fc+LmOu7H/14jFkvFsPrY83dD0+12cYPUERBfFxTRHkNgwuYbJ hCdGnK6mM9oiNYNg4/bRx2Eedz+dWtyqBbu0+5vjiHtBFCUuxHyMqCzbzrdeCm1HYuHa Qwly/O/F05kHg/AqGvmqE+D7f9Ekdxeyswv7rsx3DH67M4y5lEmQjsOpKMY2ElzSzbn/ ApTszNGSlRl2k22v9loWlEojwRqFRjz1WREriJlxRVK4UAHdgQICBnMfCzIRMNZ2ITu5 /cjurh9aJrgf98wwanvABAHTBuVJiTnG+Ah5zFZibpx6qh5vy1YJw7C9ebx92AjVqV/Q tiNw== Received: by 10.42.109.194 with SMTP id m2mr6267305icp.48.1346361257976; Thu, 30 Aug 2012 14:14:17 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp31653igc; Thu, 30 Aug 2012 14:14:17 -0700 (PDT) Received: by 10.182.119.72 with SMTP id ks8mr6070258obb.10.1346361257315; Thu, 30 Aug 2012 14:14:17 -0700 (PDT) Received: from e37.co.us.ibm.com (e37.co.us.ibm.com. [32.97.110.158]) by mx.google.com with ESMTPS id lr6si3485965obb.160.2012.08.30.14.14.17 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 14:14:17 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) client-ip=32.97.110.158; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 15:14:15 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 15:14:10 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 38E1D1FF0040 for ; Thu, 30 Aug 2012 15:14:06 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ULDjju173802 for ; Thu, 30 Aug 2012 15:13:45 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ULDYsM009252 for ; Thu, 30 Aug 2012 15:13:41 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-153-225.mts.ibm.com [9.65.153.225]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7ULDYlC009164; Thu, 30 Aug 2012 15:13:34 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id 3142BEA84C; Thu, 30 Aug 2012 14:05:47 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, Yoshinori Sato , "3.2.x.." , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 19/26] h8300: Add missing RCU idle APIs on idle loop Date: Thu, 30 Aug 2012 14:05:36 -0700 Message-Id: <1346360743-3628-19-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830210520.GA2824@linux.vnet.ibm.com> <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083021-7408-0000-0000-0000080B5705 X-Gm-Message-State: ALoCoQkKvZw9wTTCK5lvNTh7sA8przptCHEEATangz9Q9bchA9KtFcVgBLVR9VyGzymJiM836/Er From: Frederic Weisbecker In the old times, the whole idle task was considered as an RCU quiescent state. But as RCU became more and more successful overtime, some RCU read side critical section have been added even in the code of some architectures idle tasks, for tracing for example. So nowadays, rcu_idle_enter() and rcu_idle_exit() must be called by the architecture to tell RCU about the part in the idle loop that doesn't make use of rcu read side critical sections, typically the part that puts the CPU in low power mode. This is necessary for RCU to find the quiescent states in idle in order to complete grace periods. Add this missing pair of calls in the h8300's idle loop. Reported-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker Cc: Yoshinori Sato Cc: 3.2.x.. Cc: Paul E. McKenney Reviewed-by: Josh Triplett --- arch/h8300/kernel/process.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/h8300/kernel/process.c b/arch/h8300/kernel/process.c index 0e9c315..f153ed1 100644 --- a/arch/h8300/kernel/process.c +++ b/arch/h8300/kernel/process.c @@ -36,6 +36,7 @@ #include #include #include +#include #include #include @@ -78,8 +79,10 @@ void (*idle)(void) = default_idle; void cpu_idle(void) { while (1) { + rcu_idle_enter(); while (!need_resched()) idle(); + rcu_idle_exit(); schedule_preempt_disabled(); } }