From patchwork Thu Aug 30 21:05:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11073 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 20F4823E52 for ; Thu, 30 Aug 2012 21:13:50 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 8B1A7A192C9 for ; Thu, 30 Aug 2012 21:13:13 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so3685139iaf.11 for ; Thu, 30 Aug 2012 14:13:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=cV/v65aT9gTpcK8zWsNg9wXJfwSBc/mEcwNFg1+jEMY=; b=mIDWTYD/U9pMeAHrfKxWPkjHzJtPBtQmtNt1YnvDDMjL4ntkFPpumzTUyf4a3QD8bZ E4Gc3F7cd6eCLPHH2eRABjkc/xv2AwX2H81Na2BSm3HX5gQLznrLNvFDRAnqHTm2kRpe tERzOeP78gE54MP6fCk29SPlcYpLioWuX2Dwn/MWvXkxDPYdujzj6rwSmsfvKHMGvKuN H+HyG9CFbcxKXQd2GfSKlTomKjjg3P4S09mWuyXGAaBOaoxxxDcdAkusySWt9F00xwHg ODqqBZL/8LnN6nXkaaUskL/5xIiclUuvsi9GbQxBZ4A/u5tiO/h0NPo/Pf17wymX5JMF yLZg== Received: by 10.50.242.3 with SMTP id wm3mr2557489igc.0.1346361229558; Thu, 30 Aug 2012 14:13:49 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp31622igc; Thu, 30 Aug 2012 14:13:49 -0700 (PDT) Received: by 10.50.181.200 with SMTP id dy8mr2450583igc.36.1346361229209; Thu, 30 Aug 2012 14:13:49 -0700 (PDT) Received: from e7.ny.us.ibm.com (e7.ny.us.ibm.com. [32.97.182.137]) by mx.google.com with ESMTPS id ak4si4580851icc.76.2012.08.30.14.13.49 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 14:13:49 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.137 as permitted sender) client-ip=32.97.182.137; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.137 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 17:13:48 -0400 Received: from d01dlp01.pok.ibm.com (9.56.250.166) by e7.ny.us.ibm.com (192.168.1.107) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 17:13:45 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 1DC8E38C804A for ; Thu, 30 Aug 2012 17:13:45 -0400 (EDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ULDiAp170192 for ; Thu, 30 Aug 2012 17:13:44 -0400 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ULDZSd009344 for ; Thu, 30 Aug 2012 15:13:40 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-153-225.mts.ibm.com [9.65.153.225]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7ULDYvb009182; Thu, 30 Aug 2012 15:13:34 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id 60630EA84E; Thu, 30 Aug 2012 14:05:47 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, m68k , "3.2.x.." , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 21/26] m68k: Add missing RCU idle APIs on idle loop Date: Thu, 30 Aug 2012 14:05:38 -0700 Message-Id: <1346360743-3628-21-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830210520.GA2824@linux.vnet.ibm.com> <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083021-5806-0000-0000-000018FE3448 X-Gm-Message-State: ALoCoQkySKKENf7suQKOMEbYUxopaG7gALq/LpceAKmThMDALMfPu6OXeVFTQXKghJGcqlOjfQkL From: Frederic Weisbecker In the old times, the whole idle task was considered as an RCU quiescent state. But as RCU became more and more successful overtime, some RCU read side critical section have been added even in the code of some architectures idle tasks, for tracing for example. So nowadays, rcu_idle_enter() and rcu_idle_exit() must be called by the architecture to tell RCU about the part in the idle loop that doesn't make use of rcu read side critical sections, typically the part that puts the CPU in low power mode. This is necessary for RCU to find the quiescent states in idle in order to complete grace periods. Add this missing pair of calls in the m68k's idle loop. Reported-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker Acked-by: Geert Uytterhoeven Cc: m68k Cc: 3.2.x.. Cc: Paul E. McKenney Reviewed-by: Josh Triplett --- arch/m68k/kernel/process.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c index c488e3c..ac2892e 100644 --- a/arch/m68k/kernel/process.c +++ b/arch/m68k/kernel/process.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include @@ -75,8 +76,10 @@ void cpu_idle(void) { /* endless idle loop with no priority at all */ while (1) { + rcu_idle_enter(); while (!need_resched()) idle(); + rcu_idle_exit(); schedule_preempt_disabled(); } }