From patchwork Thu Aug 30 21:05:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 11094 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4DA5923E52 for ; Thu, 30 Aug 2012 21:14:30 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id A9BC4A18196 for ; Thu, 30 Aug 2012 21:13:53 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so3686184iaf.11 for ; Thu, 30 Aug 2012 14:14:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=YUkrYUWJtfD1hdIW9HifJk7eoJp6QsVXa4Rk1CVEl64=; b=dRG03o90EC+48eOZaIX9FoxNKiAErS9g0V0RNUvioHGE8rbRPczCyd2Z/J3hxomK2W mKIIHWJh/wpu9isIC69myCnxwXKd8d9fu4ZfsQlv31um3vzdQUAIMy/Kmh7rSId18H/7 TJCkYKwXvLnfJvs4yfHwwkLn5Vkdj7dE/mlUZY4soBYYUISXokaAMk5Ik9YJO1oCGbEb ka2IF4lDJ8LnGMsYA54tq8P0ACw/BSe+BCjNdmNM0FdADQEQmI9DJraF9GKhkWP9vvp8 WhO7KYr7erbcU5IiVOwHwx4YDp/xJhBOMU2z+FjB+zP7rdVflCbm5vekSk026q03Jul2 mRVw== Received: by 10.50.10.201 with SMTP id k9mr2458849igb.28.1346361269714; Thu, 30 Aug 2012 14:14:29 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp31680igc; Thu, 30 Aug 2012 14:14:29 -0700 (PDT) Received: by 10.60.28.202 with SMTP id d10mr5927886oeh.36.1346361269187; Thu, 30 Aug 2012 14:14:29 -0700 (PDT) Received: from e37.co.us.ibm.com (e37.co.us.ibm.com. [32.97.110.158]) by mx.google.com with ESMTPS id lg5si3477788obb.200.2012.08.30.14.14.28 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 14:14:29 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) client-ip=32.97.110.158; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.158 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2012 15:14:28 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Aug 2012 15:14:25 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 117D53E4006A for ; Thu, 30 Aug 2012 15:14:17 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ULDx3J037136 for ; Thu, 30 Aug 2012 15:14:05 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ULDXQ1009137 for ; Thu, 30 Aug 2012 15:13:37 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-153-225.mts.ibm.com [9.65.153.225]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q7ULDWpl009016; Thu, 30 Aug 2012 15:13:33 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id B096CEA852; Thu, 30 Aug 2012 14:05:47 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, Chris Zankel , "3.2.x.." , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 25/26] xtensa: Add missing RCU idle APIs on idle loop Date: Thu, 30 Aug 2012 14:05:42 -0700 Message-Id: <1346360743-3628-25-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120830210520.GA2824@linux.vnet.ibm.com> <1346360743-3628-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12083021-7408-0000-0000-0000080B577C X-Gm-Message-State: ALoCoQnLeSPX85UWVwSF8JksgjhqmgDalj19GkKFJOlMopzlHL7EW5BnJUISaotYGJyGRVLtIOrY From: Frederic Weisbecker In the old times, the whole idle task was considered as an RCU quiescent state. But as RCU became more and more successful overtime, some RCU read side critical section have been added even in the code of some architectures idle tasks, for tracing for example. So nowadays, rcu_idle_enter() and rcu_idle_exit() must be called by the architecture to tell RCU about the part in the idle loop that doesn't make use of rcu read side critical sections, typically the part that puts the CPU in low power mode. This is necessary for RCU to find the quiescent states in idle in order to complete grace periods. Add this missing pair of calls in the xtensa's idle loop. Reported-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker Cc: Chris Zankel Cc: 3.2.x.. Cc: Paul E. McKenney Reviewed-by: Josh Triplett --- arch/xtensa/kernel/process.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/xtensa/kernel/process.c b/arch/xtensa/kernel/process.c index 2c8d6a3..bc44311 100644 --- a/arch/xtensa/kernel/process.c +++ b/arch/xtensa/kernel/process.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include @@ -110,8 +111,10 @@ void cpu_idle(void) /* endless idle loop with no priority at all */ while (1) { + rcu_idle_enter(); while (!need_resched()) platform_idle(); + rcu_idle_exit(); schedule_preempt_disabled(); } }