From patchwork Thu Sep 27 11:27:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 11755 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 646EB23EFB for ; Thu, 27 Sep 2012 11:31:42 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id F153EA186BF for ; Thu, 27 Sep 2012 11:31:41 +0000 (UTC) Received: by ieje10 with SMTP id e10so3871474iej.11 for ; Thu, 27 Sep 2012 04:31:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=2SeeJOBdIwpOI1vf3DDaC+eaNSjE9uzqCXmQ/KK0d+Y=; b=ef5wdTe0Ta+dKOpwOhOvC52JPuM+quQxd3mXoHBizn/ueYo4ZTlXLysxh5Kkx/xQeV 6zE1AgEM/EBc1Kq170gOzkKg05CAr1FpwA0b8mTW0mfjZyPXyxo/CnLVuU6eCrUO1ykn z36nRSVO999Rwfs3w6Egm1mGIp902W3D7c4QUXnc5MjOdfKAUF1tyxkfd1gEdyFsLkiQ HLHUGuS1fLwe0exeNN6Ds6IEXIpVWe/WmrLrEkxwAeGxgAQsbEUb7XkB4vVBsdC1S0bi owxDQW/EnEMeKuNnT9yrw2X0oEwZlX8GbedgBl51oxotUOxydd5plyON3x4u6rmdopgo UzYQ== Received: by 10.50.150.198 with SMTP id uk6mr3238161igb.43.1348745501439; Thu, 27 Sep 2012 04:31:41 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp410253igc; Thu, 27 Sep 2012 04:31:40 -0700 (PDT) Received: by 10.68.130.198 with SMTP id og6mr4606598pbb.163.1348745500124; Thu, 27 Sep 2012 04:31:40 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id wn9si6958181pbc.144.2012.09.27.04.31.39 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 27 Sep 2012 04:31:40 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by pbcmd4 with SMTP id md4so1008266pbc.37 for ; Thu, 27 Sep 2012 04:31:39 -0700 (PDT) Received: by 10.68.242.9 with SMTP id wm9mr10670553pbc.62.1348745499407; Thu, 27 Sep 2012 04:31:39 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id jv10sm3709238pbc.23.2012.09.27.04.31.36 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 27 Sep 2012 04:31:38 -0700 (PDT) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: durgadoss.r@intel.com, rui.zhang@intel.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/2] thermal: fair_share: Add missing static storage class specifiers Date: Thu, 27 Sep 2012 16:57:53 +0530 Message-Id: <1348745274-15936-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnmYJiVxZbAGMvj01bKVQv8nUBHOiGSWSsA75QWdo9pFGVC8vihGErY9Z0ZnNOUeEw3Vpvb Fixes the following sparse warnings: drivers/thermal/fair_share.c:80:5: warning: symbol 'fair_share_throttle' was not declared. Should it be static? drivers/thermal/fair_share.c:111:25: warning: symbol 'thermal_gov_fair_share' was not declared. Should it be static? Signed-off-by: Sachin Kamat Acked-by: Durgadoss R --- drivers/thermal/fair_share.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c index 5d3a7a3..792479f 100644 --- a/drivers/thermal/fair_share.c +++ b/drivers/thermal/fair_share.c @@ -77,7 +77,7 @@ static long get_target_state(struct thermal_zone_device *tz, * (Heavily assumes the trip points are in ascending order) * new_state of cooling device = P3 * P2 * P1 */ -int fair_share_throttle(struct thermal_zone_device *tz, int trip) +static int fair_share_throttle(struct thermal_zone_device *tz, int trip) { const struct thermal_zone_params *tzp; struct thermal_cooling_device *cdev; @@ -108,7 +108,7 @@ int fair_share_throttle(struct thermal_zone_device *tz, int trip) return 0; } -struct thermal_governor thermal_gov_fair_share = { +static struct thermal_governor thermal_gov_fair_share = { .name = "fair_share", .throttle = fair_share_throttle, .owner = THIS_MODULE,