From patchwork Tue Oct 30 16:46:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 12591 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7248A23EF7 for ; Tue, 30 Oct 2012 16:47:11 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 21599A18502 for ; Tue, 30 Oct 2012 16:47:11 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so684041iej.11 for ; Tue, 30 Oct 2012 09:47:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-content-scanned:x-cbid:x-gm-message-state; bh=0pipR1aWNPHU7BKc2b8EvnKQXHRord34UslqucnxN4Q=; b=KgmqX2JEzw022uEAVYJHdW1+C1SOqINzUl9Udgcod/mHsvgdrgX1hTLhUbLaqh8iFz 2X1j0jMWpOwYgrE6Al+wLmSjPZBLKPdbdhxDoznQ9wDMIxjGkuiRyxsRk3AGcrB0JSue 0QzA/ca14YPIRTP8YcDGpaz/1gKGJzb4um30OOpeA4r0rxw7zbNOlHf82136/XCfwGh0 HbtCtFGsPKi+ub44bopw9vKVz+eP+/HBjMscWQesjr3hPtiaYCNkpf3UJ9L8E2jJXH6A axyStbF5oC8Ea6yXuCSTK6Q8FT5kmBqPCijfTWNXMN+nuiMLAq+WKei/0jD3SWvj5rKz aB5A== Received: by 10.50.91.195 with SMTP id cg3mr2058868igb.57.1351615630725; Tue, 30 Oct 2012 09:47:10 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp448206igt; Tue, 30 Oct 2012 09:47:10 -0700 (PDT) Received: by 10.50.57.193 with SMTP id k1mr2140601igq.18.1351615630243; Tue, 30 Oct 2012 09:47:10 -0700 (PDT) Received: from e32.co.us.ibm.com (e32.co.us.ibm.com. [32.97.110.150]) by mx.google.com with ESMTPS id ng8si1230698icb.24.2012.10.30.09.47.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 30 Oct 2012 09:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.150 as permitted sender) client-ip=32.97.110.150; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.150 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 Oct 2012 10:47:09 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 30 Oct 2012 10:47:06 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 3720C3E40066; Tue, 30 Oct 2012 10:47:02 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9UGkwEB172796; Tue, 30 Oct 2012 10:46:59 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9UGkvDi022568; Tue, 30 Oct 2012 10:46:58 -0600 Received: from paulmck-ThinkPad-W500 (sig-9-65-77-17.mts.ibm.com [9.65.77.17]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q9UGktG1022440; Tue, 30 Oct 2012 10:46:56 -0600 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id A1266E4D59; Tue, 30 Oct 2012 09:46:55 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "Paul E. McKenney" , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 2/4] rcu: Add grace-period information to RCU CPU stall warnings Date: Tue, 30 Oct 2012 09:46:47 -0700 Message-Id: <1351615609-25316-2-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1351615609-25316-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20121030164622.GA25108@linux.vnet.ibm.com> <1351615609-25316-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12103016-5406-0000-0000-0000018E5FC1 X-Gm-Message-State: ALoCoQk9l/TrkIN16CRQttlbPFBUQJmVF6C86RkKwDjKAHK+nqxpGoJZg8s6FCgiObpCTnxrxUda From: "Paul E. McKenney" This commit causes the last grace period started and completed to be printed on RCU CPU stall warning messages in order to aid diagnosis. Signed-off-by: Paul E. McKenney Signed-off-by: Paul E. McKenney --- kernel/rcutree.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/rcutree.c b/kernel/rcutree.c index e785387..8f4de3a 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c @@ -947,8 +947,9 @@ static void print_other_cpu_stall(struct rcu_state *rsp) raw_spin_unlock_irqrestore(&rnp->lock, flags); print_cpu_stall_info_end(); - printk(KERN_CONT "(detected by %d, t=%ld jiffies)\n", - smp_processor_id(), (long)(jiffies - rsp->gp_start)); + pr_cont("(detected by %d, t=%ld jiffies, g=%lu, c=%lu)\n", + smp_processor_id(), (long)(jiffies - rsp->gp_start), + rsp->gpnum, rsp->completed); if (ndetected == 0) printk(KERN_ERR "INFO: Stall ended before state dump start\n"); else if (!trigger_all_cpu_backtrace()) @@ -975,7 +976,8 @@ static void print_cpu_stall(struct rcu_state *rsp) print_cpu_stall_info_begin(); print_cpu_stall_info(rsp, smp_processor_id()); print_cpu_stall_info_end(); - printk(KERN_CONT " (t=%lu jiffies)\n", jiffies - rsp->gp_start); + pr_cont(" (t=%lu jiffies g=%lu c=%lu)\n", + jiffies - rsp->gp_start, rsp->gpnum, rsp->completed); if (!trigger_all_cpu_backtrace()) dump_stack();