From patchwork Tue Nov 6 15:16:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 12692 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7F73C23F56 for ; Tue, 6 Nov 2012 15:16:59 +0000 (UTC) Received: from mail-ia0-f180.google.com (mail-ia0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 2EF61A1843E for ; Tue, 6 Nov 2012 15:16:59 +0000 (UTC) Received: by mail-ia0-f180.google.com with SMTP id f6so325143iag.11 for ; Tue, 06 Nov 2012 07:16:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:mime-version:content-type :x-gm-message-state; bh=Vcx/HNU+LZUxpMfR3+kglbOGzI14F+rCpRQ4NQTb45U=; b=Is/yz56ixm5nhAw62lYRdGZYeKOjDJJMfvDnmYyzb9gel/UIqLdSDIs4el3Djy1035 WfUy/4xsSJvkAWe5ymxAlFnXTyxP0rZudIYRcLJ6oBYTwN/79fZTiDOJZekszy+4b5hr YlsF/5jdhpZhAz2GPQl4MK2hz1Kz4S2Re++/IJetIoo9ILxr4Z62Clk2WKjZb6Ic9eVC D0ThKb64o0YQLc16F1IjUiaAjWPqSjc+Tnxu94YEs2heaTGDbZVzIZdjZRoUkUUjw0EK M/Xde0yPONQ4qB41079BVrKYT2UXTcRkH2am96BPapIGakhZYH0FXzkZnCJIEJh7DtiE k3Lw== Received: by 10.50.161.169 with SMTP id xt9mr13079932igb.62.1352215018907; Tue, 06 Nov 2012 07:16:58 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp57921igt; Tue, 6 Nov 2012 07:16:58 -0800 (PST) Received: by 10.14.215.69 with SMTP id d45mr4546078eep.16.1352215017975; Tue, 06 Nov 2012 07:16:57 -0800 (PST) Received: from eu1sys200aog108.obsmtp.com (eu1sys200aog108.obsmtp.com [207.126.144.125]) by mx.google.com with SMTP id m46si12721424eeo.17.2012.11.06.07.16.51 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Nov 2012 07:16:57 -0800 (PST) Received-SPF: neutral (google.com: 207.126.144.125 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) client-ip=207.126.144.125; Authentication-Results: mx.google.com; spf=neutral (google.com: 207.126.144.125 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) smtp.mail=linus.walleij@stericsson.com Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob108.postini.com ([207.126.147.11]) with SMTP ID DSNKUJkp4xX5BwiwzfTB2Ocxl8IZ388YnyTa@postini.com; Tue, 06 Nov 2012 15:16:57 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0BE6E306; Tue, 6 Nov 2012 15:16:49 +0000 (GMT) Received: from relay1.stm.gmessaging.net (unknown [10.230.100.17]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8BCD34961; Tue, 6 Nov 2012 15:16:49 +0000 (GMT) Received: from exdcvycastm022.EQ1STM.local (alteon-source-exch [10.230.100.61]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "exdcvycastm022", Issuer "exdcvycastm022" (not verified)) by relay1.stm.gmessaging.net (Postfix) with ESMTPS id A541324C2F0; Tue, 6 Nov 2012 16:16:41 +0100 (CET) Received: from steludxu4075.lud.stericsson.com (10.230.100.153) by smtp.stericsson.com (10.230.100.30) with Microsoft SMTP Server (TLS) id 8.3.83.0; Tue, 6 Nov 2012 16:16:48 +0100 From: Linus Walleij To: , , Shiraz Hashim , Viresh Kumar Cc: Stephen Warren , Anmar Oueja , Grant Likely , Linus Walleij Subject: [PATCH 2/5] gpiolib-of: staticize the pin range calls Date: Tue, 6 Nov 2012 16:16:43 +0100 Message-ID: <1352215003-30268-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.11.3 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQmNbqlFAJo9RXSjDVlGvogg+rzAKG+Bn/vC73MtPd2zBbmKQndjvLX9JQt2RMDErC7h+kUx From: Linus Walleij Commit 69e1601bca88809dc118abd1becb02c15a02ec71 "gpiolib: provide provision to register pin ranges" Declared the of_gpiochip_[add|remove]_pin_range() global while they should be static as they are only ever used in this file. Let's convert them to static. Signed-off-by: Linus Walleij --- drivers/gpio/gpiolib-of.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index a5b90c8..220caa5 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -218,7 +218,7 @@ err0: EXPORT_SYMBOL(of_mm_gpiochip_add); #ifdef CONFIG_PINCTRL -void of_gpiochip_add_pin_range(struct gpio_chip *chip) +static void of_gpiochip_add_pin_range(struct gpio_chip *chip) { struct device_node *np = chip->of_node; struct gpio_pin_range *pin_range; @@ -254,7 +254,7 @@ void of_gpiochip_add_pin_range(struct gpio_chip *chip) } while (index++); } -void of_gpiochip_remove_pin_range(struct gpio_chip *chip) +static void of_gpiochip_remove_pin_range(struct gpio_chip *chip) { struct gpio_pin_range *pin_range, *tmp; @@ -265,8 +265,8 @@ void of_gpiochip_remove_pin_range(struct gpio_chip *chip) } } #else -void of_gpiochip_add_pin_range(struct gpio_chip *chip) {} -void of_gpiochip_remove_pin_range(struct gpio_chip *chip) {} +static void of_gpiochip_add_pin_range(struct gpio_chip *chip) {} +static void of_gpiochip_remove_pin_range(struct gpio_chip *chip) {} #endif void of_gpiochip_add(struct gpio_chip *chip)