From patchwork Wed Nov 21 05:06:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13020 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5CEDA23EFB for ; Wed, 21 Nov 2012 05:12:28 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id D3F0BA181C4 for ; Wed, 21 Nov 2012 05:12:27 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so9365471iej.11 for ; Tue, 20 Nov 2012 21:12:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=+mVeOrxhoqmTGqT0SS58itdyBge+Ir50E2hjdU30a9U=; b=Gw72R0zXxSeEa8S9lDm12Y6kA8HaTqqwxrNvCl30Mob38esUZKd8U7rsRZwYi+5dQy WaFQIJweR90ivOT+XPyuM5Aq/yoAYp/tt20BjYzgITApezALjaiknlYW2+vrSNYZcxq3 j2i8YYGhaqVxX9SkOtM+hS8BUfHiulVu03rrUgJwlExYOF1KEix/g/KqyvOwE6Hkb6wI pkF3fBK7/QYz2jfYUOJ0oyjsTPnz9bZmP2WjTgDDPlMC4aF2QGQsj6TKfadb02WXzAPB u2AylL+n4Uikv4vMHFPi+LpufB70TsU231vb6E23xJvpWhK3xOwZnl/w2E1L77yEswp3 QR2g== Received: by 10.43.7.132 with SMTP id oo4mr16207071icb.6.1353474747192; Tue, 20 Nov 2012 21:12:27 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp434184igt; Tue, 20 Nov 2012 21:12:26 -0800 (PST) Received: by 10.66.78.199 with SMTP id d7mr14654162pax.77.1353474746207; Tue, 20 Nov 2012 21:12:26 -0800 (PST) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx.google.com with ESMTPS id u7si20840818paz.153.2012.11.20.21.12.25 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Nov 2012 21:12:26 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.54 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.54; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.54 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f54.google.com with SMTP id wz12so6000458pbc.27 for ; Tue, 20 Nov 2012 21:12:25 -0800 (PST) Received: by 10.66.87.202 with SMTP id ba10mr14612678pab.72.1353474745881; Tue, 20 Nov 2012 21:12:25 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id us7sm9265014pbc.40.2012.11.20.21.12.22 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Nov 2012 21:12:25 -0800 (PST) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/2] PM/devfreq: Fix incorrect argument in error message Date: Wed, 21 Nov 2012 10:36:13 +0530 Message-Id: <1353474374-21591-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQkNtqJzTju/lgxCUOihKxTIoMPGruQvuvgYs457T0QAeKFsSmqcEDg5djS42argDzcCiYcA 'g' is cast to the error return code. Hence gives the following error which is fixed by this patch. drivers/devfreq/devfreq.c:645 devfreq_remove_governor() error: 'g' dereferencing possible ERR_PTR() Signed-off-by: Sachin Kamat --- drivers/devfreq/devfreq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 45e053e..83c2129 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -643,7 +643,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor) g = find_devfreq_governor(governor->name); if (IS_ERR(g)) { pr_err("%s: governor %s not registered\n", __func__, - g->name); + governor->name); err = -EINVAL; goto err_out; }