From patchwork Wed Jan 30 19:40:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 14370 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 67EB223EAD for ; Wed, 30 Jan 2013 19:40:22 +0000 (UTC) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by fiordland.canonical.com (Postfix) with ESMTP id 181D5A19350 for ; Wed, 30 Jan 2013 19:40:22 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id n11so1247838vch.33 for ; Wed, 30 Jan 2013 11:40:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :mime-version:content-type:x-gm-message-state; bh=34N2uFvvYDQEe8DeNwJnOn3VlEs1HmvdYPcFQVhfLwk=; b=Ay/idEQD7+Hcd1AYKGKn5TeqsZIOhGVFutNQxpePZt5I3j0E10lluEBN/c3dvEIia1 lvqxV/rLIFB9VwsBu5paQktmeNP64ZD349szmqzvsZw9ggahTkhh9DGcIVHDdG+ELvfr ZylcdreVF4KqCrimalSVa2oSNsdRp2K0HnRUQcEgd8FeYfm24YvfCP8Si/NFXO7iql7I IKC5/j1T/Uu31LEJ45X2jO26gB02CvadvEmbDEACKg6bQ1D+h4e5NHat+BnlWzyElAqX vgz7v5PWAYfJYR//pyQJC3NvuQ2GkB067dIdjXMj8ayzIuO9BKbvrJfFJBZh7O+poCna 9DbQ== X-Received: by 10.220.219.77 with SMTP id ht13mr5756275vcb.66.1359574821580; Wed, 30 Jan 2013 11:40:21 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.252.8 with SMTP id zo8csp26282vec; Wed, 30 Jan 2013 11:40:20 -0800 (PST) X-Received: by 10.14.176.66 with SMTP id a42mr17981796eem.34.1359574820441; Wed, 30 Jan 2013 11:40:20 -0800 (PST) Received: from eu1sys200aog108.obsmtp.com (eu1sys200aog108.obsmtp.com [207.126.144.125]) by mx.google.com with SMTP id h41si4110279eem.230.2013.01.30.11.40.14 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 30 Jan 2013 11:40:20 -0800 (PST) Received-SPF: neutral (google.com: 207.126.144.125 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) client-ip=207.126.144.125; Authentication-Results: mx.google.com; spf=neutral (google.com: 207.126.144.125 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) smtp.mail=linus.walleij@stericsson.com Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob108.postini.com ([207.126.147.11]) with SMTP ID DSNKUQl3HnFRrX2l1z/z6BlZzc5S4K2FNdHv@postini.com; Wed, 30 Jan 2013 19:40:20 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4F178EF; Wed, 30 Jan 2013 19:40:11 +0000 (GMT) Received: from relay2.stm.gmessaging.net (unknown [10.230.100.18]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EA2595994; Wed, 30 Jan 2013 19:40:10 +0000 (GMT) Received: from exdcvycastm022.EQ1STM.local (alteon-source-exch [10.230.100.61]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "exdcvycastm022", Issuer "exdcvycastm022" (not verified)) by relay2.stm.gmessaging.net (Postfix) with ESMTPS id 29E18A807E; Wed, 30 Jan 2013 20:40:03 +0100 (CET) Received: from steludxu4075.lud.stericsson.com (10.230.100.153) by smtp.stericsson.com (10.230.100.30) with Microsoft SMTP Server (TLS) id 8.3.83.0; Wed, 30 Jan 2013 20:40:10 +0100 From: Linus Walleij To: , Cc: Stephen Warren , Anmar Oueja , Lee Jones , Linus Walleij Subject: [PATCH 2/4] pinctrl/abx500: replace incorrect return value Date: Wed, 30 Jan 2013 20:40:06 +0100 Message-ID: <1359574806-15661-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.11.3 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQkDszA3Thvq8tJo0+UrLnCSdTR3Ow6SZf/FjxVT3vWCg32NRa3+n5r2OpRojDGYckwidDeF From: Lee Jones Currently in the empty abx500_pin_config_get() function, we're returning -EINVAL, with a comment stating that the reason for the failure is that the function isn't implemented yet. Well there's a proper return code for that. If we use it, we can do away with the comment too, as it would be implied. Signed-off-by: Lee Jones Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-abx500.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c index 539c9bb..305a9cb 100644 --- a/drivers/pinctrl/pinctrl-abx500.c +++ b/drivers/pinctrl/pinctrl-abx500.c @@ -971,8 +971,7 @@ int abx500_pin_config_get(struct pinctrl_dev *pctldev, unsigned pin, unsigned long *config) { - /* Not implemented */ - return -EINVAL; + return -ENOSYS; } int abx500_pin_config_set(struct pinctrl_dev *pctldev,