From patchwork Thu Feb 28 09:07:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 15139 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 86DB823E0D for ; Thu, 28 Feb 2013 09:10:49 +0000 (UTC) Received: from mail-vb0-f41.google.com (mail-vb0-f41.google.com [209.85.212.41]) by fiordland.canonical.com (Postfix) with ESMTP id 0E79FA19484 for ; Thu, 28 Feb 2013 09:10:48 +0000 (UTC) Received: by mail-vb0-f41.google.com with SMTP id l22so153159vbn.14 for ; Thu, 28 Feb 2013 01:10:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :mime-version:content-type:x-gm-message-state; bh=lkuiMJwMgOhw2h1lYF40FXzdE1WT78xhsASSKKrAXkM=; b=KSsBR8G0nm0zg82PMtC2kIjgabP1AFI8bRhKmc3jxjEIKUiALAm8hsgICJegOMHAcf 8PrRCB1ngsWwEuK5c4H6LOwuybAfPOfe4GAZ9FEDdXHn0zjtZjtpSNFxmjHzWxxygPwf jr1i2k5aWIdlPvztYwT6oiOeTeyaXkW3ulLtMkRrN0BI5I0klmSUMsJ96PMMUCw7p7Pj HZK5iwJbB4zot5i0+evO3Zh/IMpRcdmEX0uWqe5tLk7fiUNk/zAsjw5PMhJRQzKbE+an +F6DHDIhk4WJbwlX/ialD57FMh+Jc3sPmNrPdIPVPFqTWHUS97ytMRLLPRMv/RpvxeVW QXqQ== X-Received: by 10.220.39.69 with SMTP id f5mr2239206vce.45.1362042648437; Thu, 28 Feb 2013 01:10:48 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp214825veb; Thu, 28 Feb 2013 01:10:47 -0800 (PST) X-Received: by 10.14.202.71 with SMTP id c47mr817825eeo.39.1362042646787; Thu, 28 Feb 2013 01:10:46 -0800 (PST) Received: from eu1sys200aog105.obsmtp.com (eu1sys200aog105.obsmtp.com [207.126.144.119]) by mx.google.com with SMTP id f5si11826188eev.1.2013.02.28.01.10.38 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 Feb 2013 01:10:46 -0800 (PST) Received-SPF: neutral (google.com: 207.126.144.119 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) client-ip=207.126.144.119; Authentication-Results: mx.google.com; spf=neutral (google.com: 207.126.144.119 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) smtp.mail=linus.walleij@stericsson.com Received: from beta.dmz-us.st.com ([167.4.1.35]) (using TLSv1) by eu1sys200aob105.postini.com ([207.126.147.11]) with SMTP ID DSNKUS8fDOOs/bONAh3EyHz44tYXi/bQVYCk@postini.com; Thu, 28 Feb 2013 09:10:46 UTC Received: from zeta.dmz-us.st.com (ns4.st.com [167.4.16.71]) by beta.dmz-us.st.com (STMicroelectronics) with ESMTP id 8DE5F49; Thu, 28 Feb 2013 09:09:28 +0000 (GMT) Received: from relay2.stm.gmessaging.net (unknown [10.230.100.18]) by zeta.dmz-us.st.com (STMicroelectronics) with ESMTP id 70B0E3F; Thu, 28 Feb 2013 02:59:55 +0000 (GMT) Received: from exdcvycastm022.EQ1STM.local (alteon-source-exch [10.230.100.61]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "exdcvycastm022", Issuer "exdcvycastm022" (not verified)) by relay2.stm.gmessaging.net (Postfix) with ESMTPS id 6367CA80A2; Thu, 28 Feb 2013 10:10:13 +0100 (CET) Received: from steludxu4075.lud.stericsson.com (10.230.100.153) by smtp.stericsson.com (10.230.100.30) with Microsoft SMTP Server (TLS) id 8.3.83.0; Thu, 28 Feb 2013 10:09:39 +0100 From: Linus Walleij To: , Grant Likely , Rob Herring , Thomas Gleixner Cc: Anmar Oueja , Linus Walleij Subject: [PATCH] irqdomain: document the simple domain first_irq Date: Thu, 28 Feb 2013 10:07:18 +0100 Message-ID: <1362042438-13887-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.11.3 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQmmG/u+EBQ0Y0Ga+dOvjnK238DlMBdBkpn49gc89DI8KXas8IPjR+na1IxoFPzaYyUG5Io+ From: Linus Walleij The first_irq needs to be zero to get a linear domain and that comes with special semantics. We want to simplify this going forward but some documentation never hurts. Signed-off-by: Linus Walleij --- kernel/irq/irqdomain.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 96f3a1d..059a280 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -143,7 +143,10 @@ static unsigned int irq_domain_legacy_revmap(struct irq_domain *domain, * irq_domain_add_simple() - Allocate and register a simple irq_domain. * @of_node: pointer to interrupt controller's device tree node. * @size: total number of irqs in mapping - * @first_irq: first number of irq block assigned to the domain + * @first_irq: first number of irq block assigned to the domain, + * pass zero to assign irqs on-the-fly. This will result in a + * linear IRQ domain so it is important to use irq_create_mapping() + * for each used IRQ, especially when SPARSE_IRQ is enabled. * @ops: map/unmap domain callbacks * @host_data: Controller private data pointer *