From patchwork Tue Mar 19 06:31:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15416 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id B992B23E2C for ; Tue, 19 Mar 2013 06:42:28 +0000 (UTC) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by fiordland.canonical.com (Postfix) with ESMTP id 5BB1AA18C11 for ; Tue, 19 Mar 2013 06:42:28 +0000 (UTC) Received: by mail-ve0-f182.google.com with SMTP id ox1so107865veb.13 for ; Mon, 18 Mar 2013 23:42:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=ssumR1rtbLwWSw71m5NbZQuQVWkBLy0QvWVKf4azu6g=; b=clc2SOIymgksJ+1HGXSrPOIugELCEeId65AKUunVr9fXZpJnV8kwCfyYZaWeWsZWUM w8rxvNYNx8OIiDNuEWn/q2f160wkVi8o3OOZ8x6n//s4/Dt73dtuJmszd/tpr3RoHomN ZhJ79JEGYW4792ErmBgr50ZDuwqZIzaBxNtna3H0lKXVdwaT4FLHKxBhuoHNM0UkAJPs 7tWG40ZubNyYlbc3FC2D9ZCDUjTiGYs4zEVSfz0nsGMOx8c/7njqCC46lVcSYakHM3uv mTOr+RTZTCLlM48dNPEMeRlLk027bHU7twVygWtDuuPP6bz1chmSI1+RhMyuCCoo6F4y VhWw== X-Received: by 10.52.29.18 with SMTP id f18mr761981vdh.57.1363675347803; Mon, 18 Mar 2013 23:42:27 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp78679veb; Mon, 18 Mar 2013 23:42:26 -0700 (PDT) X-Received: by 10.66.228.74 with SMTP id sg10mr1599441pac.48.1363675346182; Mon, 18 Mar 2013 23:42:26 -0700 (PDT) Received: from mail-pb0-f47.google.com (mail-pb0-f47.google.com [209.85.160.47]) by mx.google.com with ESMTPS id pc5si10229312pac.255.2013.03.18.23.42.24 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Mar 2013 23:42:26 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.47 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.47; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.47 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f47.google.com with SMTP id rp2so161916pbb.6 for ; Mon, 18 Mar 2013 23:42:24 -0700 (PDT) X-Received: by 10.68.228.199 with SMTP id sk7mr1392796pbc.40.1363675344407; Mon, 18 Mar 2013 23:42:24 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ab1sm23076074pbd.37.2013.03.18.23.42.21 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 18 Mar 2013 23:42:23 -0700 (PDT) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, sachin.kamat@linaro.org, patches@linaro.org, Patrice Chotard Subject: [PATCH 1/5] pinctrl: abx500: Staticize some symbols Date: Tue, 19 Mar 2013 12:01:17 +0530 Message-Id: <1363674681-4015-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnnEETWibYJYaKSPHGdYLjoeAA9VACudIvhrH+G6JvGIhVnGsmpYz7elodAa5Rm4HlS/Czh These symbols are used only in this file. Without this patch we get the following warnings: drivers/pinctrl/pinctrl-abx500.c:520:5: warning: symbol 'abx500_gpio_request' was not declared. Should it be static? drivers/pinctrl/pinctrl-abx500.c:527:6: warning: symbol 'abx500_gpio_free' was not declared. Should it be static? drivers/pinctrl/pinctrl-abx500.c:614:5: warning: symbol 'abx500_gpio_request_enable' was not declared. Should it be static? drivers/pinctrl/pinctrl-abx500.c:714:5: warning: symbol 'abx500_pin_config_get' was not declared. Should it be static? drivers/pinctrl/pinctrl-abx500.c:721:5: warning: symbol 'abx500_pin_config_set' was not declared. Should it be static? Signed-off-by: Sachin Kamat Cc: Patrice Chotard Acked-by: Patrice Chotard --- This series is compile tested against linux-next tree (20130319). --- drivers/pinctrl/pinctrl-abx500.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c index 0cf3fa4..9b8db91 100644 --- a/drivers/pinctrl/pinctrl-abx500.c +++ b/drivers/pinctrl/pinctrl-abx500.c @@ -517,14 +517,14 @@ static inline void abx500_gpio_dbg_show_one(struct seq_file *s, #define abx500_gpio_dbg_show NULL #endif -int abx500_gpio_request(struct gpio_chip *chip, unsigned offset) +static int abx500_gpio_request(struct gpio_chip *chip, unsigned offset) { int gpio = chip->base + offset; return pinctrl_request_gpio(gpio); } -void abx500_gpio_free(struct gpio_chip *chip, unsigned offset) +static void abx500_gpio_free(struct gpio_chip *chip, unsigned offset) { int gpio = chip->base + offset; @@ -611,7 +611,7 @@ static void abx500_pmx_disable(struct pinctrl_dev *pctldev, dev_dbg(pct->dev, "disable group %s, %u pins\n", g->name, g->npins); } -int abx500_gpio_request_enable(struct pinctrl_dev *pctldev, +static int abx500_gpio_request_enable(struct pinctrl_dev *pctldev, struct pinctrl_gpio_range *range, unsigned offset) { @@ -711,14 +711,14 @@ static const struct pinctrl_ops abx500_pinctrl_ops = { .pin_dbg_show = abx500_pin_dbg_show, }; -int abx500_pin_config_get(struct pinctrl_dev *pctldev, +static int abx500_pin_config_get(struct pinctrl_dev *pctldev, unsigned pin, unsigned long *config) { return -ENOSYS; } -int abx500_pin_config_set(struct pinctrl_dev *pctldev, +static int abx500_pin_config_set(struct pinctrl_dev *pctldev, unsigned pin, unsigned long config) {