From patchwork Wed Mar 27 11:23:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15698 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4881D23E3E for ; Wed, 27 Mar 2013 11:34:59 +0000 (UTC) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by fiordland.canonical.com (Postfix) with ESMTP id 03213A181C6 for ; Wed, 27 Mar 2013 11:34:58 +0000 (UTC) Received: by mail-ve0-f181.google.com with SMTP id pa12so5079938veb.26 for ; Wed, 27 Mar 2013 04:34:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=lDmg84/knm5HuQSTSGem0iFKOVWoiSoQnkh3FX06+dk=; b=kt9qqcqOrUwTNxCk6Skb2hL7/G0PXFzb00cffMlt6Qg8YNHH3DpNUlgBOR3UGelLtm vaB7kjD1kJWrWUBvNOOmXxtCdU+yTYs+fja0GsLld5W1ofw+e82ox2yIEgFkLpXr6qs5 YCpFBUOCcUW0eGmvlwyYd79dpHyFXmis2+IFlMBjHsxKo2AwQXuCClODXH73a8CQ6QY9 pww2lNmrUrgpJHHmBQkwJunHDIVZ4ebvsTLAsQBMjc/Lo9Gg6ZQmeGEVCd4PRw+/fKJz A6vNrt1AC21Vq07LvvhxdiuLeKMoDFQfBQ8HHYce2ZLO1Q9KR3j5D3ETBBxW1a5oOLS3 nfBQ== X-Received: by 10.220.225.200 with SMTP id it8mr22622862vcb.39.1364384098486; Wed, 27 Mar 2013 04:34:58 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.59.4.204 with SMTP id cg12csp111633ved; Wed, 27 Mar 2013 04:34:57 -0700 (PDT) X-Received: by 10.66.157.195 with SMTP id wo3mr29209879pab.79.1364384097527; Wed, 27 Mar 2013 04:34:57 -0700 (PDT) Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by mx.google.com with ESMTPS id lq8si21965440pab.229.2013.03.27.04.34.57 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 27 Mar 2013 04:34:57 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.192.178 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.192.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.192.178 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pd0-f178.google.com with SMTP id u10so3520785pdi.37 for ; Wed, 27 Mar 2013 04:34:57 -0700 (PDT) X-Received: by 10.66.123.105 with SMTP id lz9mr29664918pab.137.1364384096965; Wed, 27 Mar 2013 04:34:56 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id to7sm8093507pab.0.2013.03.27.04.34.54 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 27 Mar 2013 04:34:56 -0700 (PDT) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/2] extcon: max8997: Fix return value Date: Wed, 27 Mar 2013 16:53:30 +0530 Message-Id: <1364383410-15093-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1364383410-15093-1-git-send-email-sachin.kamat@linaro.org> References: <1364383410-15093-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkroyR1AEz0PiqIF0YXXtjzQIcZbzhNLYb+Ohpp2wJwpS9Zg1rJI1bEp+vDUAMFXE5pnlnR Return the value obtained from the function instead of hardcoding. drivers/extcon/extcon-max8997.c:235 max8997_muic_set_path() info: why not propagate 'ret' from max8997_update_reg() instead of (-11)? drivers/extcon/extcon-max8997.c:248 max8997_muic_set_path() info: why not propagate 'ret' from max8997_update_reg() instead of (-11)? Signed-off-by: Sachin Kamat --- drivers/extcon/extcon-max8997.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c index 69641bc..05b76b3 100644 --- a/drivers/extcon/extcon-max8997.c +++ b/drivers/extcon/extcon-max8997.c @@ -232,7 +232,7 @@ static int max8997_muic_set_path(struct max8997_muic_info *info, MAX8997_MUIC_REG_CONTROL1, ctrl1, COMP_SW_MASK); if (ret < 0) { dev_err(info->dev, "failed to update MUIC register\n"); - return -EAGAIN; + return ret; } if (attached) @@ -245,7 +245,7 @@ static int max8997_muic_set_path(struct max8997_muic_info *info, CONTROL2_LOWPWR_MASK | CONTROL2_CPEN_MASK); if (ret < 0) { dev_err(info->dev, "failed to update MUIC register\n"); - return -EAGAIN; + return ret; } dev_info(info->dev,