From patchwork Mon Jul 22 23:45:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 18521 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qe0-f69.google.com (mail-qe0-f69.google.com [209.85.128.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9F32B25E1F for ; Mon, 22 Jul 2013 23:45:50 +0000 (UTC) Received: by mail-qe0-f69.google.com with SMTP id a11sf9625384qen.4 for ; Mon, 22 Jul 2013 16:45:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-beenthere:x-forwarded-to:x-forwarded-for :delivered-to:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=X31n53AMc6tBBBxfyKlXCvcSDGsWmAAjSzlLHC77LRo=; b=mPlwdtAfIS/vPq4V16kH/E0+SAgY+1Fg7oTt7uGuCePwj+LVHhJgQJGGQ6492mBa60 gZ4cZMk8JMONp6R6SU4G8SkA4Tcod3asefTd8ZRjvAJAxGarlBw9paeLI3/9DcJNMkrg 6BlqG4AWZ4pHT1By3L4Gc+WeAGbYvL42XspYXckOR9fNadT6t4obbTmom2DkiyF6rhfF 4afkAO5Zo5iyqYDb33CzYJyQggT+Di9gZ2XZlEtouev9tRSX98Ws73gY5t2KM8WnomOG d52oDmaEE1Grok37ESyN14Yv3a3NPemn/ZBlLjln4RHndx9fI0Xda1fW9PNSzKAGDkw6 wTfA== X-Received: by 10.236.206.105 with SMTP id k69mr17024888yho.8.1374536749775; Mon, 22 Jul 2013 16:45:49 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.15.131 with SMTP id x3ls2756798qec.76.gmail; Mon, 22 Jul 2013 16:45:49 -0700 (PDT) X-Received: by 10.52.90.244 with SMTP id bz20mr3711757vdb.69.1374536749577; Mon, 22 Jul 2013 16:45:49 -0700 (PDT) Received: from mail-vb0-f51.google.com (mail-vb0-f51.google.com [209.85.212.51]) by mx.google.com with ESMTPS id f5si7599222vcy.120.2013.07.22.16.45.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 22 Jul 2013 16:45:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.51 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.51; Received: by mail-vb0-f51.google.com with SMTP id x17so5007398vbf.24 for ; Mon, 22 Jul 2013 16:45:49 -0700 (PDT) X-Received: by 10.52.35.109 with SMTP id g13mr8448214vdj.21.1374536749110; Mon, 22 Jul 2013 16:45:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.165.8 with SMTP id yu8csp78195veb; Mon, 22 Jul 2013 16:45:48 -0700 (PDT) X-Received: by 10.152.88.105 with SMTP id bf9mr13519726lab.38.1374536747735; Mon, 22 Jul 2013 16:45:47 -0700 (PDT) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) by mx.google.com with ESMTPS id j10si12835848laj.83.2013.07.22.16.45.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 22 Jul 2013 16:45:47 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.217.169 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=209.85.217.169; Received: by mail-lb0-f169.google.com with SMTP id d10so5810954lbj.28 for ; Mon, 22 Jul 2013 16:45:47 -0700 (PDT) X-Received: by 10.112.55.104 with SMTP id r8mr13097566lbp.49.1374536747043; Mon, 22 Jul 2013 16:45:47 -0700 (PDT) Received: from localhost.localdomain (c83-249-208-126.bredband.comhem.se. [83.249.208.126]) by mx.google.com with ESMTPSA id w9sm11733409lbd.9.2013.07.22.16.45.45 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 22 Jul 2013 16:45:46 -0700 (PDT) From: Linus Walleij To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stephen Warren , xulinuxkernel , Linus Walleij Subject: [PATCH] pinctrl: fix a memleak when freeing maps Date: Tue, 23 Jul 2013 01:45:39 +0200 Message-Id: <1374536739-18966-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.1.4 X-Gm-Message-State: ALoCoQlODsix27nzHU9nABrQmRRMfpSorog0asctnWxm2mlMExHHjrYsRZ4zT92CRozTUM772/sE X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.51 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We forgot to free the node itself when free:ing a map. Reported-by: xulinuxkernel Signed-off-by: Linus Walleij --- drivers/pinctrl/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 5b272bf..2a00239 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1193,6 +1193,7 @@ void pinctrl_unregister_map(struct pinctrl_map const *map) list_for_each_entry(maps_node, &pinctrl_maps, node) { if (maps_node->maps == map) { list_del(&maps_node->node); + kfree(maps_node); mutex_unlock(&pinctrl_maps_mutex); return; }