From patchwork Thu Oct 31 11:08:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 21300 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f200.google.com (mail-ie0-f200.google.com [209.85.223.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8DE9D20F2F for ; Thu, 31 Oct 2013 11:09:40 +0000 (UTC) Received: by mail-ie0-f200.google.com with SMTP id aq17sf7718288iec.11 for ; Thu, 31 Oct 2013 04:09:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=V3ZqtTtR9u0LDKYh+wNgoazQqCcKCwxJffvXBKL6TlU=; b=aE51Os8Fay27WmT9EDY4q/4fnAWAbRCCwNMRIwv2dB/ZukiWkF5usvDrkJIrx6T00T F2F50YDv20Fwvu3hEjtkgbY9Ld9YAXYeE+23z5i5j0SOm9SYfUfZVXl/rTEjY7rFSN5u rXJH+cCqguYWKa0+m5LDykQglOIeeASbZd0TRA20UIta0K50Np6mqv0AlLnUpa/Njyb4 ORf4i+j34InljlK6a8T22PnBCvKW6s7cAXZUT1YWzo3QbdAKR65Hzaq630+reXHQiuFA IxBNSTq8/gVCBmwn9iVKwv2AwYnMrhv6it9ykr4NUzNINSnOX8KTBUWR5qzWXVmWwCNH ftNQ== X-Gm-Message-State: ALoCoQnQLMez0MP+8GzXQvxUcdH9keqhgjqq4UCfEfK7L6cd0VTnnPwJ6Y3zv9Yt7ZJw80UEXPiv X-Received: by 10.182.87.2 with SMTP id t2mr890746obz.2.1383217780253; Thu, 31 Oct 2013 04:09:40 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.131.7 with SMTP id oi7ls868578qeb.92.gmail; Thu, 31 Oct 2013 04:09:40 -0700 (PDT) X-Received: by 10.220.58.1 with SMTP id e1mr1526908vch.0.1383217780115; Thu, 31 Oct 2013 04:09:40 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id s5si662572vev.79.2013.10.31.04.09.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 31 Oct 2013 04:09:40 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id jz11so1918387veb.40 for ; Thu, 31 Oct 2013 04:09:40 -0700 (PDT) X-Received: by 10.58.207.76 with SMTP id lu12mr1525731vec.30.1383217780034; Thu, 31 Oct 2013 04:09:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp352566vcz; Thu, 31 Oct 2013 04:09:39 -0700 (PDT) X-Received: by 10.68.224.38 with SMTP id qz6mr1257887pbc.156.1383217779303; Thu, 31 Oct 2013 04:09:39 -0700 (PDT) Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by mx.google.com with ESMTPS id fk10si1894833pab.87.2013.10.31.04.09.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 31 Oct 2013 04:09:39 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.192.174 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) client-ip=209.85.192.174; Received: by mail-pd0-f174.google.com with SMTP id z10so2263847pdj.33 for ; Thu, 31 Oct 2013 04:09:38 -0700 (PDT) X-Received: by 10.68.203.164 with SMTP id kr4mr1346667pbc.48.1383217778858; Thu, 31 Oct 2013 04:09:38 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id hz10sm3446333pbc.36.2013.10.31.04.09.36 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 31 Oct 2013 04:09:38 -0700 (PDT) From: Tushar Behera To: linux-kernel@vger.kernel.org Cc: patches@linaro.org, dri-devel@lists.freedesktop.org, Russell King , David Airlie Subject: [PATCH 2/5] DRM: Armada: Use devm_ioremap_resource Date: Thu, 31 Oct 2013 16:38:04 +0530 Message-Id: <1383217687-12037-3-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1383217687-12037-1-git-send-email-tushar.behera@linaro.org> References: <1383217687-12037-1-git-send-email-tushar.behera@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tushar.behera@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , While at it, propagate the error code. Signed-off-by: Tushar Behera CC: dri-devel@lists.freedesktop.org CC: Russell King CC: David Airlie --- drivers/gpu/drm/armada/armada_crtc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c index d8e3982..2b6e7b7 100644 --- a/drivers/gpu/drm/armada/armada_crtc.c +++ b/drivers/gpu/drm/armada/armada_crtc.c @@ -1037,11 +1037,9 @@ int armada_drm_crtc_create(struct drm_device *dev, unsigned num, if (ret) return ret; - base = devm_request_and_ioremap(dev->dev, res); - if (!base) { - DRM_ERROR("failed to ioremap register\n"); - return -ENOMEM; - } + base = devm_ioremap_resource(dev->dev, res); + if (IS_ERR(base)) + return PTR_ERR(base); dcrtc = kzalloc(sizeof(*dcrtc), GFP_KERNEL); if (!dcrtc) {