From patchwork Mon Nov 25 14:45:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 21744 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qe0-f71.google.com (mail-qe0-f71.google.com [209.85.128.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7906F20DF3 for ; Mon, 25 Nov 2013 14:45:13 +0000 (UTC) Received: by mail-qe0-f71.google.com with SMTP id b10sf3337221qen.10 for ; Mon, 25 Nov 2013 06:45:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=7pQ5FZUPkVIHiiHpnbmo9A6E9+gRH1GQeQcqzcK9HyY=; b=GCJth3hgemJdZ20/8BXyFUqUZhfHAOntcsIIUQz8RnaNYUShHrzloIrwjDh7Jup3n9 ROOyx2KPrYgj+tB95oqTxCrvL0pSXhP7+bnVDGs0IyCR20dDmIq2qyH6w9nPvxoC2pTY FpFUM0taGidaH1FkvqRwFRDCkFDm8F8ZCOlxeAWccm4TkQWCwmnt8FgdMdBs5cJ+An9J y2TAHuC9DUFCKhzB8kK1Sb+l5V4e7AQLd225pR7GD3gZsDmtljwsET3ClemqH3WGA/2m 2swQ0x+f6J16M6IPRvmCUPsys/akHpLQ9i4UEKu48JJA3821A+HRGKtKI69p+gpWuCCS odmg== X-Gm-Message-State: ALoCoQmkhsCwO9m3EAVVtTf80hYRMTmsm+QRAvt6O9txWwpSsydFxJLDw4NS8CLkdiJ5/lnELt9/ X-Received: by 10.52.76.34 with SMTP id h2mr7938373vdw.2.1385390712582; Mon, 25 Nov 2013 06:45:12 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.35.111 with SMTP id g15ls2134088qej.21.gmail; Mon, 25 Nov 2013 06:45:12 -0800 (PST) X-Received: by 10.52.170.232 with SMTP id ap8mr322092vdc.40.1385390712405; Mon, 25 Nov 2013 06:45:12 -0800 (PST) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id o3si17961796ves.48.2013.11.25.06.45.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Nov 2013 06:45:12 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id lh4so2768267vcb.23 for ; Mon, 25 Nov 2013 06:45:12 -0800 (PST) X-Received: by 10.52.119.228 with SMTP id kx4mr22578664vdb.12.1385390712290; Mon, 25 Nov 2013 06:45:12 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp138290vcz; Mon, 25 Nov 2013 06:45:11 -0800 (PST) X-Received: by 10.180.210.130 with SMTP id mu2mr14068655wic.61.1385390711419; Mon, 25 Nov 2013 06:45:11 -0800 (PST) Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by mx.google.com with ESMTPS id nj8si7286590wic.73.2013.11.25.06.45.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Nov 2013 06:45:11 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.173 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=209.85.212.173; Received: by mail-wi0-f173.google.com with SMTP id hm4so3668280wib.6 for ; Mon, 25 Nov 2013 06:45:11 -0800 (PST) X-Received: by 10.180.101.197 with SMTP id fi5mr14029573wib.46.1385390710878; Mon, 25 Nov 2013 06:45:10 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id w1sm14958187wib.6.2013.11.25.06.45.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2013 06:45:10 -0800 (PST) From: Linus Walleij To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stephen Warren , Linus Walleij , Tomasz Figa , Kyungmin Park Subject: [PATCH] pinctrl: provide documentation pointer Date: Mon, 25 Nov 2013 15:45:06 +0100 Message-Id: <1385390706-28722-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The PIN_CONFIG_OUTPUT parameter is really tricky to understand and needs an explicit pointer to the documentation. Cc: Tomasz Figa Cc: Kyungmin Park Signed-off-by: Linus Walleij --- include/linux/pinctrl/pinconf-generic.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h index fb90ef5eb038..4b1432548e9e 100644 --- a/include/linux/pinctrl/pinconf-generic.h +++ b/include/linux/pinctrl/pinconf-generic.h @@ -83,7 +83,9 @@ * passed in the argument on a custom form, else just use argument 1 * to indicate low power mode, argument 0 turns low power mode off. * @PIN_CONFIG_OUTPUT: this will configure the pin in output, use argument - * 1 to indicate high level, argument 0 to indicate low level. + * 1 to indicate high level, argument 0 to indicate low level. (Please + * Documentation/pinctrl.txt, section "GPIO mode pitfalls" for a + * discussion around this parameter.) * @PIN_CONFIG_END: this is the last enumerator for pin configurations, if * you need to pass in custom configurations to the pin controller, use * PIN_CONFIG_END+1 as the base offset.