From patchwork Sat Dec 14 20:06:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 22487 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f197.google.com (mail-ob0-f197.google.com [209.85.214.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2155D23908 for ; Sat, 14 Dec 2013 20:06:59 +0000 (UTC) Received: by mail-ob0-f197.google.com with SMTP id vb8sf11826595obc.0 for ; Sat, 14 Dec 2013 12:06:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=o7c+SKk1qo5vs7nLnaPRP/WaM14EH29UTH9ai8zwnNQ=; b=IfO1Xl6M7NgukujJhUcYdPJC4et2rTE/7M4TjYGt24c+HhcHvi+15S9jpoo6cl3FRs 9PyEPKQamLw4kk68IPakMbK5EYMJbSad9lsSBMaLWAAxIenFAzabC0NGpZH6vQZ/7vPt orBi/bH6Ys+WaBHpr5+zvADEKandYtDRqzF0uzp54EXk2TYIBA4MM/1F4hrrBdLi+5Ot lFBGuYpSLW+XJh6bcCGYFlCwmirfjHlFXGW3jucjQtSg1vVWHrX3wuYJt7ZAVUN9C8rE Q0yYkAn4a1I9XndZfoGMoAp/+pwUIPrJ86Q/LzK7psotDyGKKlvQP/xLdViOr2OGoICI 07Eg== X-Gm-Message-State: ALoCoQn+ZH46IWbRCS4miMQcg0jGQwlJE24CQsV3CrUMlYBbO3s09BVP7hA58xGS8oW0KGDu/zNV X-Received: by 10.50.114.66 with SMTP id je2mr3517935igb.5.1387051618916; Sat, 14 Dec 2013 12:06:58 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.58.229 with SMTP id u5ls1442773qeq.69.gmail; Sat, 14 Dec 2013 12:06:58 -0800 (PST) X-Received: by 10.58.37.67 with SMTP id w3mr4728724vej.22.1387051618773; Sat, 14 Dec 2013 12:06:58 -0800 (PST) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id pt3si2289383vec.32.2013.12.14.12.06.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Dec 2013 12:06:58 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id ik5so2191434vcb.2 for ; Sat, 14 Dec 2013 12:06:58 -0800 (PST) X-Received: by 10.58.178.239 with SMTP id db15mr4721319vec.9.1387051618563; Sat, 14 Dec 2013 12:06:58 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp129971vcz; Sat, 14 Dec 2013 12:06:58 -0800 (PST) X-Received: by 10.66.160.2 with SMTP id xg2mr10943158pab.23.1387051617500; Sat, 14 Dec 2013 12:06:57 -0800 (PST) Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by mx.google.com with ESMTPS id sj5si4672826pab.342.2013.12.14.12.06.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Dec 2013 12:06:57 -0800 (PST) Received-SPF: neutral (google.com: 209.85.192.170 is neither permitted nor denied by best guess record for domain of john.stultz@linaro.org) client-ip=209.85.192.170; Received: by mail-pd0-f170.google.com with SMTP id g10so3782403pdj.15 for ; Sat, 14 Dec 2013 12:06:57 -0800 (PST) X-Received: by 10.68.66.103 with SMTP id e7mr11042307pbt.120.1387051616985; Sat, 14 Dec 2013 12:06:56 -0800 (PST) Received: from localhost.localdomain (c-67-170-153-23.hsd1.or.comcast.net. [67.170.153.23]) by mx.google.com with ESMTPSA id hu10sm14370245pbc.11.2013.12.14.12.06.55 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Dec 2013 12:06:56 -0800 (PST) From: John Stultz To: LKML Cc: Greg KH , Android Kernel Team , Sumit Semwal , Jesse Barker , Colin Cross , John Stultz Subject: [PATCH 1/2] ion: Don't allow building ION as a module. Date: Sat, 14 Dec 2013 12:06:45 -0800 Message-Id: <1387051606-10440-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <20131214170618.GA17461@kroah.com> References: <20131214170618.GA17461@kroah.com> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: john.stultz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , ION doesn't export the proper symbols for it to be a module. This causes build issues when ION is configured as a module. Since Andorid kernels rarely use modules (I think recent policy requires no modules?), go ahead and set the ION config to a bool from the tristate option. If folks decide ION as a module is important, we will have to go through and export the various needed symbols. Signed-off-by: John Stultz --- drivers/staging/android/ion/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig index a342d96..b95281e 100644 --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -1,5 +1,5 @@ menuconfig ION - tristate "Ion Memory Manager" + bool "Ion Memory Manager" select GENERIC_ALLOCATOR select DMA_SHARED_BUFFER ---help---