From patchwork Mon Dec 16 21:32:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 22541 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f200.google.com (mail-vc0-f200.google.com [209.85.220.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C9BDF23FF1 for ; Mon, 16 Dec 2013 21:32:55 +0000 (UTC) Received: by mail-vc0-f200.google.com with SMTP id hu19sf9877620vcb.7 for ; Mon, 16 Dec 2013 13:32:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=zk+LMZ5RdLrmCaIOkglczv86TWXVodRxm13PzeM8kqE=; b=meIsMG0vYXQaYwuV71YujvNzhxwQkpB8v4phWtvocDphmxQSS7KvHUTulcEoPOaj4l o0ZCmhkPh/T58kcKFBJVFOjdhuPqPGvKGpr5gPEl3fgrtvYPEP5W1LltRNpIGKu9ItQC pYHVFZWKsGI7ojg/9Mqw+QUyWxfVGEyKMLmsfYpvcEKBQprxgyh7ehzu7nQ5GzxYJRrr EoHn1z6k9lu3WPrDm5S2g7G6swXMz3oA390HhlbOee/tLwgGMW036nT0SflvGL5/QUju ydhXsGVTVSk7McTNsBdgUTM0jHVb+cRi4sCpFiBZfnid6LQPE8Bf6Q6jERVo0x6mTZ0v lR2A== X-Gm-Message-State: ALoCoQlq3dOskMgX1xAhbv2IjV7FTNwXzxWPurjIvyuFnhezs13bj2Epu6DYXwFWYr3c/lxpqnEP X-Received: by 10.236.34.169 with SMTP id s29mr5737690yha.30.1387229574975; Mon, 16 Dec 2013 13:32:54 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.81.229 with SMTP id d5ls2215247qey.64.gmail; Mon, 16 Dec 2013 13:32:54 -0800 (PST) X-Received: by 10.52.98.194 with SMTP id ek2mr7905823vdb.11.1387229574879; Mon, 16 Dec 2013 13:32:54 -0800 (PST) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id tj7si4279163vdc.72.2013.12.16.13.32.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 13:32:54 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id lc6so3540940vcb.41 for ; Mon, 16 Dec 2013 13:32:54 -0800 (PST) X-Received: by 10.52.241.105 with SMTP id wh9mr5894vdc.83.1387229574771; Mon, 16 Dec 2013 13:32:54 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp20313vcz; Mon, 16 Dec 2013 13:32:54 -0800 (PST) X-Received: by 10.68.238.226 with SMTP id vn2mr22151254pbc.50.1387229574002; Mon, 16 Dec 2013 13:32:54 -0800 (PST) Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by mx.google.com with ESMTPS id j8si8372978pad.33.2013.12.16.13.32.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 13:32:53 -0800 (PST) Received-SPF: neutral (google.com: 209.85.192.182 is neither permitted nor denied by best guess record for domain of john.stultz@linaro.org) client-ip=209.85.192.182; Received: by mail-pd0-f182.google.com with SMTP id v10so5930491pde.27 for ; Mon, 16 Dec 2013 13:32:53 -0800 (PST) X-Received: by 10.66.27.177 with SMTP id u17mr22521763pag.25.1387229573534; Mon, 16 Dec 2013 13:32:53 -0800 (PST) Received: from localhost.localdomain (c-67-170-153-23.hsd1.or.comcast.net. [67.170.153.23]) by mx.google.com with ESMTPSA id nl7sm26678363pbc.6.2013.12.16.13.32.52 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 13:32:52 -0800 (PST) From: John Stultz To: LKML Cc: John Stultz , Colin Cross , Android Kernel Team , Greg KH , kbuild test robot Subject: [RFC][PATCH 1/3] staging: ion: Add HAVE_MEMBLOCK config dependency Date: Mon, 16 Dec 2013 13:32:42 -0800 Message-Id: <1387229564-19517-2-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1387229564-19517-1-git-send-email-john.stultz@linaro.org> References: <1387229564-19517-1-git-send-email-john.stultz@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: john.stultz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The kbuild test robot reported a build issue w/ ION on m68k: drivers/staging/android/ion/ion.c: In function 'ion_reserve': drivers/staging/android/ion/ion.c:1526:4: error: implicit declaration of function 'memblock_alloc_base' [-Werror=implicit-function-declaration] drivers/staging/android/ion/ion.c:1528:11: error: 'MEMBLOCK_ALLOC_ANYWHERE' undeclared (first use in this function) drivers/staging/android/ion/ion.c:1528:11: note: each undeclared identifier is reported only once for each function it appears in drivers/staging/android/ion/ion.c:1537:4: error: implicit declaration of function 'memblock_reserve' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors This is caused by ION using memblock functionality which m68k doesn't support. This patch adds a HAVE_MEMBLOCK dependency to the ION config. Cc: Colin Cross Cc: Android Kernel Team Cc: Greg KH Cc: kbuild test robot Reported-by: kbuild test robot Signed-off-by: John Stultz --- drivers/staging/android/ion/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig index b95281e..a9a64ea 100644 --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -1,5 +1,6 @@ menuconfig ION bool "Ion Memory Manager" + depends on HAVE_MEMBLOCK select GENERIC_ALLOCATOR select DMA_SHARED_BUFFER ---help---