From patchwork Tue Dec 17 05:07:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 22550 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f199.google.com (mail-qc0-f199.google.com [209.85.216.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F29A0202E2 for ; Tue, 17 Dec 2013 05:08:02 +0000 (UTC) Received: by mail-qc0-f199.google.com with SMTP id i17sf10428931qcy.10 for ; Mon, 16 Dec 2013 21:08:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=zk+LMZ5RdLrmCaIOkglczv86TWXVodRxm13PzeM8kqE=; b=FcfvxjRNXpPjhqBfjY94aQEjny6RXxIXb0zdP2o5WHzHqBB3lIQ0La0GNV1I9p7lE/ aZZ1K8YHUYxaxWl19PnzUr5nasgSScAY8n1cMASzxck166RfWtIqZOsftms0DYq63iaR wlTvljgwBW1RytmPwwAOhj07hJkzx2PW4OcCOFnZVZTfP4/Y6wUJZ+pvcpyc9oEkWZ9T V/aCHNRraXqZZ3uitM/Yol+cNMRkRbrXhWcnznv6/PklnFlXW81EDI5BmduvoLgM3GJm boyGhvNXSZDMrRHHxv50VmhhkQFBQDwo/G5JwxPdN+v/H41UaHSABYsz03uL7IiIZPvB Lxog== X-Gm-Message-State: ALoCoQm92q/94/XOjkvCAMi2i7OUyKZTqxzSBFrRoGL7T8JY4ylsqJExUfYcZdl+cV5nhpaM1oX/ X-Received: by 10.58.238.199 with SMTP id vm7mr7163740vec.17.1387256882360; Mon, 16 Dec 2013 21:08:02 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.48.105 with SMTP id k9ls2357396qen.96.gmail; Mon, 16 Dec 2013 21:08:02 -0800 (PST) X-Received: by 10.52.157.232 with SMTP id wp8mr8378197vdb.4.1387256882261; Mon, 16 Dec 2013 21:08:02 -0800 (PST) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx.google.com with ESMTPS id xn8si4535466vdc.113.2013.12.16.21.08.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 21:08:02 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.54 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.54; Received: by mail-vb0-f54.google.com with SMTP id g10so3880620vbg.27 for ; Mon, 16 Dec 2013 21:08:02 -0800 (PST) X-Received: by 10.58.178.239 with SMTP id db15mr10016983vec.9.1387256882175; Mon, 16 Dec 2013 21:08:02 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp43446vcz; Mon, 16 Dec 2013 21:08:01 -0800 (PST) X-Received: by 10.67.5.131 with SMTP id cm3mr24817837pad.92.1387256880753; Mon, 16 Dec 2013 21:08:00 -0800 (PST) Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com [209.85.160.43]) by mx.google.com with ESMTPS id xa2si10714978pab.113.2013.12.16.21.08.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 21:08:00 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.43 is neither permitted nor denied by best guess record for domain of john.stultz@linaro.org) client-ip=209.85.160.43; Received: by mail-pb0-f43.google.com with SMTP id rq2so6420845pbb.16 for ; Mon, 16 Dec 2013 21:08:00 -0800 (PST) X-Received: by 10.68.190.169 with SMTP id gr9mr24849452pbc.30.1387256880356; Mon, 16 Dec 2013 21:08:00 -0800 (PST) Received: from localhost.localdomain (c-67-170-153-23.hsd1.or.comcast.net. [67.170.153.23]) by mx.google.com with ESMTPSA id oj6sm41996751pab.9.2013.12.16.21.07.58 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 21:07:59 -0800 (PST) From: John Stultz To: LKML Cc: John Stultz , Colin Cross , Android Kernel Team , Greg KH , kbuild test robot Subject: [PATCH 1/3] staging: ion: Add HAVE_MEMBLOCK config dependency Date: Mon, 16 Dec 2013 21:07:51 -0800 Message-Id: <1387256873-21350-2-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1387256873-21350-1-git-send-email-john.stultz@linaro.org> References: <1387256873-21350-1-git-send-email-john.stultz@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: john.stultz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.54 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The kbuild test robot reported a build issue w/ ION on m68k: drivers/staging/android/ion/ion.c: In function 'ion_reserve': drivers/staging/android/ion/ion.c:1526:4: error: implicit declaration of function 'memblock_alloc_base' [-Werror=implicit-function-declaration] drivers/staging/android/ion/ion.c:1528:11: error: 'MEMBLOCK_ALLOC_ANYWHERE' undeclared (first use in this function) drivers/staging/android/ion/ion.c:1528:11: note: each undeclared identifier is reported only once for each function it appears in drivers/staging/android/ion/ion.c:1537:4: error: implicit declaration of function 'memblock_reserve' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors This is caused by ION using memblock functionality which m68k doesn't support. This patch adds a HAVE_MEMBLOCK dependency to the ION config. Cc: Colin Cross Cc: Android Kernel Team Cc: Greg KH Cc: kbuild test robot Reported-by: kbuild test robot Signed-off-by: John Stultz --- drivers/staging/android/ion/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig index b95281e..a9a64ea 100644 --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -1,5 +1,6 @@ menuconfig ION bool "Ion Memory Manager" + depends on HAVE_MEMBLOCK select GENERIC_ALLOCATOR select DMA_SHARED_BUFFER ---help---