From patchwork Thu Jan 23 10:39:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 23609 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f71.google.com (mail-qa0-f71.google.com [209.85.216.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1D70A218BD for ; Thu, 23 Jan 2014 10:40:01 +0000 (UTC) Received: by mail-qa0-f71.google.com with SMTP id j5sf2594043qaq.10 for ; Thu, 23 Jan 2014 02:40:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=Oiy+aJpEGpytulY/nHzR5jufA6+JMxOM8LP1ALZIgpE=; b=dWFKO1YHW/E2sgMuVzpqQzaWRL28itG+XWo/6NQORFsxbuJDhbNBEmNctPk6sl8t93 Trk//5ELkK6CLk6lp+uHvweKBjefXsQaK/VXrsxN3MK2vQiFVmX+CfjPGZSY2qH6MA2t l1gIvhJHGKGmKxMYo1tWKWQTBIc+xuAi/D3ySvVb3qPKVdtqRYeW3bpQGKDG/eM9dMIc iGeBalW9k7Gnwj7cktGcXU6z3G6hYJtbHgtosIDX+CoS4v4AN8EgT2sRjKOxdO8Meyz7 eNeY6Vjl31RygZjKXT40Y1twyUwpUZ8uvLbemyqtDuvg945LkD6HgmgCTXStvoA40Fmz /xbw== X-Gm-Message-State: ALoCoQm1TCEUCV7gi7A05ViyzWNQTSFEyAO90wg3mvoHWiuL7U0i2p9K5XFKxFfhpBtInNoYgMqw X-Received: by 10.224.19.193 with SMTP id c1mr2699261qab.4.1390473601276; Thu, 23 Jan 2014 02:40:01 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.16.145 with SMTP id 17ls274226qgb.58.gmail; Thu, 23 Jan 2014 02:40:01 -0800 (PST) X-Received: by 10.59.5.102 with SMTP id cl6mr52526ved.41.1390473601136; Thu, 23 Jan 2014 02:40:01 -0800 (PST) Received: from mail-ve0-f171.google.com (mail-ve0-f171.google.com [209.85.128.171]) by mx.google.com with ESMTPS id yv5si6426235veb.140.2014.01.23.02.40.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 02:40:01 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.171; Received: by mail-ve0-f171.google.com with SMTP id pa12so993035veb.30 for ; Thu, 23 Jan 2014 02:40:01 -0800 (PST) X-Received: by 10.58.211.130 with SMTP id nc2mr4022755vec.7.1390473601056; Thu, 23 Jan 2014 02:40:01 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp16469vcz; Thu, 23 Jan 2014 02:40:00 -0800 (PST) X-Received: by 10.68.197.234 with SMTP id ix10mr7293474pbc.80.1390473600118; Thu, 23 Jan 2014 02:40:00 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si7249162pbh.40.2014.01.23.02.39.58; Thu, 23 Jan 2014 02:39:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932210AbaAWKjw (ORCPT + 27 others); Thu, 23 Jan 2014 05:39:52 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:44214 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753770AbaAWKju (ORCPT ); Thu, 23 Jan 2014 05:39:50 -0500 Received: by mail-wi0-f171.google.com with SMTP id cc10so6628251wib.10 for ; Thu, 23 Jan 2014 02:39:49 -0800 (PST) X-Received: by 10.194.61.133 with SMTP id p5mr837279wjr.73.1390473589793; Thu, 23 Jan 2014 02:39:49 -0800 (PST) Received: from ards-macbook-pro.local (cag06-7-83-153-85-71.fbx.proxad.net. [83.153.85.71]) by mx.google.com with ESMTPSA id eo4sm26522547wib.9.2014.01.23.02.39.48 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 02:39:49 -0800 (PST) From: Ard Biesheuvel To: gregkh@linuxfoundation.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel Subject: [PATCH] firmware/google: drop 'select EFI' to avoid recursive dependency Date: Thu, 23 Jan 2014 11:39:48 +0100 Message-Id: <1390473588-23367-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 1.8.3.2 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ard.biesheuvel@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The GOOGLE_SMI Kconfig symbol depends on DMI and selects EFI. This causes problems on other archs when introducing DMI support that depends on EFI, as it results in a recursive dependency: arch/arm/Kconfig:1845:error: recursive dependency detected! arch/arm/Kconfig:1845: symbol DMI depends on EFI Fix by changing the 'select EFI' to a 'depends on EFI'. Signed-off-by: Ard Biesheuvel --- drivers/firmware/google/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig index 2f21b0bfe653..29c8cdda82a1 100644 --- a/drivers/firmware/google/Kconfig +++ b/drivers/firmware/google/Kconfig @@ -12,8 +12,7 @@ menu "Google Firmware Drivers" config GOOGLE_SMI tristate "SMI interface for Google platforms" - depends on ACPI && DMI - select EFI + depends on ACPI && DMI && EFI select EFI_VARS help Say Y here if you want to enable SMI callbacks for Google