From patchwork Thu Feb 20 08:53:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 24977 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f70.google.com (mail-pa0-f70.google.com [209.85.220.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 96E7B2066E for ; Thu, 20 Feb 2014 08:59:31 +0000 (UTC) Received: by mail-pa0-f70.google.com with SMTP id kq14sf4051807pab.9 for ; Thu, 20 Feb 2014 00:59:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=z+Mem7u/Yj6aD/ZQaV5lXqoH88O9O9qns+DEjIiXz8k=; b=SYZD+fcBtOZUuUmr2VKiBFyA4AmgCqDcpywIxunvR0V8/3Y1DR6wdh06oVgcl8mXxh fHZ5SE27ptYDZRPoQPHjq1z8IscwN0Cp7oZuNDtNnN9v0pshXpDo1s68coEtdBaetj3H eWnwD+3oS88R8SRHPl5CD+FM4SAefkL+l4+ETDRexM3+GRNgVVqzDQj+IN0xXwUgbT2y wtlxG3U+XRGHjY82xbYN4Axmpk+5mAEh/jSU8NKCzKRXT1FdLkh7kVQWasSiy1H+MT56 MLQNEWOg8OAKCzhVFdo9J6VPr90IFRTAVluaxULg11wRNlRZ3zOGdW8fcVqEiIUn1LdW CzPQ== X-Gm-Message-State: ALoCoQn4AO8yHPXvOPv+KC5JL5C6lpTvszq1dsz/BuWl1gsPRLQfqwimL6noE3ijf8UForiy0wgZ X-Received: by 10.66.141.135 with SMTP id ro7mr274171pab.28.1392886767960; Thu, 20 Feb 2014 00:59:27 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.38.47 with SMTP id s44ls467778qgs.70.gmail; Thu, 20 Feb 2014 00:59:27 -0800 (PST) X-Received: by 10.224.119.147 with SMTP id z19mr391891qaq.20.1392886767817; Thu, 20 Feb 2014 00:59:27 -0800 (PST) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id p68si3051362yhh.55.2014.02.20.00.59.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 00:59:27 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id la4so1569499vcb.35 for ; Thu, 20 Feb 2014 00:59:26 -0800 (PST) X-Received: by 10.52.107.35 with SMTP id gz3mr318568vdb.8.1392886766814; Thu, 20 Feb 2014 00:59:26 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp40735vcz; Thu, 20 Feb 2014 00:59:26 -0800 (PST) X-Received: by 10.66.122.101 with SMTP id lr5mr709104pab.130.1392886765900; Thu, 20 Feb 2014 00:59:25 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id tt8si2682990pbc.190.2014.02.20.00.59.20; Thu, 20 Feb 2014 00:59:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754455AbaBTI7B (ORCPT + 26 others); Thu, 20 Feb 2014 03:59:01 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:59024 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754034AbaBTI66 (ORCPT ); Thu, 20 Feb 2014 03:58:58 -0500 Received: by mail-pa0-f54.google.com with SMTP id fa1so1619332pad.41 for ; Thu, 20 Feb 2014 00:58:57 -0800 (PST) X-Received: by 10.68.129.234 with SMTP id nz10mr819717pbb.16.1392886737493; Thu, 20 Feb 2014 00:58:57 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id eo11sm21100112pac.0.2014.02.20.00.58.54 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 00:58:56 -0800 (PST) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: broonie@kernel.org, lgirdwood@gmail.com, sachin.kamat@linaro.org, S Twiss Subject: [PATCH 02/23] regulator: da9210: Remove redundant error message Date: Thu, 20 Feb 2014 14:23:02 +0530 Message-Id: <1392886403-10640-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1392886403-10640-1-git-send-email-sachin.kamat@linaro.org> References: <1392886403-10640-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat Cc: S Twiss --- drivers/regulator/da9210-regulator.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/regulator/da9210-regulator.c b/drivers/regulator/da9210-regulator.c index 6f5ecbe1132e..7a320dd11c46 100644 --- a/drivers/regulator/da9210-regulator.c +++ b/drivers/regulator/da9210-regulator.c @@ -134,11 +134,8 @@ static int da9210_i2c_probe(struct i2c_client *i2c, int error; chip = devm_kzalloc(&i2c->dev, sizeof(struct da9210), GFP_KERNEL); - if (NULL == chip) { - dev_err(&i2c->dev, - "Cannot kzalloc memory for regulator structure\n"); + if (!chip) return -ENOMEM; - } chip->regmap = devm_regmap_init_i2c(i2c, &da9210_regmap_config); if (IS_ERR(chip->regmap)) {