From patchwork Tue Mar 11 22:40:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 26061 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f69.google.com (mail-qa0-f69.google.com [209.85.216.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3F1F9202E5 for ; Tue, 11 Mar 2014 22:42:59 +0000 (UTC) Received: by mail-qa0-f69.google.com with SMTP id w5sf12213862qac.0 for ; Tue, 11 Mar 2014 15:42:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=jSEYJIxFlu7lKPmFCDn6sdK8VTuXI+T2xvNKUfiIaL4=; b=PEUuSmz79mvFuwQc0hyHC8hGO3yV2KkgE2cwSitwAVEgLK/50G7CzdODOXJSiHqCZT N2lK4liDV40HhZVbMp3mj23hTdKzDXlsh3L8n7pntg4qw/QchlXKOjnwYbHK2ySygc+7 boWCv2S9TwUMBvEwievLIUw337L0dw4RBiRD6ETxBO+9JLsR9FstZiUxzphmgRq1wjnq 5DdXsGpf7/u1okxVTS9fhMLvgiv0Q4/hYL5ooZvB0Ej3LRt/I6A4xDIMGOwdzI3EpPN6 YeBapb4fDYDr5l2C9KwCU4l9OLSctRC19fW3PvGg14+34QDfXodkC5o7VgjLxyDFZn/H iL2A== X-Gm-Message-State: ALoCoQnGfmBuwZXQnAmdYI2gD7SQcvTl1VFEkXotAg0w//00njdvRqKlh4aYv1pZjp6BxcY9ujXU X-Received: by 10.236.102.8 with SMTP id c8mr16912466yhg.5.1394577778852; Tue, 11 Mar 2014 15:42:58 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.33.203 with SMTP id j69ls2666431qgj.27.gmail; Tue, 11 Mar 2014 15:42:58 -0700 (PDT) X-Received: by 10.52.35.196 with SMTP id k4mr58744vdj.38.1394577778738; Tue, 11 Mar 2014 15:42:58 -0700 (PDT) Received: from mail-ve0-f177.google.com (mail-ve0-f177.google.com [209.85.128.177]) by mx.google.com with ESMTPS id be7si6214514vcb.35.2014.03.11.15.42.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 11 Mar 2014 15:42:58 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.177; Received: by mail-ve0-f177.google.com with SMTP id sa20so9116961veb.8 for ; Tue, 11 Mar 2014 15:42:58 -0700 (PDT) X-Received: by 10.58.185.145 with SMTP id fc17mr5937857vec.14.1394577778636; Tue, 11 Mar 2014 15:42:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp238896vck; Tue, 11 Mar 2014 15:42:58 -0700 (PDT) X-Received: by 10.68.233.200 with SMTP id ty8mr757880pbc.1.1394577777707; Tue, 11 Mar 2014 15:42:57 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id wp10si358072pbc.17.2014.03.11.15.42.57; Tue, 11 Mar 2014 15:42:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175AbaCKWmu (ORCPT + 26 others); Tue, 11 Mar 2014 18:42:50 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:47445 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756069AbaCKWlM (ORCPT ); Tue, 11 Mar 2014 18:41:12 -0400 Received: by mail-wi0-f176.google.com with SMTP id hr14so1605663wib.9 for ; Tue, 11 Mar 2014 15:41:11 -0700 (PDT) X-Received: by 10.194.63.103 with SMTP id f7mr16025303wjs.38.1394577671186; Tue, 11 Mar 2014 15:41:11 -0700 (PDT) Received: from localhost.localdomain (AToulouse-654-1-526-136.w109-220.abo.wanadoo.fr. [109.220.245.136]) by mx.google.com with ESMTPSA id n3sm10411631wix.10.2014.03.11.15.41.09 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 11 Mar 2014 15:41:10 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de, mingo@kernel.org Cc: linux-kernel@vger.kernel.org, dan.carpenter@oracle.com, ezequiel.garcia@free-electrons.com, ivan.khoronzhuk@ti.com, linus.walleij@linaro.org, magnus.damm@gmail.com, matthias.bgg@gmail.com, soren.brinkmann@xilinx.com, sboyd@codeaurora.org Subject: [PATCH 13/17] clocksource/cadence_ttc: Call clockevents_update_freq() with IRQs enabled Date: Tue, 11 Mar 2014 23:40:49 +0100 Message-Id: <1394577653-8615-13-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1394577653-8615-1-git-send-email-daniel.lezcano@linaro.org> References: <531F8FAC.2040902@linaro.org> <1394577653-8615-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.lezcano@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Soren Brinkmann The timer core takes care of serialization and IRQs. Hence the driver is no longer required to disable interrupts when calling clockevents_update_freq(). Signed-off-by: Soren Brinkmann Signed-off-by: Daniel Lezcano Acked-by: Michal Simek --- drivers/clocksource/cadence_ttc_timer.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/clocksource/cadence_ttc_timer.c b/drivers/clocksource/cadence_ttc_timer.c index 63f176d..f05b9fd 100644 --- a/drivers/clocksource/cadence_ttc_timer.c +++ b/drivers/clocksource/cadence_ttc_timer.c @@ -321,25 +321,12 @@ static int ttc_rate_change_clockevent_cb(struct notifier_block *nb, switch (event) { case POST_RATE_CHANGE: - { - unsigned long flags; - - /* - * clockevents_update_freq should be called with IRQ disabled on - * the CPU the timer provides events for. The timer we use is - * common to both CPUs, not sure if we need to run on both - * cores. - */ - local_irq_save(flags); - clockevents_update_freq(&ttcce->ce, - ndata->new_rate / PRESCALE); - local_irq_restore(flags); - /* update cached frequency */ ttc->freq = ndata->new_rate; + clockevents_update_freq(&ttcce->ce, ndata->new_rate / PRESCALE); + /* fall through */ - } case PRE_RATE_CHANGE: case ABORT_RATE_CHANGE: default: