From patchwork Fri Sep 5 23:16:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Behan Webster X-Patchwork-Id: 36912 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f197.google.com (mail-ig0-f197.google.com [209.85.213.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 196E1202E4 for ; Fri, 5 Sep 2014 23:17:03 +0000 (UTC) Received: by mail-ig0-f197.google.com with SMTP id r2sf58285820igi.4 for ; Fri, 05 Sep 2014 16:17:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=A+NbDkP0I3xyAOX1pbNQyQTDRZI2UzverNiGQPR6lbo=; b=fZj9CCm4Sy3xveBLxkWAT9ODs0lVnoYxWuQxGFcIMWno8KSfukc2Wo9VdxRYEXOY94 ktkgKj7sQU32Kp9zHY82ZaJNP83xn0QXCKUEm3EX7ACLmREs82TQEZYn1uVnQOVscOea cTz0YvaRH0fQMduz1LJJJ/J9MTArltW7Ht6xOKKeHGabcUKPZH7BCALCvFhLas9jW9K3 vtGzll/Rg9uk04t3bJxVGJoY/9HDZdggGfacjSQyKW/ugJfui5TnyZKqEKkbXE4up2/c 03fzy0XZypfDcJYbKBkZldmqNSU4PFgaOJqNcVtKWbzIHqrn+7aergT62TqyWlmheORG 6vHA== X-Gm-Message-State: ALoCoQnDp6pte7yOlXLxa7X60WB1AidCpsc3VD/UOVUQitzhEcffUD2rqqpcshqt0Aa7lVpESp+u X-Received: by 10.50.43.168 with SMTP id x8mr3899669igl.4.1409959022397; Fri, 05 Sep 2014 16:17:02 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.108.38 with SMTP id i35ls870237qgf.76.gmail; Fri, 05 Sep 2014 16:17:02 -0700 (PDT) X-Received: by 10.220.251.200 with SMTP id mt8mr12880444vcb.24.1409959022290; Fri, 05 Sep 2014 16:17:02 -0700 (PDT) Received: from mail-vc0-x236.google.com (mail-vc0-x236.google.com [2607:f8b0:400c:c03::236]) by mx.google.com with ESMTPS id t5si1554574vcc.32.2014.09.05.16.17.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Sep 2014 16:17:02 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::236 as permitted sender) client-ip=2607:f8b0:400c:c03::236; Received: by mail-vc0-f182.google.com with SMTP id im17so13239316vcb.13 for ; Fri, 05 Sep 2014 16:17:02 -0700 (PDT) X-Received: by 10.221.44.69 with SMTP id uf5mr12930661vcb.4.1409959022206; Fri, 05 Sep 2014 16:17:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp149559vcb; Fri, 5 Sep 2014 16:17:01 -0700 (PDT) X-Received: by 10.69.31.65 with SMTP id kk1mr67891pbd.162.1409959021342; Fri, 05 Sep 2014 16:17:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id js7si6180773pbc.189.2014.09.05.16.17.00 for ; Fri, 05 Sep 2014 16:17:01 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbaIEXQ6 (ORCPT + 26 others); Fri, 5 Sep 2014 19:16:58 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:45075 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbaIEXQ5 (ORCPT ); Fri, 5 Sep 2014 19:16:57 -0400 Received: by mail-pa0-f42.google.com with SMTP id lf10so23176431pab.29 for ; Fri, 05 Sep 2014 16:16:57 -0700 (PDT) X-Received: by 10.70.64.166 with SMTP id p6mr26502217pds.139.1409959017128; Fri, 05 Sep 2014 16:16:57 -0700 (PDT) Received: from galdor.websterwood.com (S0106dc9fdb80cffd.gv.shawcable.net. [96.50.97.138]) by mx.google.com with ESMTPSA id ty8sm2803942pab.26.2014.09.05.16.16.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 05 Sep 2014 16:16:56 -0700 (PDT) From: behanw@converseincode.com To: hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, =?UTF-8?q?Jan-Simon=20M=C3=B6ller?= , Behan Webster Subject: [PATCH] mm: Apply the section attribute to the variable, not its type Date: Fri, 5 Sep 2014 16:16:45 -0700 Message-Id: <1409959005-11479-1-git-send-email-behanw@converseincode.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Original-Sender: behanw@converseincode.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::236 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=neutral (body hash did not verify) header.i=@ Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Jan-Simon Möller This fixes a compilation error in clang in that a linker section attribute can't be added to a type. arch/x86/mm/mmap.c:34:8: error: '__section__' attribute only applies to functions and global variables struct __read_mostly va_alignment va_align = { ^ arch/x86/include/asm/cache.h:10:38: note: expanded from macro '__read_mostly' #define __read_mostly __attribute__((__section__(".data..read_mostly"))) ^ 1 error generated. By moving the section attribute to the variable declaration, the desired effect is acheived. Signed-off-by: Jan-Simon Möller Signed-off-by: Behan Webster --- arch/x86/mm/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c index 25e7e13..919b912 100644 --- a/arch/x86/mm/mmap.c +++ b/arch/x86/mm/mmap.c @@ -31,7 +31,7 @@ #include #include -struct __read_mostly va_alignment va_align = { +struct va_alignment __read_mostly va_align = { .flags = -1, };