From patchwork Wed Sep 24 13:49:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 37829 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 853F5204FF for ; Wed, 24 Sep 2014 13:50:28 +0000 (UTC) Received: by mail-wi0-f197.google.com with SMTP id ho1sf3612361wib.0 for ; Wed, 24 Sep 2014 06:50:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=yUQ+k6N9HiJr5XDl2RYdrqlUQPuoPgfxSPd3AvLDxmo=; b=aD0vbsBRNayXa9E2PG7Y7+/gZ1TWOx+lVMvDf2D2/EMSsYnw/MRTVmfcdZHuNBjdBX QVxgEUg8EcybJsU0stMbbAoFoejkf+970YcEa7yH2WPPNdWSFbUAkuetnKx8VXHcw7OL dxsZZrZlTrOsegUzS+hjQnC1HEjNza5lGY1M8t5tfQU1KlO0Qg3zhlGnjYvJEuIRC3Fm FzKQ58gp5OUir4Sud0aoR3Ha61vveKkwUsOmh5OdxP/Ll7TGalImSVtEIB6MwBCNJ7CP ozFWK9Mq/s1doMbAQunEgqg4kOzfhLJL+nlnBlyodarbKG1i5Bt2aOsUKDKmAV6/iM4h kvWg== X-Gm-Message-State: ALoCoQn3qDZfwgL6ourH+mQg+GBm6SSNeA3255xBBH2cUzbQYZO67hgoKXs3v/F59o2gAdXZ053d X-Received: by 10.112.137.230 with SMTP id ql6mr474139lbb.13.1411566627617; Wed, 24 Sep 2014 06:50:27 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.203.235 with SMTP id kt11ls170745lac.83.gmail; Wed, 24 Sep 2014 06:50:27 -0700 (PDT) X-Received: by 10.112.118.227 with SMTP id kp3mr6085590lbb.75.1411566627377; Wed, 24 Sep 2014 06:50:27 -0700 (PDT) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com [209.85.215.52]) by mx.google.com with ESMTPS id b9si22940918lbp.50.2014.09.24.06.50.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Sep 2014 06:50:27 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by mail-la0-f52.google.com with SMTP id gq15so10579070lab.39 for ; Wed, 24 Sep 2014 06:50:27 -0700 (PDT) X-Received: by 10.112.4.33 with SMTP id h1mr6055727lbh.67.1411566627215; Wed, 24 Sep 2014 06:50:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp585411lbb; Wed, 24 Sep 2014 06:50:26 -0700 (PDT) X-Received: by 10.70.35.15 with SMTP id d15mr12733956pdj.48.1411566625701; Wed, 24 Sep 2014 06:50:25 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id du1si26348024pdb.189.2014.09.24.06.50.24 for ; Wed, 24 Sep 2014 06:50:25 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbaIXNuU (ORCPT + 27 others); Wed, 24 Sep 2014 09:50:20 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:38842 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbaIXNuQ (ORCPT ); Wed, 24 Sep 2014 09:50:16 -0400 Received: from leverpostej.cambridge.arm.com (leverpostej.cambridge.arm.com [10.1.205.151]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id s8ODnjwo027199; Wed, 24 Sep 2014 14:49:45 +0100 (BST) From: Mark Rutland To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: Mark Rutland , Pranith Kumar , Christoph Lameter , Randy Dunlap Subject: [PATCH] Docs: this_cpu_ops: remove redundant add forms Date: Wed, 24 Sep 2014 14:49:43 +0100 Message-Id: <1411566583-22220-1-git-send-email-mark.rutland@arm.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mark.rutland@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi, I spotted the below while trying to figure out how to use this_cpu ops, and it left me confused for a short while. I guess that this is a refactoring fallout rather than there being a special this_cpu_add variant? Mark. ---->8---- Commit ac490f4dca94 (Documentation: this_cpu_ops.txt: Update description of this_cpu_ops) added lists of {__,}this_cpu operations, but these have duplicate, parameter-less entries for {__,}this_cpu_add which don't correspond to any implementation. No other operations have such duplicate entries. Given both are also listed with their full complement of arguments, the empty forms are redundant and can be removed. This patch performs said removal. Signed-off-by: Mark Rutland Cc: Pranith Kumar Cc: Christoph Lameter Cc: Randy Dunlap Acked-by: Christoph Lameter --- Documentation/this_cpu_ops.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/this_cpu_ops.txt b/Documentation/this_cpu_ops.txt index 0ec9957..2cbf719 100644 --- a/Documentation/this_cpu_ops.txt +++ b/Documentation/this_cpu_ops.txt @@ -41,7 +41,6 @@ The following this_cpu() operations with implied preemption protection are defined. These operations can be used without worrying about preemption and interrupts. - this_cpu_add() this_cpu_read(pcp) this_cpu_write(pcp, val) this_cpu_add(pcp, val) @@ -225,7 +224,6 @@ still occur while an operation is in progress and if the interrupt too modifies the variable, then RMW actions can not be guaranteed to be safe. - __this_cpu_add() __this_cpu_read(pcp) __this_cpu_write(pcp, val) __this_cpu_add(pcp, val)