From patchwork Wed Nov 12 14:42:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 40678 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 16E2024493 for ; Wed, 12 Nov 2014 14:43:16 +0000 (UTC) Received: by mail-lb0-f200.google.com with SMTP id f15sf6826099lbj.7 for ; Wed, 12 Nov 2014 06:43:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=U1UizpyVbK3vozoUi3GfLuG9UQzzp7gDYp30Cp+ZU9o=; b=Ju6n9s/I8YnPi0BVBO+sEZureGnMDBqKzj97j5eLETfoDxF/H6rzSsSdBzX6dTJuvD OKpQZIlHOobhTtxGdDckbPm73esY7ZRwCDPG9SCB/uWP4wjQjm7XTSxPtoLt7iFUoNZH iWZRjvbR82v+PYlc/aDDhQTbkH6q6cEPj8OxuP/mpXY11gced40+iji001IrCOuLcnkM sgcfGn0ua/Tn7cMkI2PWqBys0tjCbU75T/n2H9ICB8hTs0qBacAeILYebeHUHkwA9C7N yCW7LJWlp5CLOdKCLsL++epL5YrCuWlNQ+PXMJnaqVFx/wBSDYKCgC9yOJO+HxcWafn+ xCwA== X-Gm-Message-State: ALoCoQllXcM2e5k/TLs5uxWHIGIuXHJ0cPC7mqWFZPAcV8ntl0vBX06t4ofH/E0pxVpItLXBPURW X-Received: by 10.112.119.194 with SMTP id kw2mr497170lbb.16.1415803395029; Wed, 12 Nov 2014 06:43:15 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.227 with SMTP id v3ls745133lav.91.gmail; Wed, 12 Nov 2014 06:43:14 -0800 (PST) X-Received: by 10.112.235.196 with SMTP id uo4mr33075845lbc.66.1415803394825; Wed, 12 Nov 2014 06:43:14 -0800 (PST) Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com. [209.85.217.174]) by mx.google.com with ESMTPS id pt7si35027918lbb.120.2014.11.12.06.43.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Nov 2014 06:43:14 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.174 as permitted sender) client-ip=209.85.217.174; Received: by mail-lb0-f174.google.com with SMTP id w7so767687lbi.19 for ; Wed, 12 Nov 2014 06:43:14 -0800 (PST) X-Received: by 10.112.14.69 with SMTP id n5mr42619360lbc.34.1415803394516; Wed, 12 Nov 2014 06:43:14 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp435154lbc; Wed, 12 Nov 2014 06:43:13 -0800 (PST) X-Received: by 10.69.13.196 with SMTP id fa4mr48278939pbd.65.1415803392871; Wed, 12 Nov 2014 06:43:12 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gt8si23026243pbc.42.2014.11.12.06.43.12 for ; Wed, 12 Nov 2014 06:43:12 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753257AbaKLOnK (ORCPT + 25 others); Wed, 12 Nov 2014 09:43:10 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:50228 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752357AbaKLOnI (ORCPT ); Wed, 12 Nov 2014 09:43:08 -0500 Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.207.30]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id sACEh2pB010329; Wed, 12 Nov 2014 14:43:02 GMT From: Sudeep Holla To: LKML Cc: Sudeep Holla , Fabio Estevam , Greg Kroah-Hartman Subject: [PATCH] drivers/base: cacheinfo: remove noisy error boot message Date: Wed, 12 Nov 2014 14:42:53 +0000 Message-Id: <1415803373-7429-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sudeep.holla@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.174 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On systems that don't support cacheinfo, this error message can be considered noisy and irrelevant. The error messages can be added to the functions that architectures implement overiding the weak default definition if really required. This patch removes the concerned error message in the generic code. Signed-off-by: Sudeep Holla Reported-by: Fabio Estevam Cc: Greg Kroah-Hartman --- drivers/base/cacheinfo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Hi Greg, Since I always tested the series only on the architectures supporting cacheinfo, I failed to see that this error message is thrown out at the boot time if the architecture doesn't support it. Can you pick up this small fix to avoid noisy error message ? Regards, Sudeep diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c index 8ed4ea1f3716..6e64563361f0 100644 --- a/drivers/base/cacheinfo.c +++ b/drivers/base/cacheinfo.c @@ -520,10 +520,8 @@ static int __init cacheinfo_sysfs_init(void) for_each_online_cpu(cpu) { rc = detect_cache_attributes(cpu); - if (rc) { - pr_err("error detecting cacheinfo..cpu%d\n", cpu); + if (rc) goto out; - } rc = cache_add_dev(cpu); if (rc) { free_cache_attributes(cpu);