From patchwork Thu Jan 22 02:31:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "pang.xunlei" X-Patchwork-Id: 43485 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E39E0240D5 for ; Thu, 22 Jan 2015 02:32:36 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id hs14sf25832172lab.1 for ; Wed, 21 Jan 2015 18:32:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=sx3JuPLm9learBt1trSuieyyow8tGC64aeYKx+HO7NU=; b=lYl4gJjjM7T/LNbcYh7IDvA8NLpTg0os8e8vY/Ob9B5qKPCdoEF5Aeo5ah/R3Uy8Xm BWCFKU41i5j3Bs4TErhTjF9FJTqEXwkpX/hoBOpkbg8d3L6k/GGo0VNmu/tSJbLZlDXH 9paBI2z8yq6axVsbQopmm+nyLBPc3bBYszHq80yiq3MZTHJhMY4Bxr2iTX8vjHtYEgJL pC7WV8MxuTtt060JxXVXPWlToM+FUQLDqA8rj7RtEHRmWYD+//8528lKSkfjU8WcSTKR tIwtG34hso3PF35rKmS/wXUgl3Cxu/NiegaH5Os1oWeziX6ZrbWlSP6bkLGfeISihmi/ +pmA== X-Gm-Message-State: ALoCoQmSMKjd/Q/++dBSJiulmRiRoiNu4fgaAUBihRHPQeX/kHa5f9AQNzzKQi0C4E/It7dwvcG9 X-Received: by 10.180.7.226 with SMTP id m2mr26469wia.5.1421893955924; Wed, 21 Jan 2015 18:32:35 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.8.115 with SMTP id q19ls104977laa.55.gmail; Wed, 21 Jan 2015 18:32:35 -0800 (PST) X-Received: by 10.152.43.103 with SMTP id v7mr47738386lal.29.1421893955666; Wed, 21 Jan 2015 18:32:35 -0800 (PST) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com. [209.85.215.52]) by mx.google.com with ESMTPS id y3si20895249laj.75.2015.01.21.18.32.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Jan 2015 18:32:35 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by mail-la0-f52.google.com with SMTP id hs14so43620297lab.11 for ; Wed, 21 Jan 2015 18:32:35 -0800 (PST) X-Received: by 10.112.52.229 with SMTP id w5mr47513767lbo.52.1421893955511; Wed, 21 Jan 2015 18:32:35 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp109926lbb; Wed, 21 Jan 2015 18:32:34 -0800 (PST) X-Received: by 10.68.231.71 with SMTP id te7mr66688258pbc.129.1421893953772; Wed, 21 Jan 2015 18:32:33 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3si10818599pat.95.2015.01.21.18.32.32; Wed, 21 Jan 2015 18:32:33 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593AbbAVCcZ (ORCPT + 28 others); Wed, 21 Jan 2015 21:32:25 -0500 Received: from mail-qc0-f181.google.com ([209.85.216.181]:35307 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754355AbbAVCcI (ORCPT ); Wed, 21 Jan 2015 21:32:08 -0500 Received: by mail-qc0-f181.google.com with SMTP id l6so30680703qcy.12 for ; Wed, 21 Jan 2015 18:32:08 -0800 (PST) X-Received: by 10.140.46.37 with SMTP id j34mr70367153qga.12.1421893928114; Wed, 21 Jan 2015 18:32:08 -0800 (PST) Received: from ip-10-181-65-231.ec2.internal ([54.235.93.228]) by mx.google.com with ESMTPSA id w9sm5174891qab.18.2015.01.21.18.32.07 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Jan 2015 18:32:07 -0800 (PST) From: Xunlei Pang To: linux-kernel@vger.kernel.org Cc: rtc-linux@googlegroups.com, Thomas Gleixner , Alessandro Zummo , John Stultz , Arnd Bergmann , Xunlei Pang Subject: [PATCH 4/5] rtc: Remove redundant rtc_valid_tm() from rtc_hctosys() Date: Thu, 22 Jan 2015 02:31:54 +0000 Message-Id: <1421893915-19309-4-git-send-email-pang.xunlei@linaro.org> X-Mailer: git-send-email 2.2.1 In-Reply-To: <1421893915-19309-1-git-send-email-pang.xunlei@linaro.org> References: <1421893915-19309-1-git-send-email-pang.xunlei@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: pang.xunlei@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , rtc_read_time() has already judged valid tm by rtc_valid_tm(), so just remove it. Reviewed-by: John Stultz Reviewed-by: Arnd Bergmann Signed-off-by: Xunlei Pang --- drivers/rtc/hctosys.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/rtc/hctosys.c b/drivers/rtc/hctosys.c index 2153b52..6c719f2 100644 --- a/drivers/rtc/hctosys.c +++ b/drivers/rtc/hctosys.c @@ -45,13 +45,6 @@ static int __init rtc_hctosys(void) } - err = rtc_valid_tm(&tm); - if (err) { - dev_err(rtc->dev.parent, - "hctosys: invalid date/time\n"); - goto err_invalid; - } - tv64.tv_sec = rtc_tm_to_time64(&tm); err = do_settimeofday64(&tv64); @@ -63,7 +56,6 @@ static int __init rtc_hctosys(void) tm.tm_hour, tm.tm_min, tm.tm_sec, (long long) tv64.tv_sec); -err_invalid: err_read: rtc_class_close(rtc);