From patchwork Fri Jan 23 00:09:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 43548 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0D023218DB for ; Fri, 23 Jan 2015 00:09:52 +0000 (UTC) Received: by mail-wg0-f69.google.com with SMTP id x12sf2593283wgg.0 for ; Thu, 22 Jan 2015 16:09:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=0gBM62Vp42oOJSWIz6ZmhN5rQzo/8s8bk5fV4EZO8Is=; b=jERCBgvev6bhoFDbleQff1s2F68IMXTF3mcT5GoM0GnHVUqUN0jhaw0tUpz+kGTcA/ RANoHNNJqsbSiplKyUpfTYWegIjbTLxLeY0siaBxvR8YSdnI09TASQu4Kv1Pfr5sbh71 feAEY46pAalP+Y5IhZKI2hd+aRUozFt3ruTDshUYVfm2+XFtVbkrfUqHDKeet4HUySl5 +CMCfFEfiAGEdd0nhH2PUPftHnv6U5iVm6qzDHc/KpEwlhbhzlNmHZya2lKCsG68bOp4 pE3JC/OePnJORoWBZV3OK0qvxgPktSLDaUvRKNkRILlcTbsBxQlirX6SPb9COCBFhPbj 3Q/A== X-Gm-Message-State: ALoCoQlmnX5lXRTcew7d1Ghr4KVlLWjRUgn678ZC87gWNKYZ9Alr0nrDUVGT34VV/4ZEMviaPExT X-Received: by 10.112.143.167 with SMTP id sf7mr592962lbb.0.1421971791313; Thu, 22 Jan 2015 16:09:51 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.204.68 with SMTP id kw4ls124369lac.101.gmail; Thu, 22 Jan 2015 16:09:51 -0800 (PST) X-Received: by 10.153.7.100 with SMTP id db4mr4455137lad.79.1421971791173; Thu, 22 Jan 2015 16:09:51 -0800 (PST) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com. [209.85.217.171]) by mx.google.com with ESMTPS id x12si22058424lbm.44.2015.01.22.16.09.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 16:09:51 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) client-ip=209.85.217.171; Received: by mail-lb0-f171.google.com with SMTP id u14so4453607lbd.2 for ; Thu, 22 Jan 2015 16:09:51 -0800 (PST) X-Received: by 10.152.23.38 with SMTP id j6mr4470891laf.81.1421971791085; Thu, 22 Jan 2015 16:09:51 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.9.200 with SMTP id c8csp63913lbb; Thu, 22 Jan 2015 16:09:50 -0800 (PST) X-Received: by 10.69.20.74 with SMTP id ha10mr6764672pbd.10.1421971780000; Thu, 22 Jan 2015 16:09:40 -0800 (PST) Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com. [209.85.192.179]) by mx.google.com with ESMTPS id bx10si9690350pdb.37.2015.01.22.16.09.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 16:09:39 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.192.179 as permitted sender) client-ip=209.85.192.179; Received: by mail-pd0-f179.google.com with SMTP id v10so4762798pde.10 for ; Thu, 22 Jan 2015 16:09:39 -0800 (PST) X-Received: by 10.70.140.72 with SMTP id re8mr6516487pdb.144.1421971778986; Thu, 22 Jan 2015 16:09:38 -0800 (PST) Received: from localhost.localdomain (c-67-170-153-23.hsd1.or.comcast.net. [67.170.153.23]) by mx.google.com with ESMTPSA id am14sm10405657pac.35.2015.01.22.16.09.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 22 Jan 2015 16:09:38 -0800 (PST) From: John Stultz To: Linux Kernel Mailing List Cc: John Stultz , Dave Jones , Linus Torvalds , Thomas Gleixner , Richard Cochran , Prarit Bhargava , Stephen Boyd , Ingo Molnar , Peter Zijlstra Subject: [PATCH 05/12] time: Add debugging checks to warn if we see delays Date: Thu, 22 Jan 2015 16:09:20 -0800 Message-Id: <1421971767-17707-6-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421971767-17707-1-git-send-email-john.stultz@linaro.org> References: <1421971767-17707-1-git-send-email-john.stultz@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: john.stultz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Recently there's been some request for better sanity checking in the time code, so that its more clear when something is going wrong since timekeeping issues could manifest in a large number of strange ways with various subsystems. Thus, this patch adds some extra infrastructure to add a check update_wall_time to print warnings if we see the call delayed beyond the max_cycles overflow point, or beyond the clocksource max_idle_ns value which is currently 50% of the overflow point. This extra infrastructure is conditionalized behind a new CONFIG_DEBUG_TIMEKEEPING option also added in this patch. Tested this a bit by halting qemu for specified lengths of time to trigger the warnings. Cc: Dave Jones Cc: Linus Torvalds Cc: Thomas Gleixner Cc: Richard Cochran Cc: Prarit Bhargava Cc: Stephen Boyd Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: John Stultz --- kernel/time/jiffies.c | 1 + kernel/time/timekeeping.c | 23 +++++++++++++++++++++++ lib/Kconfig.debug | 12 ++++++++++++ 3 files changed, 36 insertions(+) diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c index a6a5bf5..7e41390 100644 --- a/kernel/time/jiffies.c +++ b/kernel/time/jiffies.c @@ -71,6 +71,7 @@ static struct clocksource clocksource_jiffies = { .mask = 0xffffffff, /*32bits*/ .mult = NSEC_PER_JIFFY << JIFFIES_SHIFT, /* details above */ .shift = JIFFIES_SHIFT, + .max_cycles = 10, }; __cacheline_aligned_in_smp DEFINE_SEQLOCK(jiffies_lock); diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 6a93185..daa0d43 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -118,6 +118,26 @@ static inline void tk_update_sleep_time(struct timekeeper *tk, ktime_t delta) tk->offs_boot = ktime_add(tk->offs_boot, delta); } +#ifdef CONFIG_DEBUG_TIMEKEEPING +static void timekeeping_check_update(struct timekeeper *tk, cycle_t offset) +{ + + cycle_t max_cycles = tk->tkr.clock->max_cycles; + const char *name = tk->tkr.clock->name; + + if (offset > max_cycles) + printk_deferred("ERROR: cycle offset (%lld) is larger then" + " allowed %s max_cycles (%lld)\n", + offset, name, max_cycles); + else if (offset > (max_cycles >> 1)) + printk_deferred("WARNING: cycle offset (%lld) is past" + " the %s 50%% safety margin (%lld)\n", + offset, name, max_cycles>>1); +} +#else +#define timekeeping_check_update(x, y) +#endif + /** * tk_setup_internals - Set up internals to use clocksource clock. * @@ -1602,6 +1622,9 @@ void update_wall_time(void) if (offset < real_tk->cycle_interval) goto out; + /* Do some additional sanity checking */ + timekeeping_check_update(real_tk, offset); + /* * With NO_HZ we may have to accumulate many cycle_intervals * (think "ticks") worth of time at once. To do this efficiently, diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 5f2ce61..c7b040d 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -852,6 +852,18 @@ config SCHED_STACK_END_CHECK data corruption or a sporadic crash at a later stage once the region is examined. The runtime overhead introduced is minimal. +config DEBUG_TIMEKEEPING + bool "Enable extra timekeeping sanity checking" + help + This option will enable additional timekeeping sanity checks + which may be helpful when diagnoising issues where timekeeping + problems are suspected. + + This may include checks in the timekeeping hotpaths, so this + option may have a performance impact to some workloads. + + If unsure, say N. + config TIMER_STATS bool "Collect kernel timers statistics" depends on DEBUG_KERNEL && PROC_FS